mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 05:39:41 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
54 lines
1.9 KiB
JavaScript
54 lines
1.9 KiB
JavaScript
"use strict";
|
|
|
|
// This test requires an XMLHttpRequest constructor which isn't
|
|
// associated with a window.
|
|
const {XMLHttpRequest} = Cu.Sandbox(window, {wantGlobalProperties: ["XMLHttpRequest"]});
|
|
|
|
var {WebRequest} = ChromeUtils.import("resource://gre/modules/WebRequest.jsm");
|
|
var {PromiseUtils} = ChromeUtils.import("resource://gre/modules/PromiseUtils.jsm");
|
|
|
|
add_task(async function test_ancestors_exist() {
|
|
let deferred = PromiseUtils.defer();
|
|
function onBeforeRequest(details) {
|
|
info(`onBeforeRequest ${details.url}`);
|
|
ok(typeof details.frameAncestors === "object", `ancestors exists [${typeof details.frameAncestors}]`);
|
|
deferred.resolve();
|
|
}
|
|
|
|
WebRequest.onBeforeRequest.addListener(onBeforeRequest, {urls: new MatchPatternSet(["http://mochi.test/test/*"])}, ["blocking"]);
|
|
|
|
let tab = await BrowserTestUtils.openNewForegroundTab(gBrowser, "http://mochi.test:8888/test/");
|
|
await deferred.promise;
|
|
BrowserTestUtils.removeTab(tab);
|
|
|
|
WebRequest.onBeforeRequest.removeListener(onBeforeRequest);
|
|
});
|
|
|
|
add_task(async function test_ancestors_null() {
|
|
let deferred = PromiseUtils.defer();
|
|
function onBeforeRequest(details) {
|
|
info(`onBeforeRequest ${details.url}`);
|
|
ok(details.frameAncestors === undefined, "ancestors do not exist");
|
|
deferred.resolve();
|
|
}
|
|
|
|
WebRequest.onBeforeRequest.addListener(onBeforeRequest, null, ["blocking"]);
|
|
|
|
function fetch(url) {
|
|
return new Promise((resolve, reject) => {
|
|
let xhr = new XMLHttpRequest();
|
|
xhr.mozBackgroundRequest = true;
|
|
xhr.open("GET", url);
|
|
xhr.onload = () => { resolve(xhr.responseText); };
|
|
xhr.onerror = () => { reject(xhr.status); };
|
|
// use a different contextId to avoid auth cache.
|
|
xhr.setOriginAttributes({userContextId: 1});
|
|
xhr.send();
|
|
});
|
|
}
|
|
|
|
await fetch("http://mochi.test:8888/test/");
|
|
await deferred.promise;
|
|
|
|
WebRequest.onBeforeRequest.removeListener(onBeforeRequest);
|
|
});
|