mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
81 lines
2.3 KiB
JavaScript
81 lines
2.3 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
* http://creativecommons.org/publicdomain/zero/1.0/ */
|
|
|
|
const {BinarySearch} = ChromeUtils.import("resource://gre/modules/BinarySearch.jsm");
|
|
|
|
function run_test() {
|
|
// empty array
|
|
check([], 1, false, 0);
|
|
|
|
// one-element array
|
|
check([2], 2, true, 0);
|
|
check([2], 1, false, 0);
|
|
check([2], 3, false, 1);
|
|
|
|
// two-element array
|
|
check([2, 4], 2, true, 0);
|
|
check([2, 4], 4, true, 1);
|
|
check([2, 4], 1, false, 0);
|
|
check([2, 4], 3, false, 1);
|
|
check([2, 4], 5, false, 2);
|
|
|
|
// three-element array
|
|
check([2, 4, 6], 2, true, 0);
|
|
check([2, 4, 6], 4, true, 1);
|
|
check([2, 4, 6], 6, true, 2);
|
|
check([2, 4, 6], 1, false, 0);
|
|
check([2, 4, 6], 3, false, 1);
|
|
check([2, 4, 6], 5, false, 2);
|
|
check([2, 4, 6], 7, false, 3);
|
|
|
|
// duplicates
|
|
check([2, 2], 2, true, 0);
|
|
check([2, 2], 1, false, 0);
|
|
check([2, 2], 3, false, 2);
|
|
|
|
// duplicates on the left
|
|
check([2, 2, 4], 2, true, 1);
|
|
check([2, 2, 4], 4, true, 2);
|
|
check([2, 2, 4], 1, false, 0);
|
|
check([2, 2, 4], 3, false, 2);
|
|
check([2, 2, 4], 5, false, 3);
|
|
|
|
// duplicates on the right
|
|
check([2, 4, 4], 2, true, 0);
|
|
check([2, 4, 4], 4, true, 1);
|
|
check([2, 4, 4], 1, false, 0);
|
|
check([2, 4, 4], 3, false, 1);
|
|
check([2, 4, 4], 5, false, 3);
|
|
|
|
// duplicates in the middle
|
|
check([2, 4, 4, 6], 2, true, 0);
|
|
check([2, 4, 4, 6], 4, true, 1);
|
|
check([2, 4, 4, 6], 6, true, 3);
|
|
check([2, 4, 4, 6], 1, false, 0);
|
|
check([2, 4, 4, 6], 3, false, 1);
|
|
check([2, 4, 4, 6], 5, false, 3);
|
|
check([2, 4, 4, 6], 7, false, 4);
|
|
|
|
// duplicates all around
|
|
check([2, 2, 4, 4, 6, 6], 2, true, 0);
|
|
check([2, 2, 4, 4, 6, 6], 4, true, 2);
|
|
check([2, 2, 4, 4, 6, 6], 6, true, 4);
|
|
check([2, 2, 4, 4, 6, 6], 1, false, 0);
|
|
check([2, 2, 4, 4, 6, 6], 3, false, 2);
|
|
check([2, 2, 4, 4, 6, 6], 5, false, 4);
|
|
check([2, 2, 4, 4, 6, 6], 7, false, 6);
|
|
}
|
|
|
|
function check(array, target, expectedFound, expectedIdx) {
|
|
let [found, idx] = BinarySearch.search(cmp, array, target);
|
|
Assert.equal(found, expectedFound);
|
|
Assert.equal(idx, expectedIdx);
|
|
|
|
idx = expectedFound ? expectedIdx : -1;
|
|
Assert.equal(BinarySearch.indexOf(cmp, array, target), idx);
|
|
Assert.equal(BinarySearch.insertionIndexOf(cmp, array, target), expectedIdx);
|
|
}
|
|
|
|
function cmp(num1, num2) {
|
|
return num1 - num2;
|
|
}
|