mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-03 01:38:46 +02:00
56e315b983
The current shortcut detection was good enough for a long while -- it was mainly used for Telemetry purposes, and installer created shortcuts were almost always created anyways -- so both the rate of mismatches and the consequences of them were fairly low. This changed when we implemented Private taskbar pinning, most notably because when we're creating Private Browsing shortcuts in the installer (which we ought to do to work around various Windows bugs), we end up with 2 strings for the shortcut names (one for the installer, one for the browser). The other thing that has changed since this was originally implemented is that all of those code has moved off of the main thread -- so it is less perf-sensitive than it was before. With these two things in mind, making our shortcut detection much more accurate seems like the right thing to do. There's still rare cases (noted in the original comments) where it could be wrong -- but with this change we no longer rely on the file name, which can very easily be wrong for a number of reasons. This also includes a fix for a bug I introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1789974 that caused pinning not to work if a shortcut needed to be created at pinning time (unlikely except in zip builds, but still needs to be fixed). Differential Revision: https://phabricator.services.mozilla.com/D158799 |
||
|---|---|---|
| .. | ||
| content | ||
| search-provider-files | ||
| test | ||
| HeadlessShell.jsm | ||
| jar.mn | ||
| moz.build | ||
| nsGNOMEShellDBusHelper.cpp | ||
| nsGNOMEShellDBusHelper.h | ||
| nsGNOMEShellSearchProvider.cpp | ||
| nsGNOMEShellSearchProvider.h | ||
| nsGNOMEShellService.cpp | ||
| nsGNOMEShellService.h | ||
| nsIGNOMEShellService.idl | ||
| nsIMacShellService.idl | ||
| nsIShellService.idl | ||
| nsIWindowsShellService.idl | ||
| nsMacShellService.cpp | ||
| nsMacShellService.h | ||
| nsShellService.h | ||
| nsToolkitShellService.h | ||
| nsWindowsShellService.cpp | ||
| nsWindowsShellService.h | ||
| ScreenshotChild.jsm | ||
| ShellService.jsm | ||
| WindowsDefaultBrowser.cpp | ||
| WindowsDefaultBrowser.h | ||
| WindowsUserChoice.cpp | ||
| WindowsUserChoice.h | ||