mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 21:58:41 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
51 lines
1.7 KiB
JavaScript
51 lines
1.7 KiB
JavaScript
"use strict";
|
|
|
|
const {ForgetAboutSite} = ChromeUtils.import("resource://gre/modules/ForgetAboutSite.jsm");
|
|
|
|
add_task(async function() {
|
|
registerFakePath("ULibDir", do_get_file("Library/"));
|
|
let migrator = await MigrationUtils.getMigrator("chrome");
|
|
|
|
Assert.ok(await migrator.isSourceAvailable(), "Sanity check the source exists");
|
|
|
|
const COOKIE = {
|
|
expiry: 2145934800,
|
|
host: "unencryptedcookie.invalid",
|
|
isHttpOnly: false,
|
|
isSession: false,
|
|
name: "testcookie",
|
|
path: "/",
|
|
value: "testvalue",
|
|
};
|
|
|
|
// Sanity check.
|
|
Assert.equal(Services.cookies.countCookiesFromHost(COOKIE.host), 0,
|
|
"There are no cookies initially");
|
|
|
|
const PROFILE = {
|
|
id: "Default",
|
|
name: "Person 1",
|
|
};
|
|
|
|
// Migrate unencrypted cookies.
|
|
await promiseMigration(migrator, MigrationUtils.resourceTypes.COOKIES, PROFILE);
|
|
|
|
Assert.equal(Services.cookies.countCookiesFromHost(COOKIE.host), 1,
|
|
"Migrated the expected number of unencrypted cookies");
|
|
Assert.equal(Services.cookies.countCookiesFromHost("encryptedcookie.invalid"), 0,
|
|
"Migrated the expected number of encrypted cookies");
|
|
|
|
// Now check the cookie details.
|
|
let enumerator = Services.cookies.getCookiesFromHost(COOKIE.host, {});
|
|
Assert.ok(enumerator.hasMoreElements(), "Cookies available");
|
|
let foundCookie = enumerator.getNext().QueryInterface(Ci.nsICookie2);
|
|
|
|
for (let prop of Object.keys(COOKIE)) {
|
|
Assert.equal(foundCookie[prop], COOKIE[prop], "Check cookie " + prop);
|
|
}
|
|
|
|
// Cleanup.
|
|
await ForgetAboutSite.removeDataFromDomain(COOKIE.host);
|
|
Assert.equal(Services.cookies.countCookiesFromHost(COOKIE.host), 0,
|
|
"There are no cookies after cleanup");
|
|
});
|