mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 06:08:24 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
88 lines
4.1 KiB
JavaScript
88 lines
4.1 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
var EXPORTED_SYMBOLS = ["FormAutofill"];
|
|
|
|
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
const ADDRESSES_FIRST_TIME_USE_PREF = "extensions.formautofill.firstTimeUse";
|
|
const AUTOFILL_CREDITCARDS_AVAILABLE_PREF = "extensions.formautofill.creditCards.available";
|
|
const CREDITCARDS_USED_STATUS_PREF = "extensions.formautofill.creditCards.used";
|
|
const DEFAULT_REGION_PREF = "browser.search.region";
|
|
const ENABLED_AUTOFILL_ADDRESSES_PREF = "extensions.formautofill.addresses.enabled";
|
|
const ENABLED_AUTOFILL_CREDITCARDS_PREF = "extensions.formautofill.creditCards.enabled";
|
|
const SUPPORTED_COUNTRIES_PREF = "extensions.formautofill.supportedCountries";
|
|
|
|
XPCOMUtils.defineLazyPreferenceGetter(this, "logLevel", "extensions.formautofill.loglevel",
|
|
"Warn");
|
|
|
|
// A logging helper for debug logging to avoid creating Console objects
|
|
// or triggering expensive JS -> C++ calls when debug logging is not
|
|
// enabled.
|
|
//
|
|
// Console objects, even natively-implemented ones, can consume a lot of
|
|
// memory, and since this code may run in every content process, that
|
|
// memory can add up quickly. And, even when debug-level messages are
|
|
// being ignored, console.debug() calls can be expensive.
|
|
//
|
|
// This helper avoids both of those problems by never touching the
|
|
// console object unless debug logging is enabled.
|
|
function debug() {
|
|
if (logLevel.toLowerCase() == "debug") {
|
|
this.log.debug(...arguments);
|
|
}
|
|
}
|
|
|
|
var FormAutofill = {
|
|
ENABLED_AUTOFILL_ADDRESSES_PREF,
|
|
ENABLED_AUTOFILL_CREDITCARDS_PREF,
|
|
ADDRESSES_FIRST_TIME_USE_PREF,
|
|
CREDITCARDS_USED_STATUS_PREF,
|
|
|
|
get isAutofillEnabled() { return FormAutofill.isAutofillAddressesEnabled || this.isAutofillCreditCardsEnabled; },
|
|
get isAutofillCreditCardsEnabled() { return FormAutofill.isAutofillCreditCardsAvailable && FormAutofill._isAutofillCreditCardsEnabled; },
|
|
|
|
defineLazyLogGetter(scope, logPrefix) {
|
|
scope.debug = debug;
|
|
|
|
XPCOMUtils.defineLazyGetter(scope, "log", () => {
|
|
let ConsoleAPI = ChromeUtils.import("resource://gre/modules/Console.jsm", {}).ConsoleAPI;
|
|
return new ConsoleAPI({
|
|
maxLogLevelPref: "extensions.formautofill.loglevel",
|
|
prefix: logPrefix,
|
|
});
|
|
});
|
|
},
|
|
};
|
|
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"DEFAULT_REGION", DEFAULT_REGION_PREF, "US");
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"isAutofillAddressesEnabled", ENABLED_AUTOFILL_ADDRESSES_PREF);
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"isAutofillCreditCardsAvailable", AUTOFILL_CREDITCARDS_AVAILABLE_PREF);
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"_isAutofillCreditCardsEnabled", ENABLED_AUTOFILL_CREDITCARDS_PREF);
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"isAutofillAddressesFirstTimeUse", ADDRESSES_FIRST_TIME_USE_PREF);
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"AutofillCreditCardsUsedStatus", CREDITCARDS_USED_STATUS_PREF);
|
|
XPCOMUtils.defineLazyPreferenceGetter(FormAutofill,
|
|
"supportedCountries", SUPPORTED_COUNTRIES_PREF, null, null,
|
|
val => val.split(","));
|
|
|
|
// XXX: This should be invalidated on intl:app-locales-changed.
|
|
XPCOMUtils.defineLazyGetter(FormAutofill, "countries", () => {
|
|
let availableRegionCodes = Services.intl.getAvailableLocaleDisplayNames("region");
|
|
let displayNames = Services.intl.getRegionDisplayNames(undefined, availableRegionCodes);
|
|
let result = new Map();
|
|
for (let i = 0; i < availableRegionCodes.length; i++) {
|
|
result.set(availableRegionCodes[i].toUpperCase(), displayNames[i]);
|
|
}
|
|
return result;
|
|
});
|
|
|