mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 22:28:59 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
70 lines
2.3 KiB
JavaScript
70 lines
2.3 KiB
JavaScript
"use strict";
|
|
|
|
var LabelUtils;
|
|
add_task(async function() {
|
|
({LabelUtils} = ChromeUtils.import("resource://formautofill/FormAutofillHeuristics.jsm"));
|
|
});
|
|
|
|
const TESTCASES = [
|
|
{
|
|
description: "A label element contains one input element.",
|
|
document: `<label id="typeA"> label type A
|
|
<!-- This comment should not be extracted. -->
|
|
<input type="text">
|
|
<script>FOO</script>
|
|
<noscript>FOO</noscript>
|
|
<option>FOO</option>
|
|
<style>FOO</style>
|
|
</label>`,
|
|
inputId: "typeA",
|
|
expectedStrings: ["label type A"],
|
|
},
|
|
{
|
|
description: "A label element with inner div contains one input element.",
|
|
document: `<label id="typeB"> label type B
|
|
<!-- This comment should not be extracted. -->
|
|
<script>FOO</script>
|
|
<noscript>FOO</noscript>
|
|
<option>FOO</option>
|
|
<style>FOO</style>
|
|
<div> inner div
|
|
<input type="text">
|
|
</div>
|
|
</label>`,
|
|
inputId: "typeB",
|
|
expectedStrings: ["label type B", "inner div"],
|
|
},
|
|
{
|
|
description: "A label element with inner prefix/postfix strings contains span elements.",
|
|
document: `<label id="typeC"> label type C
|
|
<!-- This comment should not be extracted. -->
|
|
<script>FOO</script>
|
|
<noscript>FOO</noscript>
|
|
<option>FOO</option>
|
|
<style>FOO</style>
|
|
<div> inner div prefix
|
|
<span>test C-1 </span>
|
|
<span> test C-2</span>
|
|
inner div postfix
|
|
</div>
|
|
</label>`,
|
|
inputId: "typeC",
|
|
expectedStrings: ["label type C", "inner div prefix", "test C-1",
|
|
"test C-2", "inner div postfix"],
|
|
},
|
|
];
|
|
|
|
TESTCASES.forEach(testcase => {
|
|
add_task(async function() {
|
|
info("Starting testcase: " + testcase.description);
|
|
LabelUtils._labelStrings = new WeakMap();
|
|
|
|
let doc = MockDocument.createTestDocument(
|
|
"http://localhost:8080/test/", testcase.document);
|
|
|
|
let element = doc.getElementById(testcase.inputId);
|
|
let strings = LabelUtils.extractLabelStrings(element);
|
|
|
|
Assert.deepEqual(strings, testcase.expectedStrings);
|
|
});
|
|
});
|