mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 06:08:24 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
94 lines
3.2 KiB
JavaScript
94 lines
3.2 KiB
JavaScript
"use strict";
|
|
|
|
var LabelUtils;
|
|
add_task(async function() {
|
|
({LabelUtils} = ChromeUtils.import("resource://formautofill/FormAutofillHeuristics.jsm"));
|
|
});
|
|
|
|
const TESTCASES = [
|
|
{
|
|
description: "Input contains in a label element.",
|
|
document: `<form>
|
|
<label id="labelA"> label type A
|
|
<input id="typeA" type="text">
|
|
</label>
|
|
</form>`,
|
|
inputId: "typeA",
|
|
expectedLabelIds: ["labelA"],
|
|
},
|
|
{
|
|
description: "Input contains in a label element.",
|
|
document: `<label id="labelB"> label type B
|
|
<div> inner div
|
|
<input id="typeB" type="text">
|
|
</div>
|
|
</label>`,
|
|
inputId: "typeB",
|
|
expectedLabelIds: ["labelB"],
|
|
},
|
|
{
|
|
description: "\"for\" attribute used to indicate input by one label.",
|
|
document: `<label id="labelC" for="typeC">label type C</label>
|
|
<input id="typeC" type="text">`,
|
|
inputId: "typeC",
|
|
expectedLabelIds: ["labelC"],
|
|
},
|
|
{
|
|
description: "\"for\" attribute used to indicate input by multiple labels.",
|
|
document: `<form>
|
|
<label id="labelD1" for="typeD">label type D1</label>
|
|
<label id="labelD2" for="typeD">label type D2</label>
|
|
<label id="labelD3" for="typeD">label type D3</label>
|
|
<input id="typeD" type="text">
|
|
</form>`,
|
|
inputId: "typeD",
|
|
expectedLabelIds: ["labelD1", "labelD2", "labelD3"],
|
|
},
|
|
{
|
|
description: "\"for\" attribute used to indicate input by multiple labels with space prefix/postfix.",
|
|
document: `<label id="labelE1" for="typeE">label type E1</label>
|
|
<label id="labelE2" for="typeE ">label type E2</label>
|
|
<label id="labelE3" for=" TYPEe">label type E3</label>
|
|
<label id="labelE4" for=" typeE ">label type E4</label>
|
|
<input id=" typeE " type="text">`,
|
|
inputId: " typeE ",
|
|
expectedLabelIds: [],
|
|
},
|
|
{
|
|
description: "Input contains in a label element.",
|
|
document: `<label id="labelF"> label type F
|
|
<label for="dummy"> inner label
|
|
<input id="typeF" type="text">
|
|
<input id="dummy" type="text">
|
|
</div>
|
|
</label>`,
|
|
inputId: "typeF",
|
|
expectedLabelIds: ["labelF"],
|
|
},
|
|
{
|
|
description: "\"for\" attribute used to indicate input by labels out of the form.",
|
|
document: `<label id="labelG1" for="typeG">label type G1</label>
|
|
<form>
|
|
<label id="labelG2" for="typeG">label type G2</label>
|
|
<input id="typeG" type="text">
|
|
</form>
|
|
<label id="labelG3" for="typeG">label type G3</label>`,
|
|
inputId: "typeG",
|
|
expectedLabelIds: ["labelG1", "labelG2", "labelG3"],
|
|
},
|
|
];
|
|
|
|
TESTCASES.forEach(testcase => {
|
|
add_task(async function() {
|
|
info("Starting testcase: " + testcase.description);
|
|
|
|
let doc = MockDocument.createTestDocument(
|
|
"http://localhost:8080/test/", testcase.document);
|
|
|
|
let input = doc.getElementById(testcase.inputId);
|
|
let labels = LabelUtils.findLabelElements(input);
|
|
|
|
Assert.deepEqual(labels.map(l => l.id), testcase.expectedLabelIds);
|
|
LabelUtils.clearLabelMap();
|
|
});
|
|
});
|