mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 22:28:59 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
86 lines
2.8 KiB
JavaScript
86 lines
2.8 KiB
JavaScript
"use strict";
|
|
|
|
const TESTCASES = [
|
|
{
|
|
description: "Form containing 8 fields with autocomplete attribute.",
|
|
document: `<form>
|
|
<input id="given-name" autocomplete="given-name">
|
|
<input id="additional-name" autocomplete="additional-name">
|
|
<input id="family-name" autocomplete="family-name">
|
|
<input id="street-addr" autocomplete="street-address">
|
|
<input id="city" autocomplete="address-level2">
|
|
<input id="country" autocomplete="country">
|
|
<input id="email" autocomplete="email">
|
|
<input id="tel" autocomplete="tel">
|
|
<input id="without-autocomplete-1">
|
|
<input id="without-autocomplete-2">
|
|
</form>`,
|
|
targetElementId: "given-name",
|
|
expectedResult: [
|
|
"given-name",
|
|
"additional-name",
|
|
"family-name",
|
|
"street-addr",
|
|
"city",
|
|
"country",
|
|
"email",
|
|
"tel",
|
|
],
|
|
},
|
|
{
|
|
description: "Form containing only 2 fields with autocomplete attribute.",
|
|
document: `<form>
|
|
<input id="street-addr" autocomplete="street-address">
|
|
<input id="city" autocomplete="address-level2">
|
|
<input id="without-autocomplete-1">
|
|
<input id="without-autocomplete-2">
|
|
</form>`,
|
|
targetElementId: "street-addr",
|
|
expectedResult: [],
|
|
},
|
|
{
|
|
description: "Fields without form element.",
|
|
document: `<input id="street-addr" autocomplete="street-address">
|
|
<input id="city" autocomplete="address-level2">
|
|
<input id="country" autocomplete="country">
|
|
<input id="email" autocomplete="email">
|
|
<input id="tel" autocomplete="tel">
|
|
<input id="without-autocomplete-1">
|
|
<input id="without-autocomplete-2">`,
|
|
targetElementId: "street-addr",
|
|
expectedResult: [
|
|
"street-addr",
|
|
"city",
|
|
"country",
|
|
"email",
|
|
"tel",
|
|
],
|
|
},
|
|
];
|
|
|
|
let markedFieldId = [];
|
|
|
|
var FormAutofillContent;
|
|
add_task(async function setup() {
|
|
({FormAutofillContent} = ChromeUtils.import("resource://formautofill/FormAutofillContent.jsm"));
|
|
|
|
FormAutofillContent._markAsAutofillField = function(field) {
|
|
markedFieldId.push(field.id);
|
|
};
|
|
});
|
|
|
|
TESTCASES.forEach(testcase => {
|
|
add_task(async function() {
|
|
info("Starting testcase: " + testcase.description);
|
|
|
|
markedFieldId = [];
|
|
|
|
let doc = MockDocument.createTestDocument(
|
|
"http://localhost:8080/test/", testcase.document);
|
|
let element = doc.getElementById(testcase.targetElementId);
|
|
FormAutofillContent.identifyAutofillFields(element);
|
|
|
|
Assert.deepEqual(markedFieldId, testcase.expectedResult,
|
|
"Check the fields were marked correctly.");
|
|
});
|
|
});
|