mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
43 lines
2 KiB
JavaScript
43 lines
2 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
* http://creativecommons.org/publicdomain/zero/1.0/
|
|
*/
|
|
|
|
/* globals ChromeUtils, Services, Cc, Ci, HomePage, Assert, add_task */
|
|
"use strict";
|
|
|
|
const {HomePage} = ChromeUtils.import("resource:///modules/HomePage.jsm");
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
add_task(function testHomePage() {
|
|
Assert.ok(!HomePage.overridden, "Homepage should not be overriden by default.");
|
|
let newvalue = "about:blank|about:newtab";
|
|
HomePage.set(newvalue);
|
|
Assert.ok(HomePage.overridden, "Homepage should be overriden after set()");
|
|
Assert.equal(HomePage.get(), newvalue, "Homepage should be ${newvalue}");
|
|
Assert.notEqual(HomePage.getDefault(), newvalue, "Homepage should be ${newvalue}");
|
|
HomePage.reset();
|
|
Assert.ok(!HomePage.overridden, "Homepage should not be overriden by after reset.");
|
|
Assert.equal(HomePage.get(), HomePage.getDefault(),
|
|
"Homepage and default should be equal after reset.");
|
|
});
|
|
|
|
add_task(function readLocalizedHomepage() {
|
|
let newvalue = "data:text/plain,browser.startup.homepage%3Dabout%3Alocalized";
|
|
let complexvalue = Cc["@mozilla.org/pref-localizedstring;1"]
|
|
.createInstance(Ci.nsIPrefLocalizedString);
|
|
complexvalue.data = newvalue;
|
|
Services.prefs.getDefaultBranch(null).setComplexValue(
|
|
"browser.startup.homepage",
|
|
Ci.nsIPrefLocalizedString,
|
|
complexvalue);
|
|
Assert.ok(!HomePage.overridden, "Complex value only works as default");
|
|
Assert.equal(HomePage.get(), "about:localized", "Get value from bundle");
|
|
});
|
|
|
|
add_task(function recoverEmptyHomepage() {
|
|
Assert.ok(!HomePage.overridden, "Homepage should not be overriden by default.");
|
|
Services.prefs.setStringPref("browser.startup.homepage", "");
|
|
Assert.ok(HomePage.overridden, "Homepage is overriden with empty string.");
|
|
Assert.equal(HomePage.get(), HomePage.getDefault(), "Recover is default");
|
|
Assert.ok(!HomePage.overridden, "Recover should have set default");
|
|
});
|