mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
64 lines
2.2 KiB
JavaScript
64 lines
2.2 KiB
JavaScript
"use strict";
|
|
|
|
const {AppConstants} = ChromeUtils.import("resource://gre/modules/AppConstants.jsm");
|
|
|
|
add_task(async function() {
|
|
let webNav = Services.appShell.createWindowlessBrowser(false);
|
|
|
|
let docShell = webNav.docShell;
|
|
|
|
let loadContext = docShell.QueryInterface(Ci.nsILoadContext);
|
|
|
|
equal(loadContext.usePrivateBrowsing, false, "Should start out in non-private mode");
|
|
|
|
loadContext.usePrivateBrowsing = true;
|
|
equal(loadContext.usePrivateBrowsing, true,
|
|
"Should be able to change to private mode prior to a document load");
|
|
|
|
loadContext.usePrivateBrowsing = false;
|
|
equal(loadContext.usePrivateBrowsing, false,
|
|
"Should be able to change to non-private mode prior to a document load");
|
|
|
|
let oa = docShell.getOriginAttributes();
|
|
|
|
oa.privateBrowsingId = 1;
|
|
docShell.setOriginAttributes(oa);
|
|
|
|
equal(loadContext.usePrivateBrowsing, true,
|
|
"Should be able to change origin attributes prior to a document load");
|
|
|
|
oa.privateBrowsingId = 0;
|
|
docShell.setOriginAttributes(oa);
|
|
|
|
equal(loadContext.usePrivateBrowsing, false,
|
|
"Should be able to change origin attributes prior to a document load");
|
|
|
|
let loadURIOptions = {
|
|
triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal(),
|
|
};
|
|
webNav.loadURI("data:text/html,", loadURIOptions);
|
|
|
|
// Return to the event loop so the load can begin.
|
|
await new Promise(executeSoon);
|
|
|
|
// This causes a failed assertion rather than an exception on debug
|
|
// builds.
|
|
if (!AppConstants.DEBUG) {
|
|
Assert.throws(() => { loadContext.usePrivateBrowsing = true; },
|
|
/NS_ERROR_FAILURE/,
|
|
"Should not be able to change private browsing state after initial load has started");
|
|
|
|
oa.privateBrowsingId = 1;
|
|
Assert.throws(() => { docShell.setOriginAttributes(oa); },
|
|
/NS_ERROR_FAILURE/,
|
|
"Should not be able to change origin attributes after initial load has started");
|
|
|
|
equal(loadContext.usePrivateBrowsing, false,
|
|
"Should not be able to change private browsing state after initial load has started");
|
|
|
|
loadContext.usePrivateBrowsing = false;
|
|
ok(true, "Should be able to set usePrivateBrowsing to its current value even after initial load");
|
|
}
|
|
|
|
webNav.close();
|
|
});
|