mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 06:08:24 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
59 lines
1.9 KiB
JavaScript
59 lines
1.9 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
var {HttpServer} = ChromeUtils.import("resource://testing-common/httpd.js");
|
|
|
|
var server = new HttpServer();
|
|
server.start(-1);
|
|
|
|
const SERVER_PORT = server.identity.primaryPort;
|
|
const HTTP_BASE = "http://localhost:" + SERVER_PORT;
|
|
const redirectPath = "/redirect";
|
|
const headerCheckPath = "/headerCheck";
|
|
const redirectURL = HTTP_BASE + redirectPath;
|
|
const headerCheckURL = HTTP_BASE + headerCheckPath;
|
|
|
|
function redirectHandler(metadata, response) {
|
|
response.setStatusLine(metadata.httpVersion, 302, "Found");
|
|
response.setHeader("Location", headerCheckURL, false);
|
|
}
|
|
|
|
function headerCheckHandler(metadata, response) {
|
|
try {
|
|
let headerValue = metadata.getHeader("X-Custom-Header");
|
|
Assert.equal(headerValue, "present");
|
|
} catch (e) {
|
|
do_throw("No header present after redirect");
|
|
}
|
|
try {
|
|
metadata.getHeader("X-Unwanted-Header");
|
|
do_throw("Unwanted header present after redirect");
|
|
} catch (x) {
|
|
}
|
|
response.setStatusLine(metadata.httpVersion, 200, "OK");
|
|
response.setHeader("Content-Type", "text/plain");
|
|
response.write("");
|
|
}
|
|
|
|
function run_test() {
|
|
server.registerPathHandler(redirectPath, redirectHandler);
|
|
server.registerPathHandler(headerCheckPath, headerCheckHandler);
|
|
|
|
do_test_pending();
|
|
var request = new XMLHttpRequest();
|
|
request.open("GET", redirectURL, true);
|
|
request.setRequestHeader("X-Custom-Header", "present");
|
|
request.addEventListener("readystatechange", function() {
|
|
if (request.readyState == 4) {
|
|
Assert.equal(request.status, 200);
|
|
server.stop(do_test_finished);
|
|
}
|
|
});
|
|
request.send();
|
|
try {
|
|
request.setRequestHeader("X-Unwanted-Header", "present");
|
|
do_throw("Shouldn't be able to set a header after send");
|
|
} catch (x) {
|
|
}
|
|
}
|