mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 05:39:41 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
142 lines
3.5 KiB
JavaScript
142 lines
3.5 KiB
JavaScript
let port;
|
|
let mm;
|
|
|
|
function info(message) {
|
|
return opener.wrappedJSObject.info(message);
|
|
}
|
|
|
|
function ok(condition, message) {
|
|
return opener.wrappedJSObject.ok(condition, message);
|
|
}
|
|
|
|
function is(v1, v2, message) {
|
|
return opener.wrappedJSObject.is(v1, v2, message);
|
|
}
|
|
|
|
function todo_is(v1, v2, message) {
|
|
return opener.wrappedJSObject.todo_is(v1, v2, message);
|
|
}
|
|
|
|
function finish() {
|
|
opener.setTimeout("done()", 0);
|
|
window.close();
|
|
}
|
|
|
|
function debug(msg) {
|
|
dump("[mmMessageChannelParent]" + msg + "\n");
|
|
}
|
|
|
|
let tests = [ basic_test,
|
|
close_test,
|
|
empty_transferable,
|
|
not_transferable];
|
|
|
|
// Test Routine
|
|
function run_tests() {
|
|
let test = tests.shift();
|
|
if (test === undefined) {
|
|
finish();
|
|
return;
|
|
}
|
|
|
|
test(function() {
|
|
setTimeout(run_tests,0);
|
|
});
|
|
}
|
|
|
|
// Basic communication test.
|
|
function basic_test(finish) {
|
|
ok(mm, "basic_test");
|
|
|
|
let finishPrepare = (msg) => {
|
|
is(msg.data.message, "OK", "");
|
|
ok(port, "");
|
|
port.onmessage = (msg) => {
|
|
is(msg.data, "BasicTest:TestOK", "");
|
|
finish();
|
|
}
|
|
port.postMessage("BasicTest:StartTest");
|
|
mm.removeMessageListener("BasicTest:FinishPrepare", finishPrepare);
|
|
};
|
|
|
|
let channel = new MessageChannel();
|
|
port = channel.port2;
|
|
mm.addMessageListener("BasicTest:FinishPrepare", finishPrepare);
|
|
mm.sendAsyncMessage("BasicTest:PortCreated", {}, {}, undefined, [channel.port1]);
|
|
}
|
|
|
|
// Communicate with closed port.
|
|
function close_test(finish) {
|
|
ok(mm, "close_test");
|
|
|
|
let finishPrepare = (msg) => {
|
|
is(msg.data.message, "OK", "");
|
|
ok(port, "");
|
|
|
|
port.onmessage = (msg) => {
|
|
ok(false, "Port is alive.");
|
|
finish();
|
|
}
|
|
|
|
port.postMessage("CloseTest:StartTest");
|
|
mm.removeMessageListener("CloseTest:FinishPrepare", finishPrepare);
|
|
finish();
|
|
}
|
|
|
|
let channel = new MessageChannel();
|
|
port = channel.port2;
|
|
mm.addMessageListener("CloseTest:FinishPrepare", finishPrepare);
|
|
mm.sendAsyncMessage("CloseTest:PortCreated", {}, {}, undefined, [channel.port1]);
|
|
}
|
|
|
|
// Empty transferable object
|
|
function empty_transferable(finish) {
|
|
ok(mm, "empty_transferable");
|
|
|
|
let finishPrepare = (msg) => {
|
|
ok(true, "Same basic test.");
|
|
mm.removeMessageListener("EmptyTest:FinishPrepare", finishPrepare);
|
|
finish();
|
|
};
|
|
|
|
mm.addMessageListener("EmptyTest:FinishPrepare", finishPrepare);
|
|
mm.sendAsyncMessage("EmptyTest:PortCreated", {}, {}, undefined, []);
|
|
}
|
|
|
|
// Not transferable object.
|
|
function not_transferable(finish) {
|
|
ok(mm, "not_transferable");
|
|
|
|
let finishPrepare = (msg) => {
|
|
ok(true, "Same basic test.");
|
|
finish();
|
|
}
|
|
|
|
mm.addMessageListener("NotTransferableTest:FinishPrepare", finishPrepare);
|
|
mm.sendAsyncMessage("NotTransferableTest:PortCreated", {}, {}, undefined, [""]);
|
|
}
|
|
|
|
/*
|
|
* Test preparation
|
|
*/
|
|
function finishLoad(msg) {
|
|
run_tests();
|
|
}
|
|
|
|
function prepare_test() {
|
|
debug("start run_tests()");
|
|
var node = document.getElementById('messagechannel_remote');
|
|
mm = node.messageManager; //Services.ppmm.getChildAt(1);
|
|
ok(mm, "created MessageManager.")
|
|
|
|
mm.addMessageListener("mmMessagePort:finishScriptLoad", finishLoad);
|
|
mm.addMessageListener("mmMessagePort:fail", failed_test);
|
|
//mm.loadProcessScript("chrome://mochitests/content/chrome/dom/messagechannel/tests/mm_messageChannel.js", true);
|
|
mm.loadFrameScript("chrome://mochitests/content/chrome/dom/messagechannel/tests/mm_messageChannel.js", true);
|
|
ok(true, "Loaded");
|
|
}
|
|
|
|
function failed_test() {
|
|
debug("failed test in child process");
|
|
ok(false, "");
|
|
}
|