mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 14:20:14 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
40 lines
1.4 KiB
JavaScript
40 lines
1.4 KiB
JavaScript
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
let tgt = {};
|
|
|
|
Services.prefs.setBoolPref("security.allow_eval_with_system_principal", true);
|
|
|
|
registerCleanupFunction(() => {
|
|
Services.prefs.clearUserPref("security.allow_eval_with_system_principal");
|
|
});
|
|
|
|
Services.scriptloader.loadSubScript("resource://test/environment_script.js", tgt);
|
|
|
|
var bound = "";
|
|
var tgt_bound = "";
|
|
|
|
// Check global bindings
|
|
try { void vu; bound += "vu,"; } catch (e) {}
|
|
try { void vq; bound += "vq,"; } catch (e) {}
|
|
try { void vl; bound += "vl,"; } catch (e) {}
|
|
try { void gt; bound += "gt,"; } catch (e) {}
|
|
try { void ed; bound += "ed,"; } catch (e) {}
|
|
try { void ei; bound += "ei,"; } catch (e) {}
|
|
try { void fo; bound += "fo,"; } catch (e) {}
|
|
try { void fi; bound += "fi,"; } catch (e) {}
|
|
try { void fd; bound += "fd,"; } catch (e) {}
|
|
|
|
// Check target bindings
|
|
for (var name of ["vu", "vq", "vl", "gt", "ed", "ei", "fo", "fi", "fd"])
|
|
if (tgt.hasOwnProperty(name))
|
|
tgt_bound += name + ",";
|
|
|
|
|
|
// Expected subscript loader behavior is as follows:
|
|
// - Qualified vars and |this| access occur on target object
|
|
// - Lexical vars occur on ExtensibleLexicalEnvironment of target object
|
|
// - Bareword assignments and global |this| access occur on caller's global
|
|
if (bound != "vu,ei,fo,fi,")
|
|
throw new Error("Unexpected global binding set - " + bound);
|
|
if (tgt_bound != "vq,gt,ed,fd,")
|
|
throw new Error("Unexpected target binding set - " + tgt_bound);
|