mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 06:08:24 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
72 lines
2 KiB
JavaScript
72 lines
2 KiB
JavaScript
// Test that the onGarbageCollection reentrancy guard is on a per Debugger
|
|
// basis. That is if our first Debugger is observing our second Debugger's
|
|
// compartment, and this second Debugger triggers a GC inside its
|
|
// onGarbageCollection hook, the first Debugger's onGarbageCollection hook is
|
|
// still called.
|
|
//
|
|
// This is the scenario we are setting up: top level debugging the `debuggeree`
|
|
// global, which is debugging the `debuggee` global. Then, we trigger the
|
|
// following events:
|
|
//
|
|
// debuggee gc
|
|
// |
|
|
// V
|
|
// debuggeree's onGarbageCollection
|
|
// |
|
|
// V
|
|
// debuggeree gc
|
|
// |
|
|
// V
|
|
// top level onGarbageCollection
|
|
//
|
|
// Note that the top level's onGarbageCollection hook should be fired, at the
|
|
// same time that we are preventing reentrancy into debuggeree's
|
|
// onGarbageCollection hook.
|
|
|
|
Services.prefs.setBoolPref("security.allow_eval_with_system_principal", true);
|
|
registerCleanupFunction(() => {
|
|
Services.prefs.clearUserPref("security.allow_eval_with_system_principal");
|
|
});
|
|
|
|
function run_test() {
|
|
do_test_pending();
|
|
|
|
const debuggeree = newGlobal();
|
|
const debuggee = debuggeree.debuggee = newGlobal();
|
|
|
|
debuggeree.eval(
|
|
`
|
|
var dbg = new Debugger(this.debuggee);
|
|
var fired = 0;
|
|
dbg.memory.onGarbageCollection = _ => {
|
|
fired++;
|
|
gc(this);
|
|
};
|
|
`
|
|
);
|
|
|
|
const dbg = new Debugger(debuggeree);
|
|
let fired = 0;
|
|
dbg.memory.onGarbageCollection = _ => {
|
|
fired++;
|
|
};
|
|
|
|
debuggee.eval(`gc(this)`);
|
|
|
|
// Let first onGarbageCollection runnable get run.
|
|
executeSoon(() => {
|
|
|
|
// Let second onGarbageCollection runnable get run.
|
|
executeSoon(() => {
|
|
|
|
// Even though we request GC'ing a single zone, we can't rely on that
|
|
// behavior and both zones could have been scheduled for gc for both
|
|
// gc(this) calls.
|
|
ok(debuggeree.fired >= 1);
|
|
ok(fired >= 1);
|
|
|
|
debuggeree.dbg.enabled = dbg.enabled = false;
|
|
do_test_finished();
|
|
});
|
|
});
|
|
}
|