mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 13:48:23 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
86 lines
2.7 KiB
JavaScript
86 lines
2.7 KiB
JavaScript
/*
|
|
Any copyright is dedicated to the Public Domain.
|
|
http://creativecommons.org/publicdomain/zero/1.0/
|
|
*/
|
|
|
|
function test() {
|
|
waitForExplicitFinish();
|
|
|
|
// We overload this test to include verifying that httpd.js is
|
|
// importable as a testing-only JS module.
|
|
ChromeUtils.import("resource://testing-common/httpd.js", {});
|
|
|
|
nextTest();
|
|
}
|
|
|
|
function nextTest() {
|
|
if (tests.length)
|
|
executeSoon(tests.shift());
|
|
else
|
|
executeSoon(finish);
|
|
}
|
|
|
|
var tests = [
|
|
test_asyncFetchBadCert,
|
|
];
|
|
|
|
function test_asyncFetchBadCert() {
|
|
// Try a load from an untrusted cert, with errors supressed
|
|
NetUtil.asyncFetch({
|
|
uri: "https://untrusted.example.com",
|
|
loadUsingSystemPrincipal: true
|
|
}, function (aInputStream, aStatusCode, aRequest) {
|
|
ok(!Components.isSuccessCode(aStatusCode), "request failed");
|
|
ok(aRequest instanceof Ci.nsIHttpChannel, "request is an nsIHttpChannel");
|
|
|
|
// Now try again with a channel whose notificationCallbacks doesn't suprress errors
|
|
let channel = NetUtil.newChannel({
|
|
uri: "https://untrusted.example.com",
|
|
loadUsingSystemPrincipal: true});
|
|
channel.notificationCallbacks = {
|
|
QueryInterface: ChromeUtils.generateQI([Ci.nsIProgressEventSink,
|
|
Ci.nsIInterfaceRequestor]),
|
|
getInterface: function (aIID) { return this.QueryInterface(aIID); },
|
|
onProgress: function () {},
|
|
onStatus: function () {}
|
|
};
|
|
NetUtil.asyncFetch(channel, function (aInputStream, aStatusCode, aRequest) {
|
|
ok(!Components.isSuccessCode(aStatusCode), "request failed");
|
|
ok(aRequest instanceof Ci.nsIHttpChannel, "request is an nsIHttpChannel");
|
|
|
|
// Now try a valid request
|
|
NetUtil.asyncFetch({
|
|
uri: "https://example.com",
|
|
loadUsingSystemPrincipal: true
|
|
}, function (aInputStream, aStatusCode, aRequest) {
|
|
info("aStatusCode for valid request: " + aStatusCode);
|
|
ok(Components.isSuccessCode(aStatusCode), "request succeeded");
|
|
ok(aRequest instanceof Ci.nsIHttpChannel, "request is an nsIHttpChannel");
|
|
ok(aRequest.requestSucceeded, "HTTP request succeeded");
|
|
|
|
nextTest();
|
|
});
|
|
});
|
|
});
|
|
}
|
|
|
|
function WindowListener(aURL, aCallback) {
|
|
this.callback = aCallback;
|
|
this.url = aURL;
|
|
}
|
|
WindowListener.prototype = {
|
|
onOpenWindow: function(aXULWindow) {
|
|
var domwindow = aXULWindow.docShell.domWindow;
|
|
var self = this;
|
|
domwindow.addEventListener("load", function() {
|
|
if (domwindow.document.location.href != self.url)
|
|
return;
|
|
|
|
// Allow other window load listeners to execute before passing to callback
|
|
executeSoon(function() {
|
|
self.callback(domwindow);
|
|
});
|
|
}, {once: true});
|
|
},
|
|
onCloseWindow: function(aXULWindow) {},
|
|
}
|