mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 05:39:41 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
40 lines
1.3 KiB
JavaScript
40 lines
1.3 KiB
JavaScript
/* atomic-file-output-stream and safe-file-output-stream should throw and
|
|
* exception if PR_APPEND is explicity specified without PR_TRUNCATE. */
|
|
|
|
const PR_WRONLY = 0x02;
|
|
const PR_CREATE_FILE = 0x08;
|
|
const PR_APPEND = 0x10;
|
|
const PR_TRUNCATE = 0x20;
|
|
|
|
function check_flag(file, contractID, flags, throws) {
|
|
let stream = Cc[contractID].createInstance(Ci.nsIFileOutputStream);
|
|
|
|
if (throws) {
|
|
/* NS_ERROR_INVALID_ARG is reported as NS_ERROR_ILLEGAL_VALUE, since they
|
|
* are same value. */
|
|
Assert.throws(() => stream.init(file, flags, 0o644, 0),
|
|
/NS_ERROR_ILLEGAL_VALUE/);
|
|
} else {
|
|
stream.init(file, flags, 0o644, 0);
|
|
stream.close();
|
|
}
|
|
}
|
|
|
|
function run_test() {
|
|
let filename = "test.txt";
|
|
let file = Services.dirsvc.get("TmpD", Ci.nsIFile);
|
|
file.append(filename);
|
|
|
|
let tests = [
|
|
[PR_WRONLY | PR_CREATE_FILE | PR_APPEND | PR_TRUNCATE, false],
|
|
[PR_WRONLY | PR_CREATE_FILE | PR_TRUNCATE, false],
|
|
[PR_WRONLY | PR_CREATE_FILE | PR_APPEND, true],
|
|
[-1, false],
|
|
];
|
|
for (let contractID of ["@mozilla.org/network/atomic-file-output-stream;1",
|
|
"@mozilla.org/network/safe-file-output-stream;1"]) {
|
|
for (let [flags, throws] of tests) {
|
|
check_flag(file, contractID, flags, throws);
|
|
}
|
|
}
|
|
}
|