mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-11 21:58:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
gecko-dev/testing/web-platform/tests/css/CSS2/floats-clear
History
Ian Kilpatrick 0346bf40af Bug 1523562 [wpt PR 15003] - [LayoutNG] Fix crash related to clearance and margin collapsing., a=testonly 
Automatic update from web-platform-tests
[LayoutNG] Fix crash related to clearance and margin collapsing.

The root of this bug was that the parent bfc, and child with clearance
were fighting as to what the BFC block offset should be.

The child was always returning true within:
NeedsAbortOnBfcBlockOffsetChange
... as the floats bfc offset was never equal to the child bfc offset,
as the child got affected by clearance.

This fix is to adjust the FloatsBfcBlockOffset by clearance to check
if we need to relayout or not.

Additionally we were performing more layouts than we should be,
when propagating the BFC block offset up the tree upon an abort. We
should be checking if the child got affected by clearance, and if so
adjust the resolved BFC offset accordingly.

Bug: 923271
Change-Id: Id39905a5445a0fe502c16b956b92d6db13885d36
Reviewed-on: https://chromium-review.googlesource.com/c/1423929
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625411}

--

wpt-commits: 66355d4d7ff62616686c39d8b831d2104729993f
wpt-pr: 15003
2019-02-07 21:50:55 +00:00
..
support
adjacent-floats-001-ref.xht
adjacent-floats-001.xht
adjoining-float-before-clearance.html Bug 1462030 [wpt PR 11033] - [LayoutNG] Improve support for negative clearance., a=testonly 2018-05-22 09:40:45 +00:00
adjoining-float-new-fc.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
clear-001-ref.xht
clear-001.xht
clear-002-ref.xht
clear-002.xht
clear-003-ref.xht
clear-003.xht
clear-004.xht
clear-005.xht
clear-after-top-margin.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
clear-applies-to-000-ref.xht
clear-applies-to-000.xht
clear-applies-to-001-ref.xht
clear-applies-to-001.xht
clear-applies-to-002.xht
clear-applies-to-003.xht
clear-applies-to-004.xht
clear-applies-to-005.xht
clear-applies-to-006.xht
clear-applies-to-007.xht
clear-applies-to-008-ref.xht
clear-applies-to-008.xht
clear-applies-to-009-ref.xht
clear-applies-to-009.xht
clear-applies-to-010.xht
clear-applies-to-012.xht
clear-applies-to-013.xht
clear-applies-to-014.xht
clear-applies-to-015.xht
clear-clearance-calculation-001-ref.xht
clear-clearance-calculation-001.xht
clear-clearance-calculation-002-ref.xht
clear-clearance-calculation-002.xht
clear-clearance-calculation-003-ref.xht
clear-clearance-calculation-003.xht
clear-clearance-calculation-004-ref.xht
clear-clearance-calculation-004.xht
clear-clearance-calculation-005-ref.xht
clear-clearance-calculation-005.xht
clear-default-inheritance-001.xht
clear-float-001-ref.xht
clear-float-001.xht
clear-float-002-ref.xht
clear-float-002.xht
clear-float-003-ref.xht
clear-float-003.xht
clear-float-004-ref.xht
clear-float-004.xht
clear-float-005-ref.xht
clear-float-005.xht
clear-float-006-ref.xht
clear-float-006.xht
clear-float-007.xht
clear-float-008.xht
clear-float-009-ref.xht
clear-float-009.xht
clear-initial-001.xht
clear-inline-001-ref.xht
clear-inline-001.xht
clear-on-child-with-margins-2.html Bug 1523562 [wpt PR 15003] - [LayoutNG] Fix crash related to clearance and margin collapsing., a=testonly 2019-02-07 21:50:55 +00:00
clear-on-child-with-margins.html
clear-on-parent-and-child.html
clear-on-parent-with-margins-no-clearance.html Bug 1454635 [wpt PR 10504] - Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html, a=testonly 2018-04-28 19:30:50 +00:00
clear-on-parent-with-margins.html
clear-on-parent.html
clear-with-top-margin-after-cleared-empty-block.html Bug 1462030 [wpt PR 11033] - [LayoutNG] Improve support for negative clearance., a=testonly 2018-05-22 09:40:45 +00:00
clearance-006-ref.xht
clearance-006.xht
float-001.xht
float-002.xht
float-003-ref.xht
float-003.xht
float-004.xht
float-005-ref.xht
float-005.xht
float-006-ref.xht
float-006.xht
float-applies-to-001.xht
float-applies-to-001a.xht
float-applies-to-002.xht
float-applies-to-003.xht
float-applies-to-004.xht
float-applies-to-004a.xht
float-applies-to-005.xht
float-applies-to-006.xht
float-applies-to-007.xht
float-applies-to-008-ref.xht
float-applies-to-008.xht
float-applies-to-008a.xht
float-applies-to-009.xht
float-applies-to-010.xht
float-applies-to-012.xht
float-applies-to-013.xht
float-applies-to-014.xht
float-applies-to-015.xht
float-non-replaced-height-001-ref.xht
float-non-replaced-height-001.xht
float-non-replaced-width-001-ref.xht
float-non-replaced-width-001.xht
float-non-replaced-width-002-ref.xht
float-non-replaced-width-002.xht
float-non-replaced-width-003-ref.xht
float-non-replaced-width-003.xht
float-non-replaced-width-004.xht
float-non-replaced-width-005.xht
float-non-replaced-width-006.xht
float-non-replaced-width-007.xht
float-non-replaced-width-008.xht
float-non-replaced-width-009.xht
float-non-replaced-width-010.xht
float-non-replaced-width-011.xht
float-non-replaced-width-012.xht
float-non-replaced-width-013.xht
float-replaced-height-001-ref.xht
float-replaced-height-001.xht
float-replaced-height-002-ref.xht
float-replaced-height-002.xht
float-replaced-height-003-ref.xht
float-replaced-height-003.xht
float-replaced-height-004-ref.xht
float-replaced-height-004.xht
float-replaced-height-005-ref.xht
float-replaced-height-005.xht
float-replaced-height-006-ref.xht
float-replaced-height-006.xht
float-replaced-height-007.xht
float-replaced-width-001.xht
float-replaced-width-002.xht
float-replaced-width-003.xht
float-replaced-width-004.xht
float-replaced-width-005.xht
float-replaced-width-006-ref.xht
float-replaced-width-006.xht
float-replaced-width-007-ref.xht
float-replaced-width-007.xht
float-replaced-width-008-ref.xht
float-replaced-width-008.xht
float-replaced-width-009-ref.xht
float-replaced-width-009.xht
float-replaced-width-011-ref.xht
float-replaced-width-011.xht
floating-replaced-height-008.xht
floats-001-ref.xht
floats-001.xht
floats-002-ref.xht
floats-002.xht
floats-003.xht
floats-004-ref.xht
floats-004.xht
floats-005-ref.xht
floats-005.xht
floats-006-ref.xht
floats-006.xht
floats-007-ref.xht
floats-007.xht
floats-008.xht
floats-009-ref.xht
floats-009.xht
floats-014-ref.xht
floats-014.xht
floats-015.xht
floats-016.xht
floats-019-ref.xht
floats-019.xht
floats-020.xht
floats-021.xht
floats-022-ref.xht
floats-022.xht
floats-023-ref.xht
floats-023.xht
floats-024-ref.xht
floats-024.xht
floats-025-ref.xht
floats-025.xht
floats-026-ref.xht
floats-026.xht
floats-027-ref.xht
floats-027.xht
floats-028-ref.xht
floats-028.xht
floats-029-ref.xht
floats-029.xht
floats-030-ref.xht
floats-030.xht
floats-031-ref.xht
floats-031.xht
floats-036-ref.xht
floats-036.xht
floats-037.xht
floats-038-ref.xht
floats-038.xht
floats-039.xht
floats-040.xht
floats-041-ref.xht
floats-041.xht
floats-043-ref.xht
floats-043.xht
floats-101-ref.xht
floats-101.xht
floats-102.xht
floats-103.xht
floats-104.xht
floats-105.xht
floats-106.xht
floats-108.xht
floats-109.xht
floats-110.xht
floats-111-ref.xht
floats-111.xht
floats-112-ref.xht
floats-112.xht
floats-113-ref.xht
floats-113.xht
floats-114-ref.xht
floats-114.xht
floats-115-ref.xht
floats-115.xht
floats-116-ref.xht
floats-116.xht
floats-117.xht
floats-118-ref.xht
floats-118.xht
floats-119-ref.xht
floats-119.xht
floats-120.xht
floats-121-ref.xht
floats-121.xht
floats-122-ref.xht
floats-122.xht
floats-123-ref.xht
floats-123.xht
floats-124-ref.xht
floats-124.xht
floats-125-ref.xht
floats-125.xht
floats-126.xht
floats-127.xht
floats-128.xht
floats-129.xht
floats-130.xht
floats-131.xht
floats-132-ref.xht
floats-132.xht
floats-133-ref.xht
floats-133.xht
floats-134.xht
floats-135-ref.xht
floats-135.xht
floats-136-ref.xht
floats-136.xht
floats-137.xht
floats-138-ref.xht
floats-138.xht
floats-139-ref.xht
floats-139.xht
floats-140.xht
floats-141-ref.xht
floats-141.xht
floats-142-ref.xht
floats-142.xht
floats-143-ref.xht Bug 1458286 [wpt PR 10737] - Disable kerning in wpt/css/CSS2/floats-clear/floats-143.xht, a=testonly 2018-05-08 15:51:20 +01:00
floats-143.xht Bug 1458286 [wpt PR 10737] - Disable kerning in wpt/css/CSS2/floats-clear/floats-143.xht, a=testonly 2018-05-08 15:51:20 +01:00
floats-144-ref.xht
floats-144.xht
floats-145-ref.xht
floats-145.xht
floats-146-ref.xht
floats-146.xht
floats-147-ref.xht
floats-147.xht
floats-149-ref.xht
floats-149.xht
floats-150-ref.xht
floats-150.xht
floats-151.xht
floats-152.xht
floats-153-ref.xht
floats-153.xht
floats-154-ref.xht
floats-154.xht
floats-bfc-001-ref.xht
floats-bfc-001.xht
floats-bfc-002.xht
margin-collapse-018.xht
margin-collapse-023.xht
margin-collapse-024-ref.xht
margin-collapse-024.xht
margin-collapse-027.xht
margin-collapse-031-ref.xht
margin-collapse-031.xht
margin-collapse-033.xht
margin-collapse-034.xht
margin-collapse-035.xht
margin-collapse-121-ref.xht
margin-collapse-121.xht
margin-collapse-122.xht
margin-collapse-123-ref.xht
margin-collapse-123.xht
margin-collapse-125-ref.xht
margin-collapse-125.xht
margin-collapse-134-ref.xht
margin-collapse-134.xht
margin-collapse-135-ref.xht
margin-collapse-135.xht
margin-collapse-142-ref.xht
margin-collapse-142.xht
margin-collapse-157-ref.xht
margin-collapse-157.xht
margin-collapse-158-ref.xht
margin-collapse-158.xht
margin-collapse-164.xht
margin-collapse-165-ref.xht
margin-collapse-165.xht
margin-collapse-166.xht
margin-collapse-clear-002-ref.xht
margin-collapse-clear-002.xht
margin-collapse-clear-003-ref.xht
margin-collapse-clear-003.xht
margin-collapse-clear-005.xht
margin-collapse-clear-008.xht
margin-collapse-clear-009.xht
margin-collapse-clear-011.xht
margin-collapse-clear-012-ref.xht
margin-collapse-clear-012.xht
margin-collapse-clear-013.xht
margin-collapse-clear-014-ref.xht
margin-collapse-clear-014.xht
margin-collapse-clear-015-ref.xht
margin-collapse-clear-015.xht
margin-collapse-clear-016-ref.xht
margin-collapse-clear-016.xht
margin-collapse-clear-017-ref.xht
margin-collapse-clear-017.xht
negative-clearance-after-adjoining-float.html Bug 1462030 [wpt PR 11033] - [LayoutNG] Improve support for negative clearance., a=testonly 2018-05-22 09:40:45 +00:00
negative-clearance-after-bottom-margin.html Bug 1462030 [wpt PR 11033] - [LayoutNG] Improve support for negative clearance., a=testonly 2018-05-22 09:40:45 +00:00
nested-clearance-new-formatting-context.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
no-clearance-adjoining-opposite-float.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
no-clearance-due-to-large-margin-after-left-right.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
no-clearance-due-to-large-margin.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
second-float-inside-empty-cleared-block-after-margin.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00
second-float-inside-empty-cleared-block.html Bug 1459954 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly 2018-05-18 11:15:13 +01:00