mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 06:08:24 +02:00
c6aca3f2ad
Automatic update from web-platform-tests [css-grid] Overflow should be computed with the actual logical bottom In order to compute the 'auto' height of the grid container, we set temporarily a value based on the tracks' size. We can see this value as a kind of 'intrinsic height'. Then, we call to the UpdateLogicalHeight function to finally compute the grid container's actual logical height. In order to compute the overflow area in the grid container we should use the result of the ClientLogicalBottom function. However, we were retrieving this value just after setting the tracks-based temporary height, and before computing the actual logical height. The consequence of this wrong logic is that empty grid areas may affect the result of the ClientLogicalBottom and, as it's described in the bug, conclude that there is a content overflow in the grid container, even if such container has no grid items at all. Since the grid itself is not a box, it can't contribute to the grid container's content size; instead, its grid items should. This change ensures that we always use the actual grid container's logical bottom to properly compute the overflow area. Bug: 928885 Change-Id: I05f86fbce06a83c0dbc0d5389bf0416763f8588a Reviewed-on: https://chromium-review.googlesource.com/c/1459620 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#630735} -- wpt-commits: aa6f52fc7b99559377c760a550e842438efa91a1 wpt-pr: 15284
22 lines
985 B
HTML
22 lines
985 B
HTML
<!DOCTYPE html>
|
|
<meta charset="utf-8">
|
|
<title>CSS Grid Layout Test: Grid areas 'overflowing' the grid container size</title>
|
|
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com">
|
|
<link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
|
|
<link rel="help" href="https://drafts.csswg.org/css-overflow-3/#propdef-overflow">
|
|
<link rel="match" href="reference/100x100-grey-box.html">
|
|
<meta name="assert" content="This test verifies that the scrollbars are not shown on a grid with an item placed inside the boundaries of the grid container, even if there are grid areas which exceed the grid container size.">
|
|
<link href="support/grid.css" rel="stylesheet">
|
|
<style>
|
|
.grid {
|
|
grid: 200px / 200px;
|
|
width: 100px;
|
|
height: 100px;
|
|
}
|
|
.item {
|
|
width: 100px;
|
|
height: 100px;
|
|
}
|
|
</style>
|
|
<p>The test passes if you see a grey square below without any scrollbar.</p>
|
|
<div class="grid"><div class="item"></div></div>
|