mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 21:58:41 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
106 lines
3.3 KiB
JavaScript
106 lines
3.3 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
"use strict";
|
|
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
ChromeUtils.defineModuleGetter(this, "LogManager", "resource://normandy/lib/LogManager.jsm");
|
|
|
|
var EXPORTED_SYMBOLS = ["PrefUtils"];
|
|
|
|
XPCOMUtils.defineLazyGetter(this, "log", () => {
|
|
return LogManager.getLogger("preference-experiments");
|
|
});
|
|
|
|
const kPrefBranches = {
|
|
user: Services.prefs,
|
|
default: Services.prefs.getDefaultBranch(""),
|
|
};
|
|
|
|
var PrefUtils = {
|
|
/**
|
|
* Get a preference from the named branch
|
|
* @param {string} branchName One of "default" or "user"
|
|
* @param {string} pref
|
|
* @param {string|boolean|integer|null} [default]
|
|
* The value to return if the preference does not exist. Defaults to null.
|
|
*/
|
|
getPref(branchName, pref, defaultValue = null) {
|
|
const branch = kPrefBranches[branchName];
|
|
const type = branch.getPrefType(pref);
|
|
|
|
try {
|
|
switch (type) {
|
|
case Services.prefs.PREF_BOOL: {
|
|
return branch.getBoolPref(pref);
|
|
}
|
|
case Services.prefs.PREF_STRING: {
|
|
return branch.getStringPref(pref);
|
|
}
|
|
case Services.prefs.PREF_INT: {
|
|
return branch.getIntPref(pref);
|
|
}
|
|
case Services.prefs.PREF_INVALID: {
|
|
return defaultValue;
|
|
}
|
|
}
|
|
} catch (e) {
|
|
if (branchName === "default" && e.result === Cr.NS_ERROR_UNEXPECTED) {
|
|
// There is a value for the pref on the user branch but not on the default branch. This is ok.
|
|
return defaultValue;
|
|
}
|
|
// Unexpected error, re-throw it
|
|
throw e;
|
|
}
|
|
|
|
// If `type` isn't any of the above, throw an error. Don't do this in a
|
|
// default branch of switch so that error handling is easier.
|
|
throw new TypeError(`Unknown preference type (${type}) for ${pref}.`);
|
|
},
|
|
|
|
/**
|
|
* Set a preference on the named branch
|
|
* @param {string} branchName One of "default" or "user"
|
|
* @param {string} pref
|
|
* @param {string|boolean|integer|null} value
|
|
* The value to set. Must match the type named in `type`.
|
|
*/
|
|
setPref(branchName, pref, value) {
|
|
if (value === null) {
|
|
this.clearPref(branchName, pref);
|
|
return;
|
|
}
|
|
const branch = kPrefBranches[branchName];
|
|
switch (typeof value) {
|
|
case "boolean": {
|
|
branch.setBoolPref(pref, value);
|
|
break;
|
|
}
|
|
case "string": {
|
|
branch.setStringPref(pref, value);
|
|
break;
|
|
}
|
|
case "number": {
|
|
branch.setIntPref(pref, value);
|
|
break;
|
|
}
|
|
default: {
|
|
throw new TypeError(`Unexpected value type (${typeof value}) for ${pref}.`);
|
|
}
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Remove a preference from a branch.
|
|
* @param {string} branchName One of "default" or "user"
|
|
* @param {string} pref
|
|
*/
|
|
clearPref(branchName, pref) {
|
|
if (branchName === "user") {
|
|
kPrefBranches.user.clearUserPref(pref);
|
|
} else if (branchName === "default") {
|
|
log.warn(`Cannot not reset pref ${pref} on the default branch. Pref will be cleared at next restart.`);
|
|
}
|
|
},
|
|
};
|