mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 13:48:23 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
138 lines
3.5 KiB
JavaScript
138 lines
3.5 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
const {OS} = ChromeUtils.import("resource://gre/modules/osfile.jsm");
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
var Path = OS.Path;
|
|
var profileDir;
|
|
|
|
registerCleanupFunction(function() {
|
|
Services.prefs.setBoolPref("toolkit.osfile.log", false);
|
|
});
|
|
|
|
/**
|
|
* Test OS.File.makeDir
|
|
*/
|
|
|
|
add_task(function init() {
|
|
// Set up profile. We create the directory in the profile, because the profile
|
|
// is removed after every test run.
|
|
do_get_profile();
|
|
profileDir = OS.Constants.Path.profileDir;
|
|
Services.prefs.setBoolPref("toolkit.osfile.log", true);
|
|
});
|
|
|
|
/**
|
|
* Basic use
|
|
*/
|
|
|
|
add_task(async function test_basic() {
|
|
let dir = Path.join(profileDir, "directory");
|
|
|
|
// Sanity checking for the test
|
|
Assert.equal(false, (await OS.File.exists(dir)));
|
|
|
|
// Make a directory
|
|
await OS.File.makeDir(dir);
|
|
|
|
// check if the directory exists
|
|
await OS.File.stat(dir);
|
|
|
|
// Make a directory that already exists, this should succeed
|
|
await OS.File.makeDir(dir);
|
|
|
|
// Make a directory with ignoreExisting
|
|
await OS.File.makeDir(dir, {ignoreExisting: true});
|
|
|
|
// Make a directory with ignoreExisting false
|
|
let exception = null;
|
|
try {
|
|
await OS.File.makeDir(dir, {ignoreExisting: false});
|
|
} catch (ex) {
|
|
exception = ex;
|
|
}
|
|
|
|
Assert.ok(!!exception);
|
|
Assert.ok(exception instanceof OS.File.Error);
|
|
Assert.ok(exception.becauseExists);
|
|
});
|
|
|
|
// Make a root directory that already exists
|
|
add_task(async function test_root() {
|
|
if (OS.Constants.Win) {
|
|
await OS.File.makeDir("C:");
|
|
await OS.File.makeDir("C:\\");
|
|
} else {
|
|
await OS.File.makeDir("/");
|
|
}
|
|
});
|
|
|
|
/**
|
|
* Creating subdirectories
|
|
*/
|
|
add_task(async function test_option_from() {
|
|
let dir = Path.join(profileDir, "a", "b", "c");
|
|
|
|
// Sanity checking for the test
|
|
Assert.equal(false, (await OS.File.exists(dir)));
|
|
|
|
// Make a directory
|
|
await OS.File.makeDir(dir, {from: profileDir});
|
|
|
|
// check if the directory exists
|
|
await OS.File.stat(dir);
|
|
|
|
// Make a directory that already exists, this should succeed
|
|
await OS.File.makeDir(dir);
|
|
|
|
// Make a directory with ignoreExisting
|
|
await OS.File.makeDir(dir, {ignoreExisting: true});
|
|
|
|
// Make a directory with ignoreExisting false
|
|
let exception = null;
|
|
try {
|
|
await OS.File.makeDir(dir, {ignoreExisting: false});
|
|
} catch (ex) {
|
|
exception = ex;
|
|
}
|
|
|
|
Assert.ok(!!exception);
|
|
Assert.ok(exception instanceof OS.File.Error);
|
|
Assert.ok(exception.becauseExists);
|
|
|
|
// Make a directory without |from| and fail
|
|
let dir2 = Path.join(profileDir, "g", "h", "i");
|
|
exception = null;
|
|
try {
|
|
await OS.File.makeDir(dir2);
|
|
} catch (ex) {
|
|
exception = ex;
|
|
}
|
|
|
|
Assert.ok(!!exception);
|
|
Assert.ok(exception instanceof OS.File.Error);
|
|
Assert.ok(exception.becauseNoSuchFile);
|
|
|
|
// Test edge cases on paths
|
|
|
|
let dir3 = Path.join(profileDir, "d", "", "e", "f");
|
|
Assert.equal(false, (await OS.File.exists(dir3)));
|
|
await OS.File.makeDir(dir3, {from: profileDir});
|
|
Assert.ok((await OS.File.exists(dir3)));
|
|
|
|
let dir4;
|
|
if (OS.Constants.Win) {
|
|
// Test that we can create a directory recursively even
|
|
// if we have too many "\\".
|
|
dir4 = profileDir + "\\\\g";
|
|
} else {
|
|
dir4 = profileDir + "////g";
|
|
}
|
|
Assert.equal(false, (await OS.File.exists(dir4)));
|
|
await OS.File.makeDir(dir4, {from: profileDir});
|
|
Assert.ok((await OS.File.exists(dir4)));
|
|
});
|