mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 14:20:14 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
66 lines
2.6 KiB
JavaScript
66 lines
2.6 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
http://creativecommons.org/publicdomain/zero/1.0/
|
|
*/
|
|
/* Test inclusion of previous build ID in telemetry pings when build ID changes.
|
|
* bug 841028
|
|
*
|
|
* Cases to cover:
|
|
* 1) Run with no "previousBuildID" stored in prefs:
|
|
* -> no previousBuildID in telemetry system info, new value set in prefs.
|
|
* 2) previousBuildID in prefs, equal to current build ID:
|
|
* -> no previousBuildID in telemetry, prefs not updated.
|
|
* 3) previousBuildID in prefs, not equal to current build ID:
|
|
* -> previousBuildID in telemetry, new value set in prefs.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
ChromeUtils.import("resource://gre/modules/Services.jsm", this);
|
|
ChromeUtils.import("resource://gre/modules/TelemetryController.jsm", this);
|
|
ChromeUtils.import("resource://gre/modules/TelemetrySession.jsm", this);
|
|
|
|
// Set up our dummy AppInfo object so we can control the appBuildID.
|
|
ChromeUtils.import("resource://testing-common/AppInfo.jsm", this);
|
|
updateAppInfo();
|
|
|
|
// Check that when run with no previous build ID stored, we update the pref but do not
|
|
// put anything into the metadata.
|
|
add_task(async function test_firstRun() {
|
|
await TelemetryController.testReset();
|
|
let metadata = TelemetrySession.getMetadata();
|
|
Assert.equal(false, "previousBuildID" in metadata);
|
|
let appBuildID = getAppInfo().appBuildID;
|
|
let buildIDPref = Services.prefs.getCharPref(TelemetryUtils.Preferences.PreviousBuildID);
|
|
Assert.equal(appBuildID, buildIDPref);
|
|
});
|
|
|
|
// Check that a subsequent run with the same build ID does not put prev build ID in
|
|
// metadata. Assumes testFirstRun() has already been called to set the previousBuildID pref.
|
|
add_task(async function test_secondRun() {
|
|
await TelemetryController.testReset();
|
|
let metadata = TelemetrySession.getMetadata();
|
|
Assert.equal(false, "previousBuildID" in metadata);
|
|
});
|
|
|
|
// Set up telemetry with a different app build ID and check that the old build ID
|
|
// is returned in the metadata and the pref is updated to the new build ID.
|
|
// Assumes testFirstRun() has been called to set the previousBuildID pref.
|
|
const NEW_BUILD_ID = "20130314";
|
|
add_task(async function test_newBuild() {
|
|
let info = getAppInfo();
|
|
let oldBuildID = info.appBuildID;
|
|
info.appBuildID = NEW_BUILD_ID;
|
|
await TelemetryController.testReset();
|
|
let metadata = TelemetrySession.getMetadata();
|
|
Assert.equal(metadata.previousBuildId, oldBuildID);
|
|
let buildIDPref = Services.prefs.getCharPref(TelemetryUtils.Preferences.PreviousBuildID);
|
|
Assert.equal(NEW_BUILD_ID, buildIDPref);
|
|
});
|
|
|
|
|
|
function run_test() {
|
|
// Make sure we have a profile directory.
|
|
do_get_profile();
|
|
|
|
run_next_test();
|
|
}
|