mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 13:48:23 +02:00
We don't need an additional array just for byte reordering, replace it with in-place processing. Testcase are modified because the LookupCacheV4::Build API now clears the input parameter. Differential Revision: https://phabricator.services.mozilla.com/D26861 --HG-- extra : moz-landing-system : lando
551 lines
15 KiB
C++
551 lines
15 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include <mozilla/RefPtr.h>
|
|
#include "nsString.h"
|
|
#include "nsTArray.h"
|
|
#include "nsClassHashtable.h"
|
|
#include "VariableLengthPrefixSet.h"
|
|
#include "nsAppDirectoryServiceDefs.h"
|
|
#include "nsIFile.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace mozilla::safebrowsing;
|
|
|
|
// Create fullhash by appending random characters.
|
|
static nsCString CreateFullHash(const nsACString& in) {
|
|
nsCString out(in);
|
|
out.SetLength(32);
|
|
for (size_t i = in.Length(); i < 32; i++) {
|
|
out.SetCharAt(char(rand() % 256), i);
|
|
}
|
|
|
|
return out;
|
|
}
|
|
|
|
// This function generate N prefixes with size between MIN and MAX.
|
|
// The output array will not be cleared, random result will append to it
|
|
static void RandomPrefixes(uint32_t N, uint32_t MIN, uint32_t MAX,
|
|
_PrefixArray& array) {
|
|
array.SetCapacity(array.Length() + N);
|
|
|
|
uint32_t range = (MAX - MIN + 1);
|
|
|
|
for (uint32_t i = 0; i < N; i++) {
|
|
uint32_t prefixSize = (rand() % range) + MIN;
|
|
_Prefix prefix;
|
|
prefix.SetLength(prefixSize);
|
|
|
|
bool added = false;
|
|
while (!added) {
|
|
char* dst = prefix.BeginWriting();
|
|
for (uint32_t j = 0; j < prefixSize; j++) {
|
|
dst[j] = rand() % 256;
|
|
}
|
|
|
|
if (!array.Contains(prefix)) {
|
|
array.AppendElement(prefix);
|
|
added = true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// This test loops through all the prefixes and converts each prefix to
|
|
// fullhash by appending random characters, each converted fullhash
|
|
// should at least match its original length in the prefixSet.
|
|
static void DoExpectedLookup(LookupCacheV4* cache, _PrefixArray& array) {
|
|
uint32_t matchLength = 0;
|
|
for (uint32_t i = 0; i < array.Length(); i++) {
|
|
const nsCString& prefix = array[i];
|
|
Completion complete;
|
|
complete.Assign(CreateFullHash(prefix));
|
|
|
|
// Find match for prefix-generated full hash
|
|
bool has, confirmed;
|
|
cache->Has(complete, &has, &matchLength, &confirmed);
|
|
MOZ_ASSERT(matchLength != 0);
|
|
|
|
if (matchLength != prefix.Length()) {
|
|
// Return match size is not the same as prefix size.
|
|
// In this case it could be because the generated fullhash match other
|
|
// prefixes, check if this prefix exist.
|
|
bool found = false;
|
|
|
|
for (uint32_t j = 0; j < array.Length(); j++) {
|
|
if (array[j].Length() != matchLength) {
|
|
continue;
|
|
}
|
|
|
|
if (0 == memcmp(complete.buf, array[j].BeginReading(), matchLength)) {
|
|
found = true;
|
|
break;
|
|
}
|
|
}
|
|
ASSERT_TRUE(found);
|
|
}
|
|
}
|
|
}
|
|
|
|
static void DoRandomLookup(LookupCacheV4* cache, uint32_t N,
|
|
_PrefixArray& array) {
|
|
for (uint32_t i = 0; i < N; i++) {
|
|
// Random 32-bytes test fullhash
|
|
char buf[32];
|
|
for (uint32_t j = 0; j < 32; j++) {
|
|
buf[j] = (char)(rand() % 256);
|
|
}
|
|
|
|
// Get the expected result.
|
|
nsTArray<uint32_t> expected;
|
|
for (uint32_t j = 0; j < array.Length(); j++) {
|
|
const nsACString& str = array[j];
|
|
if (0 == memcmp(buf, str.BeginReading(), str.Length())) {
|
|
expected.AppendElement(str.Length());
|
|
}
|
|
}
|
|
|
|
Completion complete;
|
|
complete.Assign(nsDependentCSubstring(buf, 32));
|
|
bool has, confirmed;
|
|
uint32_t matchLength = 0;
|
|
cache->Has(complete, &has, &matchLength, &confirmed);
|
|
|
|
ASSERT_TRUE(expected.IsEmpty() ? !matchLength
|
|
: expected.Contains(matchLength));
|
|
}
|
|
}
|
|
|
|
static already_AddRefed<LookupCacheV4> SetupLookupCache(
|
|
const nsACString& aName) {
|
|
nsCOMPtr<nsIFile> rootDir;
|
|
NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(rootDir));
|
|
|
|
nsAutoCString provider("test");
|
|
RefPtr<LookupCacheV4> lookup = new LookupCacheV4(aName, provider, rootDir);
|
|
lookup->Init();
|
|
|
|
return lookup.forget();
|
|
}
|
|
|
|
// Test setting prefix set with only 4-bytes prefixes
|
|
TEST(UrlClassifierVLPrefixSet, FixedLengthSet)
|
|
{
|
|
srand(time(nullptr));
|
|
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
PrefixStringMap map;
|
|
_PrefixArray array = {
|
|
_Prefix("alph"), _Prefix("brav"), _Prefix("char"),
|
|
_Prefix("delt"), _Prefix("echo"), _Prefix("foxt"),
|
|
};
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
|
|
// Run random test
|
|
array.Clear();
|
|
map.Clear();
|
|
|
|
RandomPrefixes(1500, 4, 4, array);
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
}
|
|
|
|
// Test setting prefix set with only 5~32 bytes prefixes
|
|
TEST(UrlClassifierVLPrefixSet, VariableLengthSet)
|
|
{
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
PrefixStringMap map;
|
|
_PrefixArray array = {
|
|
_Prefix("bravo"), _Prefix("charlie"),
|
|
_Prefix("delta"), _Prefix("EchoEchoEchoEchoEcho"),
|
|
_Prefix("foxtrot"), _Prefix("GolfGolfGolfGolfGolfGolfGolfGolf"),
|
|
_Prefix("hotel"), _Prefix("november"),
|
|
_Prefix("oscar"), _Prefix("quebec"),
|
|
_Prefix("romeo"), _Prefix("sierrasierrasierrasierrasierra"),
|
|
_Prefix("Tango"), _Prefix("whiskey"),
|
|
_Prefix("yankee"), _Prefix("ZuluZuluZuluZulu")};
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
|
|
// Run random test
|
|
array.Clear();
|
|
map.Clear();
|
|
|
|
RandomPrefixes(1500, 5, 32, array);
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
}
|
|
|
|
// Test setting prefix set with both 4-bytes prefixes and 5~32 bytes prefixes
|
|
TEST(UrlClassifierVLPrefixSet, MixedPrefixSet)
|
|
{
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
PrefixStringMap map;
|
|
_PrefixArray array = {_Prefix("enus"),
|
|
_Prefix("apollo"),
|
|
_Prefix("mars"),
|
|
_Prefix("Hecatonchires cyclopes"),
|
|
_Prefix("vesta"),
|
|
_Prefix("neptunus"),
|
|
_Prefix("jupiter"),
|
|
_Prefix("diana"),
|
|
_Prefix("minerva"),
|
|
_Prefix("ceres"),
|
|
_Prefix("Aidos,Adephagia,Adikia,Aletheia"),
|
|
_Prefix("hecatonchires"),
|
|
_Prefix("alcyoneus"),
|
|
_Prefix("hades"),
|
|
_Prefix("vulcanus"),
|
|
_Prefix("juno"),
|
|
_Prefix("mercury"),
|
|
_Prefix("Stheno, Euryale and Medusa")};
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
|
|
// Run random test
|
|
array.Clear();
|
|
map.Clear();
|
|
|
|
RandomPrefixes(1500, 4, 32, array);
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
}
|
|
|
|
// Test resetting prefix set
|
|
TEST(UrlClassifierVLPrefixSet, ResetPrefix)
|
|
{
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
// First prefix set
|
|
_PrefixArray array1 = {
|
|
_Prefix("Iceland"), _Prefix("Peru"), _Prefix("Mexico"),
|
|
_Prefix("Australia"), _Prefix("Japan"), _Prefix("Egypt"),
|
|
_Prefix("America"), _Prefix("Finland"), _Prefix("Germany"),
|
|
_Prefix("Italy"), _Prefix("France"), _Prefix("Taiwan"),
|
|
};
|
|
{
|
|
PrefixStringMap map;
|
|
|
|
SetupPrefixMap(array1, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array1);
|
|
}
|
|
|
|
// Second
|
|
_PrefixArray array2 = {
|
|
_Prefix("Pikachu"), _Prefix("Bulbasaur"), _Prefix("Charmander"),
|
|
_Prefix("Blastoise"), _Prefix("Pidgey"), _Prefix("Mewtwo"),
|
|
_Prefix("Jigglypuff"), _Prefix("Persian"), _Prefix("Tentacool"),
|
|
_Prefix("Onix"), _Prefix("Eevee"), _Prefix("Jynx"),
|
|
};
|
|
{
|
|
PrefixStringMap map;
|
|
|
|
SetupPrefixMap(array2, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array2);
|
|
}
|
|
|
|
// Should not match any of the first prefix set
|
|
uint32_t matchLength = 0;
|
|
for (uint32_t i = 0; i < array1.Length(); i++) {
|
|
Completion complete;
|
|
complete.Assign(CreateFullHash(array1[i]));
|
|
|
|
// Find match for prefix-generated full hash
|
|
bool has, confirmed;
|
|
cache->Has(complete, &has, &matchLength, &confirmed);
|
|
|
|
ASSERT_TRUE(matchLength == 0);
|
|
}
|
|
}
|
|
|
|
// Test only set one 4-bytes prefix and one full-length prefix
|
|
TEST(UrlClassifierVLPrefixSet, TinyPrefixSet)
|
|
{
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
PrefixStringMap map;
|
|
_PrefixArray array = {
|
|
_Prefix("AAAA"),
|
|
_Prefix("11112222333344445555666677778888"),
|
|
};
|
|
|
|
SetupPrefixMap(array, map);
|
|
cache->Build(map);
|
|
|
|
DoExpectedLookup(cache, array);
|
|
DoRandomLookup(cache, 1000, array);
|
|
CheckContent(cache, array);
|
|
}
|
|
|
|
// Test empty prefix set and IsEmpty function
|
|
TEST(UrlClassifierVLPrefixSet, EmptyPrefixSet)
|
|
{
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
bool empty = cache->IsEmpty();
|
|
ASSERT_TRUE(empty);
|
|
|
|
PrefixStringMap map;
|
|
_PrefixArray array1;
|
|
|
|
// Lookup an empty array should never match
|
|
DoRandomLookup(cache, 100, array1);
|
|
|
|
// Insert an 4-bytes prefix, then IsEmpty should return false
|
|
_PrefixArray array2 = {_Prefix("test")};
|
|
SetupPrefixMap(array2, map);
|
|
cache->Build(map);
|
|
|
|
empty = cache->IsEmpty();
|
|
ASSERT_TRUE(!empty);
|
|
|
|
_PrefixArray array3 = {_Prefix("test variable length")};
|
|
|
|
// Insert an 5~32 bytes prefix, then IsEmpty should return false
|
|
SetupPrefixMap(array3, map);
|
|
cache->Build(map);
|
|
|
|
empty = cache->IsEmpty();
|
|
ASSERT_TRUE(!empty);
|
|
}
|
|
|
|
// Test prefix size should only between 4~32 bytes
|
|
TEST(UrlClassifierVLPrefixSet, MinMaxPrefixSet)
|
|
{
|
|
RefPtr<LookupCacheV4> cache = SetupLookupCache(NS_LITERAL_CSTRING("test"));
|
|
|
|
PrefixStringMap map;
|
|
{
|
|
_PrefixArray array = {_Prefix("1234"), _Prefix("ABCDEFGHIJKKMNOP"),
|
|
_Prefix("1aaa2bbb3ccc4ddd5eee6fff7ggg8hhh")};
|
|
|
|
SetupPrefixMap(array, map);
|
|
nsresult rv = cache->Build(map);
|
|
ASSERT_TRUE(rv == NS_OK);
|
|
}
|
|
|
|
// Prefix size less than 4-bytes should fail
|
|
{
|
|
_PrefixArray array = {_Prefix("123")};
|
|
|
|
SetupPrefixMap(array, map);
|
|
nsresult rv = cache->Build(map);
|
|
ASSERT_TRUE(NS_FAILED(rv));
|
|
}
|
|
|
|
// Prefix size greater than 32-bytes should fail
|
|
{
|
|
_PrefixArray array = {_Prefix("1aaa2bbb3ccc4ddd5eee6fff7ggg8hhh9")};
|
|
|
|
SetupPrefixMap(array, map);
|
|
nsresult rv = cache->Build(map);
|
|
ASSERT_TRUE(NS_FAILED(rv));
|
|
}
|
|
}
|
|
|
|
// Test save then load prefix set with only 4-bytes prefixes
|
|
TEST(UrlClassifierVLPrefixSet, LoadSaveFixedLengthPrefixSet)
|
|
{
|
|
nsCOMPtr<nsIFile> file;
|
|
_PrefixArray array;
|
|
PrefixStringMap map;
|
|
|
|
// Save
|
|
{
|
|
RefPtr<LookupCacheV4> save =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-save"));
|
|
|
|
RandomPrefixes(10000, 4, 4, array);
|
|
|
|
SetupPrefixMap(array, map);
|
|
save->Build(map);
|
|
|
|
DoExpectedLookup(save, array);
|
|
DoRandomLookup(save, 1000, array);
|
|
CheckContent(save, array);
|
|
|
|
NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(file));
|
|
file->Append(NS_LITERAL_STRING("test.vlpset"));
|
|
save->StoreToFile(file);
|
|
}
|
|
|
|
// Load
|
|
{
|
|
RefPtr<LookupCacheV4> load =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-load"));
|
|
load->LoadFromFile(file);
|
|
|
|
DoExpectedLookup(load, array);
|
|
DoRandomLookup(load, 1000, array);
|
|
CheckContent(load, array);
|
|
}
|
|
|
|
file->Remove(false);
|
|
}
|
|
|
|
// Test save then load prefix set with only 5~32 bytes prefixes
|
|
TEST(UrlClassifierVLPrefixSet, LoadSaveVariableLengthPrefixSet)
|
|
{
|
|
nsCOMPtr<nsIFile> file;
|
|
_PrefixArray array;
|
|
PrefixStringMap map;
|
|
|
|
// Save
|
|
{
|
|
RefPtr<LookupCacheV4> save =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-save"));
|
|
|
|
RandomPrefixes(10000, 5, 32, array);
|
|
|
|
SetupPrefixMap(array, map);
|
|
save->Build(map);
|
|
|
|
DoExpectedLookup(save, array);
|
|
DoRandomLookup(save, 1000, array);
|
|
CheckContent(save, array);
|
|
|
|
NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(file));
|
|
file->Append(NS_LITERAL_STRING("test.vlpset"));
|
|
save->StoreToFile(file);
|
|
}
|
|
|
|
// Load
|
|
{
|
|
RefPtr<LookupCacheV4> load =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-load"));
|
|
load->LoadFromFile(file);
|
|
|
|
DoExpectedLookup(load, array);
|
|
DoRandomLookup(load, 1000, array);
|
|
CheckContent(load, array);
|
|
}
|
|
|
|
file->Remove(false);
|
|
}
|
|
|
|
// Test save then load prefix with both 4 bytes prefixes and 5~32 bytes prefixes
|
|
TEST(UrlClassifierVLPrefixSet, LoadSavePrefixSet)
|
|
{
|
|
nsCOMPtr<nsIFile> file;
|
|
_PrefixArray array;
|
|
PrefixStringMap map;
|
|
|
|
// Save
|
|
{
|
|
RefPtr<LookupCacheV4> save =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-save"));
|
|
|
|
// Try to simulate the real case that most prefixes are 4bytes
|
|
RandomPrefixes(20000, 4, 4, array);
|
|
RandomPrefixes(1000, 5, 32, array);
|
|
|
|
SetupPrefixMap(array, map);
|
|
save->Build(map);
|
|
|
|
DoExpectedLookup(save, array);
|
|
DoRandomLookup(save, 1000, array);
|
|
CheckContent(save, array);
|
|
|
|
NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(file));
|
|
file->Append(NS_LITERAL_STRING("test.vlpset"));
|
|
save->StoreToFile(file);
|
|
}
|
|
|
|
// Load
|
|
{
|
|
RefPtr<LookupCacheV4> load =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-load"));
|
|
load->LoadFromFile(file);
|
|
|
|
DoExpectedLookup(load, array);
|
|
DoRandomLookup(load, 1000, array);
|
|
CheckContent(load, array);
|
|
}
|
|
|
|
file->Remove(false);
|
|
}
|
|
|
|
// This is for fixed-length prefixset
|
|
TEST(UrlClassifierVLPrefixSet, LoadSaveNoDelta)
|
|
{
|
|
nsCOMPtr<nsIFile> file;
|
|
_PrefixArray array;
|
|
PrefixStringMap map;
|
|
|
|
for (uint32_t i = 0; i < 100; i++) {
|
|
// construct a tree without deltas by making the distance
|
|
// between entries larger than 16 bits
|
|
uint32_t v = ((1 << 16) + 1) * i;
|
|
nsCString* ele = array.AppendElement();
|
|
ele->AppendASCII(reinterpret_cast<const char*>(&v), 4);
|
|
}
|
|
|
|
// Save
|
|
{
|
|
RefPtr<LookupCacheV4> save =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-save"));
|
|
|
|
SetupPrefixMap(array, map);
|
|
save->Build(map);
|
|
|
|
DoExpectedLookup(save, array);
|
|
DoRandomLookup(save, 1000, array);
|
|
CheckContent(save, array);
|
|
|
|
NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(file));
|
|
file->Append(NS_LITERAL_STRING("test.vlpset"));
|
|
save->StoreToFile(file);
|
|
}
|
|
|
|
// Load
|
|
{
|
|
RefPtr<LookupCacheV4> load =
|
|
SetupLookupCache(NS_LITERAL_CSTRING("test-load"));
|
|
load->LoadFromFile(file);
|
|
|
|
DoExpectedLookup(load, array);
|
|
DoRandomLookup(load, 1000, array);
|
|
CheckContent(load, array);
|
|
}
|
|
|
|
file->Remove(false);
|
|
}
|