mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-04 10:18:41 +02:00
8a15bb728a
A change in LLVM trunk (that was backed out but will reland later on trunk) unveiled a longstanding issue in the NoPrincipalGetURI matcher, which would make it fail to catch issues under some conditions. Differential Revision: https://phabricator.services.mozilla.com/D152359
27 lines
1.1 KiB
C++
27 lines
1.1 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "NoPrincipalGetURI.h"
|
|
#include "CustomMatchers.h"
|
|
|
|
void NoPrincipalGetURI::registerMatchers(MatchFinder *AstMatcher) {
|
|
|
|
AstMatcher->addMatcher(
|
|
cxxMemberCallExpr(
|
|
allOf(callee(cxxMethodDecl(hasName("GetURI"))),
|
|
anyOf(on(hasType(hasCanonicalType(asString("class nsIPrincipal *")))),
|
|
on(hasType(hasCanonicalType(asString("class nsIPrincipal"))))),
|
|
unless(isInWhiteListForPrincipalGetUri())),
|
|
argumentCountIs(1))
|
|
.bind("id"),
|
|
this);
|
|
}
|
|
|
|
void NoPrincipalGetURI::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedDecl = Result.Nodes.getNodeAs<CXXMemberCallExpr>("id");
|
|
diag(MatchedDecl->getExprLoc(),
|
|
"Principal->GetURI is deprecated and will be removed soon. Please "
|
|
"consider using the new helper functions of nsIPrincipal",
|
|
DiagnosticIDs::Error);
|
|
}
|