mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-05 02:39:10 +02:00
5018b1ee50
Instead of passing potentially-dynamic strings over the IPDL interface, pass an integer which corresponds to one of a fixed set of static strings. (This is basically an enum with more steps -- or with fewer steps, depending on which side of it you're standing on.) This ensures that the set of possible location-strings is fixed, which in turn both ensures that aggregation of telemetry stays relatively simple and guards against accidental leakage of PII thereinto. (Or, alternatively and equivalently, this minimizes the code region that data-review needs to consider once the location string is reported to telemetry.) Note that we do not yet actually report the location-string via telemetry; that's planned to occur in bug 1884221. Differential Revision: https://phabricator.services.mozilla.com/D205169
95 lines
3.6 KiB
C++
95 lines
3.6 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "mozilla/widget/filedialog/WinFileDialogChild.h"
|
|
|
|
#include <combaseapi.h>
|
|
#include <objbase.h>
|
|
#include <shobjidl.h>
|
|
|
|
#include "mozilla/Assertions.h"
|
|
#include "mozilla/ipc/ProtocolUtils.h"
|
|
#include "mozilla/widget/filedialog/WinFileDialogCommands.h"
|
|
#include "nsPrintfCString.h"
|
|
|
|
namespace mozilla::widget::filedialog {
|
|
|
|
/* extern */ mozilla::LazyLogModule sLogFileDialog("FileDialog");
|
|
|
|
WinFileDialogChild::WinFileDialogChild() {
|
|
MOZ_LOG(sLogFileDialog, LogLevel::Info, ("%s %p", __PRETTY_FUNCTION__, this));
|
|
};
|
|
|
|
WinFileDialogChild::~WinFileDialogChild() {
|
|
MOZ_LOG(sLogFileDialog, LogLevel::Info, ("%s %p", __PRETTY_FUNCTION__, this));
|
|
};
|
|
|
|
#define MOZ_ABORT_IF_ALREADY_USED() \
|
|
do { \
|
|
MOZ_RELEASE_ASSERT( \
|
|
!mUsed, "called Show* twice on a single WinFileDialog instance"); \
|
|
MOZ_LOG( \
|
|
sLogFileDialog, LogLevel::Info, \
|
|
("%s %p: first call to a Show* function", __PRETTY_FUNCTION__, this)); \
|
|
mUsed = true; \
|
|
} while (0)
|
|
|
|
template <size_t N>
|
|
WinFileDialogChild::IPCResult WinFileDialogChild::MakeIpcFailure(
|
|
HRESULT hr, const char (&what)[N]) {
|
|
CrashReporter::RecordAnnotationU32(
|
|
CrashReporter::Annotation::WindowsFileDialogErrorCode, hr);
|
|
|
|
return IPC_FAIL(this, what);
|
|
}
|
|
|
|
WinFileDialogChild::IPCResult WinFileDialogChild::RecvShowFileDialog(
|
|
uintptr_t parentHwnd, FileDialogType type, nsTArray<Command> commands,
|
|
FileResolver&& resolver) {
|
|
MOZ_ABORT_IF_ALREADY_USED();
|
|
|
|
auto promise = SpawnFilePicker(HWND(parentHwnd), type, std::move(commands));
|
|
using RRV = std::decay_t<decltype(*promise)>::ResolveOrRejectValue;
|
|
|
|
promise->Then(GetMainThreadSerialEventTarget(), __PRETTY_FUNCTION__,
|
|
[resolver = std::move(resolver)](RRV&& val) -> void {
|
|
if (val.IsResolve()) {
|
|
resolver(val.ResolveValue());
|
|
} else {
|
|
auto err = val.RejectValue();
|
|
resolver(RemoteError(err.where.Serialize(), err.why));
|
|
}
|
|
});
|
|
|
|
return IPC_OK();
|
|
}
|
|
|
|
WinFileDialogChild::IPCResult WinFileDialogChild::RecvShowFolderDialog(
|
|
uintptr_t parentHwnd, nsTArray<Command> commands,
|
|
FolderResolver&& resolver) {
|
|
MOZ_ABORT_IF_ALREADY_USED();
|
|
|
|
auto promise = SpawnFolderPicker(HWND(parentHwnd), std::move(commands));
|
|
using RRV = std::decay_t<decltype(*promise)>::ResolveOrRejectValue;
|
|
|
|
promise->Then(GetMainThreadSerialEventTarget(), __PRETTY_FUNCTION__,
|
|
[resolver = std::move(resolver)](RRV&& val) -> void {
|
|
if (val.IsResolve()) {
|
|
resolver(val.ResolveValue());
|
|
} else {
|
|
auto err = val.RejectValue();
|
|
resolver(RemoteError(err.where.Serialize(), err.why));
|
|
}
|
|
});
|
|
|
|
return IPC_OK();
|
|
}
|
|
|
|
void WinFileDialogChild::ProcessingError(Result aCode, const char* aReason) {
|
|
detail::LogProcessingError(sLogFileDialog, this, aCode, aReason);
|
|
}
|
|
|
|
} // namespace mozilla::widget::filedialog
|