gecko-dev/servo/components/style/properties/helpers
Emilio Cobos Álvarez c0d75d9d0e Bug 1690836 - Reduce the amount of code generated by UnparsedValues::substitute_variables. r=boris
This reduces the amount of assembly instructions generated by this
function from 18k+ to ~800.

This should make reasoning about its stack space usage sane, and should
fix the ASAN stack overflows, but also we should take this regardless,
because it's saner and makes reading it simpler.

I also think that the writing_mode shenanigans is fixing a bug (I think
before this, we'd pick the first physical value which mapped to any of
the properties, which is wrong), but I haven't bothered looking for a
test-case that fails before my patch. The relevant WPTs
(css/css-logical/animation*) still pass.

Differential Revision: https://phabricator.services.mozilla.com/D105342
2021-02-17 00:21:36 +00:00
..
animated_properties.mako.rs Bug 1690836 - Reduce the amount of code generated by UnparsedValues::substitute_variables. r=boris 2021-02-17 00:21:36 +00:00