gecko-dev/browser/components
Gijs Kruitbosch c9eba88f1f Bug 1920319 - add dedicated keypress handler for new tab buttons, r=tabbrowser-reviewers,dao
Right now, tabbrowser relies on browser-toolbarKeyNav.js for keyboard access to these buttons on macOS.
There's also toolkit handling for space, but not enter, in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/toolkit/content/widgets/button.js#27-34 .
In vertical tabs mode, browser-toolbarKeyNav does not help us as the buttons aren't in the toolbox.
On Nightly, the containers-related code in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/browser/components/tabbrowser/content/tabs.js#1422-1428
adds the buttons to gClickAndHoldListeners, which have their own keypress handling. This happens whenever
containers are enabled. Those are not enabled by default on non-nightly, and so we end up missing a keypress
handler in vertical tabs mode on non-Nightly on macOS.

This is all a big mess and we should probably figure out a better solution. But given this needs beta uplift,
the expedient solution seems to be a dedicated listener and making sure that only 1 listener is invoked.

Differential Revision: https://phabricator.services.mozilla.com/D224094
2024-09-30 13:15:28 +00:00
..
about Bug 1886001, bug 1918175 - Create the profile deletion page and populate with data. r=niklas,mossop,fluent-reviewers,firefox-desktop-core-reviewers 2024-09-23 19:05:06 +00:00
aboutlogins Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 2024-09-25 10:00:41 +00:00
aboutwelcome Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 2024-09-26 17:54:01 +00:00
asrouter Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 2024-09-26 17:54:01 +00:00
attribution
backup Bug 1890427 - Part 11: Avoid regenerating when scheduled backups disabled, and deleting non-existant backup destination folder. r=backup-reviewers,kpatenio 2024-09-18 13:32:12 +00:00
build
contentanalysis Bug 1912384 part 2 - don't show dialog for cached DLP results r=dlp-reviewers,handyman 2024-08-22 13:15:36 +00:00
contextualidentity Bug 1894633: Use nsIFaviconService::setFaviconForPage() for tests r=places-reviewers,home-newtab-reviewers,thecount,mak 2024-09-30 12:29:36 +00:00
controlcenter/content Bug 1918723 - Remove inline popup handlers from identity-popup. r=Gijs 2024-09-18 08:40:42 +00:00
customizableui Backed out changeset 5808b8ac42ad (bug 1914452) for causing multiple bc failures. CLOSED TREE 2024-09-28 02:36:30 +03:00
doh Bug 1918702 - Migrate telemetry events to use Glean APIs for doh, r=chutten. 2024-09-20 13:58:19 +00:00
downloads Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya 2024-09-19 02:52:04 +00:00
enterprisepolicies Backed out changeset df62d23969f8 (bug 1919344) for causing bc failures @ browser_policies_basic_tests.js CLOSED TREE 2024-09-26 20:39:50 +03:00
extensions Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 2024-09-25 05:08:37 +00:00
firefoxview Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman. 2024-09-20 13:58:15 +00:00
genai Bug 1909986 - For sidebar revamp, only show chatbot entrypoints (context menu, shortcuts) when tools include aichat r=tarek 2024-09-28 01:53:48 +00:00
installerprefs
messagepreview
migration Bug 1918702 - Migrate telemetry events to use Glean APIs for browser.migration, r=chutten,migration-reviewers,mconley. 2024-09-20 13:58:17 +00:00
newtab Bug 1913282: Use nsIFaviconService::setFaviconForPage() for favicon feed r=home-newtab-reviewers,mak,nbarrett 2024-09-30 00:50:44 +00:00
originattributes Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya 2024-09-19 02:52:04 +00:00
pagedata Bug 1916766 - Centralise HiddenBrowserManager into HiddenFrame.sys.mjs and make it a singleton. r=mossop 2024-09-11 15:08:36 +00:00
places Bug 1894633: Use nsIFaviconService::setFaviconForPage() for tests r=places-reviewers,home-newtab-reviewers,thecount,mak 2024-09-30 12:29:36 +00:00
pocket Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 2024-09-12 21:08:44 +00:00
preferences Bug 1918702 - Migrate telemetry events to use Glean APIs for relay_integration, r=settings-reviewers,credential-management-reviewers,dimi,Gijs. 2024-09-27 08:44:45 +00:00
privatebrowsing Bug 1918702 - Migrate telemetry events to use Glean APIs for aboutprivatebrowsing, r=chutten. 2024-09-20 13:58:16 +00:00
profiles Bug 1886001, bug 1918175 - Create the profile deletion page and populate with data. r=niklas,mossop,fluent-reviewers,firefox-desktop-core-reviewers 2024-09-23 19:05:06 +00:00
prompts Bug 1916659, r=Gijs 2024-09-18 18:52:20 +00:00
protections Bug 1918702 - Migrate telemetry events to use Glean APIs for security.ui.protections, r=chutten,frontend-codestyle-reviewers. 2024-09-27 11:48:58 +00:00
protocolhandler Bug 1911070 - Two infobars are displayed, r=nalexander 2024-09-09 21:30:14 +00:00
reportbrokensite Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 2024-09-12 21:08:44 +00:00
resistfingerprinting Bug 1918009 - Fix the RFP-spoofed User-Agent header. r=tjr 2024-09-26 20:41:59 +00:00
safebrowsing/content/test
screenshots Bug 1838298 - Part 2: fix color token usage in line with new Stylelint rule r=desktop-theme-reviewers,settings-reviewers,reusable-components-reviewers,home-newtab-reviewers,dao,thecount 2024-09-27 14:58:41 +00:00
search Bug 1775914 - Fix Intermittent browser/components/search/test/browser/browser_426329.js. r=search-reviewers,daleharvey 2024-09-23 07:06:36 +00:00
sessionstore Bug 1868452 - [sessionstore] Fix recently closed tab menu entry key r=sclements,sessionstore-reviewers,Gijs 2024-09-30 11:55:07 +00:00
shell Bug 1634961 - Add option to list/switch to open tabs in gnome shell search provider. r=emilio,stransky 2024-09-25 11:17:43 +00:00
shopping Bug 1919166 - Prevent registering review checker sidebar panel for private windows. r=shopping-reviewers,sidebar-reviewers,kpatenio,nsharpley 2024-09-24 22:00:18 +00:00
sidebar Backed out changeset 5808b8ac42ad (bug 1914452) for causing multiple bc failures. CLOSED TREE 2024-09-28 02:36:30 +03:00
storybook Bug 1911121 - Create a LoginForm Component for Contextual Password Manager. r=fluent-reviewers,desktop-theme-reviewers,bolsson,hjones,issammani,ayeddi,dao,accessibility-frontend-reviewers 2024-09-14 15:27:32 +00:00
syncedtabs
tabbrowser Bug 1920319 - add dedicated keypress handler for new tab buttons, r=tabbrowser-reviewers,dao 2024-09-30 13:15:28 +00:00
tabunloader
tests Bug 1919611 - Fix #ifdef for windows. r=nchevobbe,dshin 2024-09-20 06:51:36 +00:00
textrecognition Bug 1908920 - Ensure that loading.svg respects prefers-reduced-motion. r=nordzilla,desktop-theme-reviewers,sfoster 2024-08-27 09:20:15 +00:00
topsites
touchbar
translations Bug 1921107 - [translations] Split up the download language settings testases in different files. r=nordzilla,translations-reviewers 2024-09-26 20:59:54 +00:00
uitour Bug 1917223 - re-enable many tests on browser/components/[pri*-urlbar]/**/browser.toml. r=aryx,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,urlbar-reviewers,dao,pdahiya 2024-09-18 23:37:52 +00:00
urlbar No bug - SNG-1837 - Stop pre-fetching the urlbar weather suggestion. r=daisuke 2024-09-27 01:59:28 +00:00
.eslintrc.js
BrowserComponents.manifest
BrowserContentHandler.sys.mjs Bug 1642039 - Part 3: make updateInstalledAtStartup and lastUpdateInstalled async r=bytesized,application-update-reviewers,firefox-desktop-core-reviewers ,mossop 2024-09-07 22:33:04 +00:00
BrowserGlue.sys.mjs Bug 1921012 - Remove unreferenced telemetry event security.ui.app_menu, r=chutten,firefox-desktop-core-reviewers . 2024-09-26 20:40:44 +00:00
components.conf
distribution.sys.mjs
metrics.yaml Bug 1918702 - Migrate telemetry events to use Glean APIs in browser/components/BrowserGlue.sys.mjs, r=chutten,firefox-desktop-core-reviewers ,mconley. 2024-09-20 13:58:14 +00:00
moz.build Bug 1913704 - remove pioneer/ion now that it's been retired, r=rhelmer,chutten,firefox-desktop-core-reviewers ,extension-reviewers,desktop-theme-reviewers,emilio,mossop,robwu 2024-09-19 13:32:22 +00:00
nsIBrowserHandler.idl Bug 1642039 - Part 3: make updateInstalledAtStartup and lastUpdateInstalled async r=bytesized,application-update-reviewers,firefox-desktop-core-reviewers ,mossop 2024-09-07 22:33:04 +00:00
StartupRecorder.sys.mjs Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop 2024-09-24 23:45:09 +00:00