mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	hv_netvsc: change GPAD teardown order on older versions
On older versions of Windows, the host ignores messages after
vmbus channel is closed.
Workaround this by doing what Windows does and send the teardown
before close on older versions of NVSP protocol.
Reported-by: Mohammed Gamal <mgamal@redhat.com>
Fixes: 0cf737808a ("hv_netvsc: netvsc_teardown_gpadl() split")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
			
			
This commit is contained in:
		
							parent
							
								
									02400fcee2
								
							
						
					
					
						commit
						0ef58b0a05
					
				
					 1 changed files with 6 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -571,10 +571,15 @@ void netvsc_device_remove(struct hv_device *device)
 | 
			
		|||
	 */
 | 
			
		||||
	netdev_dbg(ndev, "net device safe to remove\n");
 | 
			
		||||
 | 
			
		||||
	/* older versions require that buffer be revoked before close */
 | 
			
		||||
	if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_4)
 | 
			
		||||
		netvsc_teardown_gpadl(device, net_device);
 | 
			
		||||
 | 
			
		||||
	/* Now, we can close the channel safely */
 | 
			
		||||
	vmbus_close(device->channel);
 | 
			
		||||
 | 
			
		||||
	netvsc_teardown_gpadl(device, net_device);
 | 
			
		||||
	if (net_device->nvsp_version >= NVSP_PROTOCOL_VERSION_4)
 | 
			
		||||
		netvsc_teardown_gpadl(device, net_device);
 | 
			
		||||
 | 
			
		||||
	/* Release all resources */
 | 
			
		||||
	free_netvsc_device_rcu(net_device);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue