mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

rtc: pcf85063: replace dev_err+return with return dev_err_probe

Browse source 
Replace the dev_err plus return combo with return dev_err_probe() this
actually communicates the error type when it occurs and helps debugging
hardware issues.

Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
Link: https://lore.kernel.org/r/20250304-rtc_dev_err_probe-v1-1-9dcc042ad17e@gocontroll.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Maud Spierings 2025-03-04 09:14:52 +01:00 committed by Alexandre Belloni
parent 2b7cbd9849
commit 119e90a3a6
1 changed files with 2 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/rtc/rtc-pcf85063.c
View file

@ -591,10 +591,8 @@ static int pcf85063_probe(struct i2c_client *client)
i2c_set_clientdata(client, pcf85063); i2c_set_clientdata(client, pcf85063);
err = regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp); err = regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp);
if (err) { if (err)
dev_err(&client->dev, "RTC chip is not present\n"); return dev_err_probe(&client->dev, err, "RTC chip is not present\n");
return err;
}
pcf85063->rtc = devm_rtc_allocate_device(&client->dev); pcf85063->rtc = devm_rtc_allocate_device(&client->dev);
if (IS_ERR(pcf85063->rtc)) if (IS_ERR(pcf85063->rtc))