mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

net: dsa: felix: keep reference on entire tc-taprio config

Browse source 
In a future change we will need to remember the entire tc-taprio config
on all ports rather than just the base time, so use the
taprio_offload_get() helper function to replace ocelot_port->base_time
with ocelot_port->taprio.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Vladimir Oltean 2022-06-28 17:52:35 +03:00 committed by Jakub Kicinski
parent c7e5c423cb
commit 1c9017e44a
2 changed files with 15 additions and 13 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

23
drivers/net/dsa/ocelot/felix_vsc9959.c
View file

@ -1210,6 +1210,9 @@ static int vsc9959_qos_port_tas_set(struct ocelot *ocelot, int port,
QSYS_TAG_CONFIG_INIT_GATE_STATE_M, QSYS_TAG_CONFIG_INIT_GATE_STATE_M,
QSYS_TAG_CONFIG, port); QSYS_TAG_CONFIG, port);
taprio_offload_free(ocelot_port->taprio);
ocelot_port->taprio = NULL;
mutex_unlock(&ocelot->tas_lock); mutex_unlock(&ocelot->tas_lock);
return 0; return 0;
} }
@ -1258,8 +1261,6 @@ static int vsc9959_qos_port_tas_set(struct ocelot *ocelot, int port,
QSYS_TAG_CONFIG_SCH_TRAFFIC_QUEUES_M, QSYS_TAG_CONFIG_SCH_TRAFFIC_QUEUES_M,
QSYS_TAG_CONFIG, port); QSYS_TAG_CONFIG, port);
ocelot_port->base_time = taprio->base_time;
vsc9959_new_base_time(ocelot, taprio->base_time, vsc9959_new_base_time(ocelot, taprio->base_time,
taprio->cycle_time, &base_ts); taprio->cycle_time, &base_ts);
ocelot_write(ocelot, base_ts.tv_nsec, QSYS_PARAM_CFG_REG_1); ocelot_write(ocelot, base_ts.tv_nsec, QSYS_PARAM_CFG_REG_1);
@ -1282,6 +1283,10 @@ static int vsc9959_qos_port_tas_set(struct ocelot *ocelot, int port,
ret = readx_poll_timeout(vsc9959_tas_read_cfg_status, ocelot, val, ret = readx_poll_timeout(vsc9959_tas_read_cfg_status, ocelot, val,
!(val & QSYS_TAS_PARAM_CFG_CTRL_CONFIG_CHANGE), !(val & QSYS_TAS_PARAM_CFG_CTRL_CONFIG_CHANGE),
10, 100000); 10, 100000);
if (ret)
goto err;
ocelot_port->taprio = taprio_offload_get(taprio);
err: err:
mutex_unlock(&ocelot->tas_lock); mutex_unlock(&ocelot->tas_lock);
@ -1291,17 +1296,18 @@ static int vsc9959_qos_port_tas_set(struct ocelot *ocelot, int port,
static void vsc9959_tas_clock_adjust(struct ocelot *ocelot) static void vsc9959_tas_clock_adjust(struct ocelot *ocelot)
{ {
struct tc_taprio_qopt_offload *taprio;
struct ocelot_port *ocelot_port; struct ocelot_port *ocelot_port;
struct timespec64 base_ts; struct timespec64 base_ts;
u64 cycletime;
int port; int port;
u32 val; u32 val;
mutex_lock(&ocelot->tas_lock); mutex_lock(&ocelot->tas_lock);
for (port = 0; port < ocelot->num_phys_ports; port++) { for (port = 0; port < ocelot->num_phys_ports; port++) {
val = ocelot_read_rix(ocelot, QSYS_TAG_CONFIG, port); ocelot_port = ocelot->ports[port];
if (!(val & QSYS_TAG_CONFIG_ENABLE)) taprio = ocelot_port->taprio;
if (!taprio)
continue; continue;
ocelot_rmw(ocelot, ocelot_rmw(ocelot,
@ -1315,11 +1321,8 @@ static void vsc9959_tas_clock_adjust(struct ocelot *ocelot)
QSYS_TAG_CONFIG_INIT_GATE_STATE_M, QSYS_TAG_CONFIG_INIT_GATE_STATE_M,
QSYS_TAG_CONFIG, port); QSYS_TAG_CONFIG, port);
cycletime = ocelot_read(ocelot, QSYS_PARAM_CFG_REG_4); vsc9959_new_base_time(ocelot, taprio->base_time,
ocelot_port = ocelot->ports[port]; taprio->cycle_time, &base_ts);
vsc9959_new_base_time(ocelot, ocelot_port->base_time,
cycletime, &base_ts);
ocelot_write(ocelot, base_ts.tv_nsec, QSYS_PARAM_CFG_REG_1); ocelot_write(ocelot, base_ts.tv_nsec, QSYS_PARAM_CFG_REG_1);
ocelot_write(ocelot, lower_32_bits(base_ts.tv_sec), ocelot_write(ocelot, lower_32_bits(base_ts.tv_sec),

5
include/soc/mscc/ocelot.h
View file

@ -670,6 +670,8 @@ struct ocelot_port {
/* VLAN that untagged frames are classified to, on ingress */ /* VLAN that untagged frames are classified to, on ingress */
const struct ocelot_bridge_vlan *pvid_vlan; const struct ocelot_bridge_vlan *pvid_vlan;
struct tc_taprio_qopt_offload *taprio;
phy_interface_t phy_mode; phy_interface_t phy_mode;
unsigned int ptp_skbs_in_flight; unsigned int ptp_skbs_in_flight;
@ -692,9 +694,6 @@ struct ocelot_port {
int bridge_num; int bridge_num;
int speed; int speed;
/* Store the AdminBaseTime of EST fetched from userspace. */
s64 base_time;
}; };
struct ocelot { struct ocelot {