mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	net: phy: Use for_each_available_child_of_node_scoped()
Avoid need to manually handle of_node_put() by using for_each_available_child_of_node_scoped(), which can simplfy code. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
		
							parent
							
								
									51c884291a
								
							
						
					
					
						commit
						1dce520abd
					
				
					 1 changed files with 2 additions and 3 deletions
				
			
		| 
						 | 
				
			
			@ -3407,7 +3407,7 @@ static int of_phy_led(struct phy_device *phydev,
 | 
			
		|||
static int of_phy_leds(struct phy_device *phydev)
 | 
			
		||||
{
 | 
			
		||||
	struct device_node *node = phydev->mdio.dev.of_node;
 | 
			
		||||
	struct device_node *leds, *led;
 | 
			
		||||
	struct device_node *leds;
 | 
			
		||||
	int err;
 | 
			
		||||
 | 
			
		||||
	if (!IS_ENABLED(CONFIG_OF_MDIO))
 | 
			
		||||
| 
						 | 
				
			
			@ -3420,10 +3420,9 @@ static int of_phy_leds(struct phy_device *phydev)
 | 
			
		|||
	if (!leds)
 | 
			
		||||
		return 0;
 | 
			
		||||
 | 
			
		||||
	for_each_available_child_of_node(leds, led) {
 | 
			
		||||
	for_each_available_child_of_node_scoped(leds, led) {
 | 
			
		||||
		err = of_phy_led(phydev, led);
 | 
			
		||||
		if (err) {
 | 
			
		||||
			of_node_put(led);
 | 
			
		||||
			phy_leds_unregister(phydev);
 | 
			
		||||
			return err;
 | 
			
		||||
		}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue