mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-06 19:50:24 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

i2c: mux: Use struct_size() in devm_kzalloc()

Browse source 
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Peter Rosin <peda@axentia.se>
This commit is contained in:
Gustavo A. R. Silva 2019-05-29 11:20:14 -05:00 committed by Peter Rosin
parent cd6c84d8f0
commit 1f3b69b6b9
1 changed files with 1 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/i2c/i2c-mux.c
View file

@ -243,8 +243,7 @@ struct i2c_mux_core *i2c_mux_alloc(struct i2c_adapter *parent,
{ {
struct i2c_mux_core *muxc; struct i2c_mux_core *muxc;
muxc = devm_kzalloc(dev, sizeof(*muxc) muxc = devm_kzalloc(dev, struct_size(muxc, adapter, max_adapters)
+ max_adapters * sizeof(muxc->adapter[0])
+ sizeof_priv, GFP_KERNEL); + sizeof_priv, GFP_KERNEL);
if (!muxc) if (!muxc)
return NULL; return NULL;