mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	ACPI,PCI,IRQ: remove redundant code in acpi_irq_penalty_init()
acpi_irq_get_penalty is now calculating the penalty on the fly now. No need to maintain global list of penalties or calculate them at the init time. Removing duplicate code in acpi_irq_penalty_init. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
		
							parent
							
								
									5c5087a553
								
							
						
					
					
						commit
						1fcb6a813c
					
				
					 3 changed files with 0 additions and 38 deletions
				
			
		| 
						 | 
				
			
			@ -396,7 +396,6 @@ int __init pci_acpi_init(void)
 | 
			
		|||
		return -ENODEV;
 | 
			
		||||
 | 
			
		||||
	printk(KERN_INFO "PCI: Using ACPI for IRQ routing\n");
 | 
			
		||||
	acpi_irq_penalty_init();
 | 
			
		||||
	pcibios_enable_irq = acpi_pci_irq_enable;
 | 
			
		||||
	pcibios_disable_irq = acpi_pci_irq_disable;
 | 
			
		||||
	x86_init.pci.init_irq = x86_init_noop;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -520,42 +520,6 @@ static int acpi_irq_get_penalty(int irq)
 | 
			
		|||
	return penalty;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
int __init acpi_irq_penalty_init(void)
 | 
			
		||||
{
 | 
			
		||||
	struct acpi_pci_link *link;
 | 
			
		||||
	int i;
 | 
			
		||||
 | 
			
		||||
	/*
 | 
			
		||||
	 * Update penalties to facilitate IRQ balancing.
 | 
			
		||||
	 */
 | 
			
		||||
	list_for_each_entry(link, &acpi_link_list, list) {
 | 
			
		||||
 | 
			
		||||
		/*
 | 
			
		||||
		 * reflect the possible and active irqs in the penalty table --
 | 
			
		||||
		 * useful for breaking ties.
 | 
			
		||||
		 */
 | 
			
		||||
		if (link->irq.possible_count) {
 | 
			
		||||
			int penalty =
 | 
			
		||||
			    PIRQ_PENALTY_PCI_POSSIBLE /
 | 
			
		||||
			    link->irq.possible_count;
 | 
			
		||||
 | 
			
		||||
			for (i = 0; i < link->irq.possible_count; i++) {
 | 
			
		||||
				if (link->irq.possible[i] < ACPI_MAX_ISA_IRQS)
 | 
			
		||||
					acpi_isa_irq_penalty[link->irq.
 | 
			
		||||
							 possible[i]] +=
 | 
			
		||||
					    penalty;
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
		} else if (link->irq.active &&
 | 
			
		||||
				(link->irq.active < ACPI_MAX_ISA_IRQS)) {
 | 
			
		||||
			acpi_isa_irq_penalty[link->irq.active] +=
 | 
			
		||||
			    PIRQ_PENALTY_PCI_POSSIBLE;
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	return 0;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
static int acpi_irq_balance = -1;	/* 0: static, 1: balance */
 | 
			
		||||
 | 
			
		||||
static int acpi_pci_link_allocate(struct acpi_pci_link *link)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -78,7 +78,6 @@
 | 
			
		|||
 | 
			
		||||
/* ACPI PCI Interrupt Link (pci_link.c) */
 | 
			
		||||
 | 
			
		||||
int acpi_irq_penalty_init(void);
 | 
			
		||||
int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
 | 
			
		||||
			       int *polarity, char **name);
 | 
			
		||||
int acpi_pci_link_free_irq(acpi_handle handle);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue