mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	spi: bcm2835: use devm_spi_register_master()
Use devm_spi_register_master() to make cleanup paths simpler, and remove a duplicate put. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
		
							parent
							
								
									5afd077d70
								
							
						
					
					
						commit
						247263dba2
					
				
					 1 changed files with 1 additions and 3 deletions
				
			
		| 
						 | 
				
			
			@ -358,7 +358,7 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 | 
			
		|||
	bcm2835_wr(bs, BCM2835_SPI_CS,
 | 
			
		||||
		   BCM2835_SPI_CS_CLEAR_RX | BCM2835_SPI_CS_CLEAR_TX);
 | 
			
		||||
 | 
			
		||||
	err = spi_register_master(master);
 | 
			
		||||
	err = devm_spi_register_master(&pdev->dev, master);
 | 
			
		||||
	if (err) {
 | 
			
		||||
		dev_err(&pdev->dev, "could not register SPI master: %d\n", err);
 | 
			
		||||
		goto out_free_irq;
 | 
			
		||||
| 
						 | 
				
			
			@ -381,14 +381,12 @@ static int bcm2835_spi_remove(struct platform_device *pdev)
 | 
			
		|||
	struct bcm2835_spi *bs = spi_master_get_devdata(master);
 | 
			
		||||
 | 
			
		||||
	free_irq(bs->irq, master);
 | 
			
		||||
	spi_unregister_master(master);
 | 
			
		||||
 | 
			
		||||
	/* Clear FIFOs, and disable the HW block */
 | 
			
		||||
	bcm2835_wr(bs, BCM2835_SPI_CS,
 | 
			
		||||
		   BCM2835_SPI_CS_CLEAR_RX | BCM2835_SPI_CS_CLEAR_TX);
 | 
			
		||||
 | 
			
		||||
	clk_disable_unprepare(bs->clk);
 | 
			
		||||
	spi_master_put(master);
 | 
			
		||||
 | 
			
		||||
	return 0;
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue