mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	pwm: Use -EINVAL for unsupported polarity
Instead of using a mix of -EOPNOTSUPP and -ENOTSUPP, use the more standard -EINVAL to signal that the specified polarity value was invalid. Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
		
							parent
							
								
									f14a8f0ef9
								
							
						
					
					
						commit
						2b1c1a5d51
					
				
					 3 changed files with 3 additions and 3 deletions
				
			
		| 
						 | 
				
			
			@ -64,7 +64,7 @@ static int crc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 | 
			
		|||
	}
 | 
			
		||||
 | 
			
		||||
	if (state->polarity != PWM_POLARITY_NORMAL)
 | 
			
		||||
		return -EOPNOTSUPP;
 | 
			
		||||
		return -EINVAL;
 | 
			
		||||
 | 
			
		||||
	if (pwm_is_enabled(pwm) && !state->enabled) {
 | 
			
		||||
		err = regmap_write(crc_pwm->regmap, BACKLIGHT_EN, 0);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -50,7 +50,7 @@ static int iqs620_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 | 
			
		|||
	int ret;
 | 
			
		||||
 | 
			
		||||
	if (state->polarity != PWM_POLARITY_NORMAL)
 | 
			
		||||
		return -ENOTSUPP;
 | 
			
		||||
		return -EINVAL;
 | 
			
		||||
 | 
			
		||||
	if (state->period < IQS620_PWM_PERIOD_NS)
 | 
			
		||||
		return -EINVAL;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -168,7 +168,7 @@ static int rcar_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 | 
			
		|||
 | 
			
		||||
	/* This HW/driver only supports normal polarity */
 | 
			
		||||
	if (state->polarity != PWM_POLARITY_NORMAL)
 | 
			
		||||
		return -ENOTSUPP;
 | 
			
		||||
		return -EINVAL;
 | 
			
		||||
 | 
			
		||||
	if (!state->enabled) {
 | 
			
		||||
		rcar_pwm_disable(rp);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue