mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

RDMA/core: Constify dst_addr argument

Browse source 
Following APIs are not supposed to modify addr or dest_addr contents.
Therefore make those function argument const for better code
readability.

1. rdma_resolve_ip()
2. rdma_addr_size()
3. rdma_resolve_addr()

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Parav Pandit 2018-07-29 11:53:10 +03:00 committed by Jason Gunthorpe
parent 219d2e9dfd
commit 2df7dba855
4 changed files with 12 additions and 12 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/infiniband/core/addr.c
View file

@ -188,7 +188,7 @@ static int ib_nl_ip_send_msg(struct rdma_dev_addr *dev_addr,
return -ENODATA; return -ENODATA;
} }
int rdma_addr_size(struct sockaddr *addr) int rdma_addr_size(const struct sockaddr *addr)
{ {
switch (addr->sa_family) { switch (addr->sa_family) {
case AF_INET: case AF_INET:
@ -585,7 +585,7 @@ static void process_one_req(struct work_struct *_work)
spin_unlock_bh(&lock); spin_unlock_bh(&lock);
} }
int rdma_resolve_ip(struct sockaddr *src_addr, struct sockaddr *dst_addr, int rdma_resolve_ip(struct sockaddr *src_addr, const struct sockaddr *dst_addr,
struct rdma_dev_addr *addr, int timeout_ms, struct rdma_dev_addr *addr, int timeout_ms,
void (*callback)(int status, struct sockaddr *src_addr, void (*callback)(int status, struct sockaddr *src_addr,
struct rdma_dev_addr *addr, void *context), struct rdma_dev_addr *addr, void *context),

14
drivers/infiniband/core/cma.c
View file

@ -1046,7 +1046,7 @@ int rdma_init_qp_attr(struct rdma_cm_id *id, struct ib_qp_attr *qp_attr,
} }
EXPORT_SYMBOL(rdma_init_qp_attr); EXPORT_SYMBOL(rdma_init_qp_attr);
static inline int cma_zero_addr(struct sockaddr *addr) static inline int cma_zero_addr(const struct sockaddr *addr)
{ {
switch (addr->sa_family) { switch (addr->sa_family) {
case AF_INET: case AF_INET:
@ -1060,7 +1060,7 @@ static inline int cma_zero_addr(struct sockaddr *addr)
} }
} }
static inline int cma_loopback_addr(struct sockaddr *addr) static inline int cma_loopback_addr(const struct sockaddr *addr)
{ {
switch (addr->sa_family) { switch (addr->sa_family) {
case AF_INET: case AF_INET:
@ -1074,7 +1074,7 @@ static inline int cma_loopback_addr(struct sockaddr *addr)
} }
} }
static inline int cma_any_addr(struct sockaddr *addr) static inline int cma_any_addr(const struct sockaddr *addr)
{ {
return cma_zero_addr(addr) || cma_loopback_addr(addr); return cma_zero_addr(addr) || cma_loopback_addr(addr);
} }
@ -1097,7 +1097,7 @@ static int cma_addr_cmp(struct sockaddr *src, struct sockaddr *dst)
} }
} }
static __be16 cma_port(struct sockaddr *addr) static __be16 cma_port(const struct sockaddr *addr)
{ {
struct sockaddr_ib *sib; struct sockaddr_ib *sib;
@ -1115,7 +1115,7 @@ static __be16 cma_port(struct sockaddr *addr)
} }
} }
static inline int cma_any_port(struct sockaddr *addr) static inline int cma_any_port(const struct sockaddr *addr)
{ {
return !cma_port(addr); return !cma_port(addr);
} }
@ -2944,7 +2944,7 @@ static int cma_resolve_ib_addr(struct rdma_id_private *id_priv)
} }
static int cma_bind_addr(struct rdma_cm_id *id, struct sockaddr *src_addr, static int cma_bind_addr(struct rdma_cm_id *id, struct sockaddr *src_addr,
struct sockaddr *dst_addr) const struct sockaddr *dst_addr)
{ {
if (!src_addr || !src_addr->sa_family) { if (!src_addr || !src_addr->sa_family) {
src_addr = (struct sockaddr *) &id->route.addr.src_addr; src_addr = (struct sockaddr *) &id->route.addr.src_addr;
@ -2965,7 +2965,7 @@ static int cma_bind_addr(struct rdma_cm_id *id, struct sockaddr *src_addr,
} }
int rdma_resolve_addr(struct rdma_cm_id *id, struct sockaddr *src_addr, int rdma_resolve_addr(struct rdma_cm_id *id, struct sockaddr *src_addr,
struct sockaddr *dst_addr, int timeout_ms) const struct sockaddr *dst_addr, int timeout_ms)
{ {
struct rdma_id_private *id_priv; struct rdma_id_private *id_priv;
int ret; int ret;

4
include/rdma/ib_addr.h
View file

@ -97,7 +97,7 @@ int rdma_translate_ip(const struct sockaddr *addr,
* or been canceled. A status of 0 indicates success. * or been canceled. A status of 0 indicates success.
* @context: User-specified context associated with the call. * @context: User-specified context associated with the call.
*/ */
int rdma_resolve_ip(struct sockaddr *src_addr, struct sockaddr *dst_addr, int rdma_resolve_ip(struct sockaddr *src_addr, const struct sockaddr *dst_addr,
struct rdma_dev_addr *addr, int timeout_ms, struct rdma_dev_addr *addr, int timeout_ms,
void (*callback)(int status, struct sockaddr *src_addr, void (*callback)(int status, struct sockaddr *src_addr,
struct rdma_dev_addr *addr, void *context), struct rdma_dev_addr *addr, void *context),
@ -109,7 +109,7 @@ void rdma_copy_addr(struct rdma_dev_addr *dev_addr,
const struct net_device *dev, const struct net_device *dev,
const unsigned char *dst_dev_addr); const unsigned char *dst_dev_addr);
int rdma_addr_size(struct sockaddr *addr); int rdma_addr_size(const struct sockaddr *addr);
int rdma_addr_size_in6(struct sockaddr_in6 *addr); int rdma_addr_size_in6(struct sockaddr_in6 *addr);
int rdma_addr_size_kss(struct __kernel_sockaddr_storage *addr); int rdma_addr_size_kss(struct __kernel_sockaddr_storage *addr);

2
include/rdma/rdma_cm.h
View file

@ -192,7 +192,7 @@ int rdma_bind_addr(struct rdma_cm_id *id, struct sockaddr *addr);
* @timeout_ms: Time to wait for resolution to complete. * @timeout_ms: Time to wait for resolution to complete.
*/ */
int rdma_resolve_addr(struct rdma_cm_id *id, struct sockaddr *src_addr, int rdma_resolve_addr(struct rdma_cm_id *id, struct sockaddr *src_addr,
struct sockaddr *dst_addr, int timeout_ms); const struct sockaddr *dst_addr, int timeout_ms);
/** /**
* rdma_resolve_route - Resolve the RDMA address bound to the RDMA identifier * rdma_resolve_route - Resolve the RDMA address bound to the RDMA identifier