mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	ovl: don't set the superblock's errseq_t manually
Since commit5679897eb1("vfs: make sync_filesystem return errors from ->sync_fs"), the return value from sync_fs callback can be seen in sync_filesystem(). Thus the errseq_set opreation can be removed here. Depends-on: commit5679897eb1("vfs: make sync_filesystem return errors from ->sync_fs") Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
This commit is contained in:
		
							parent
							
								
									3e9bff3bbe
								
							
						
					
					
						commit
						34b4540e66
					
				
					 1 changed files with 2 additions and 8 deletions
				
			
		| 
						 | 
				
			
			@ -202,15 +202,9 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
 | 
			
		|||
	int ret;
 | 
			
		||||
 | 
			
		||||
	ret = ovl_sync_status(ofs);
 | 
			
		||||
	/*
 | 
			
		||||
	 * We have to always set the err, because the return value isn't
 | 
			
		||||
	 * checked in syncfs, and instead indirectly return an error via
 | 
			
		||||
	 * the sb's writeback errseq, which VFS inspects after this call.
 | 
			
		||||
	 */
 | 
			
		||||
	if (ret < 0) {
 | 
			
		||||
		errseq_set(&sb->s_wb_err, -EIO);
 | 
			
		||||
 | 
			
		||||
	if (ret < 0)
 | 
			
		||||
		return -EIO;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if (!ret)
 | 
			
		||||
		return ret;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue