mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	stop_machine: Provide RCU quiescent state in multi_cpu_stop()
When multi_cpu_stop() loops waiting for other tasks, it can trigger an RCU CPU stall warning. This can be misleading because what is instead needed is information on whatever task is blocking multi_cpu_stop(). This commit therefore inserts an RCU quiescent state into the multi_cpu_stop() function's waitloop. Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
This commit is contained in:
		
							parent
							
								
									d38e6dc6ed
								
							
						
					
					
						commit
						366237e7b0
					
				
					 3 changed files with 3 additions and 1 deletions
				
			
		|  | @ -37,6 +37,7 @@ void kfree_call_rcu(struct rcu_head *head, rcu_callback_t func); | ||||||
| 
 | 
 | ||||||
| void rcu_barrier(void); | void rcu_barrier(void); | ||||||
| bool rcu_eqs_special_set(int cpu); | bool rcu_eqs_special_set(int cpu); | ||||||
|  | void rcu_momentary_dyntick_idle(void); | ||||||
| unsigned long get_state_synchronize_rcu(void); | unsigned long get_state_synchronize_rcu(void); | ||||||
| void cond_synchronize_rcu(unsigned long oldstate); | void cond_synchronize_rcu(unsigned long oldstate); | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -364,7 +364,7 @@ bool rcu_eqs_special_set(int cpu) | ||||||
|  * |  * | ||||||
|  * The caller must have disabled interrupts and must not be idle. |  * The caller must have disabled interrupts and must not be idle. | ||||||
|  */ |  */ | ||||||
| static void __maybe_unused rcu_momentary_dyntick_idle(void) | void rcu_momentary_dyntick_idle(void) | ||||||
| { | { | ||||||
| 	int special; | 	int special; | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -233,6 +233,7 @@ static int multi_cpu_stop(void *data) | ||||||
| 			 */ | 			 */ | ||||||
| 			touch_nmi_watchdog(); | 			touch_nmi_watchdog(); | ||||||
| 		} | 		} | ||||||
|  | 		rcu_momentary_dyntick_idle(); | ||||||
| 	} while (curstate != MULTI_STOP_EXIT); | 	} while (curstate != MULTI_STOP_EXIT); | ||||||
| 
 | 
 | ||||||
| 	local_irq_restore(flags); | 	local_irq_restore(flags); | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue
	
	 Paul E. McKenney
						Paul E. McKenney