mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

NFSD: Fix use-after-free warning when doing inter-server copy

Browse source 
The source file nfsd_file is not constructed the same as other
nfsd_file's via nfsd_file_alloc. nfsd_file_put should not be
called to free the object; nfsd_file_put is not the inverse of
kzalloc, instead kfree is called by nfsd4_do_async_copy when done.

Fixes: ce0887ac96 ("NFSD add nfs4 inter ssc to nfsd4_copy")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Dai Ngo 2020-10-29 15:07:15 -04:00 committed by J. Bruce Fields
parent 66d60e3ad1
commit 36e1e5ba90
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
fs/nfsd/nfs4proc.c
View file

@ -1299,7 +1299,7 @@ nfsd4_cleanup_inter_ssc(struct vfsmount *ss_mnt, struct nfsd_file *src,
struct nfsd_file *dst) struct nfsd_file *dst)
{ {
nfs42_ssc_close(src->nf_file); nfs42_ssc_close(src->nf_file);
nfsd_file_put(src); /* 'src' is freed by nfsd4_do_async_copy */
nfsd_file_put(dst); nfsd_file_put(dst);
mntput(ss_mnt); mntput(ss_mnt);
} }