mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	net: unix: allow bind to fail on mutex lock
This is similar to the set_peek_off patch where calling bind while the socket is stuck in unix_dgram_recvmsg() will block and cause a hung task spew after a while. This is also the last place that did a straightforward mutex_lock(), so there shouldn't be any more of these patches. Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
		
							parent
							
								
									d1fc502476
								
							
						
					
					
						commit
						37ab4fa784
					
				
					 1 changed files with 6 additions and 2 deletions
				
			
		| 
						 | 
				
			
			@ -718,7 +718,9 @@ static int unix_autobind(struct socket *sock)
 | 
			
		|||
	int err;
 | 
			
		||||
	unsigned int retries = 0;
 | 
			
		||||
 | 
			
		||||
	mutex_lock(&u->readlock);
 | 
			
		||||
	err = mutex_lock_interruptible(&u->readlock);
 | 
			
		||||
	if (err)
 | 
			
		||||
		return err;
 | 
			
		||||
 | 
			
		||||
	err = 0;
 | 
			
		||||
	if (u->addr)
 | 
			
		||||
| 
						 | 
				
			
			@ -877,7 +879,9 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
 | 
			
		|||
		goto out;
 | 
			
		||||
	addr_len = err;
 | 
			
		||||
 | 
			
		||||
	mutex_lock(&u->readlock);
 | 
			
		||||
	err = mutex_lock_interruptible(&u->readlock);
 | 
			
		||||
	if (err)
 | 
			
		||||
		goto out;
 | 
			
		||||
 | 
			
		||||
	err = -EINVAL;
 | 
			
		||||
	if (u->addr)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue