mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	tipc: kill unnecessary goto's
Remove a number of needless 'goto exit' in send_stream when the socket is in an unconnected state. This patch is cosmetic and does not alter the operation of TIPC in any way. Reviewed-by: Jon Maloy <jon.maloy@ericsson.com> Reviewed-by: Erik Hugne <erik.hugne@ericsson.com> Signed-off-by: Wang Weidong <wangweidong1@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
		
							parent
							
								
									0cee6bbe06
								
							
						
					
					
						commit
						3b8401fe9d
					
				
					 1 changed files with 6 additions and 8 deletions
				
			
		| 
						 | 
					@ -751,17 +751,15 @@ static int send_stream(struct kiocb *iocb, struct socket *sock,
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	/* Handle special cases where there is no connection */
 | 
						/* Handle special cases where there is no connection */
 | 
				
			||||||
	if (unlikely(sock->state != SS_CONNECTED)) {
 | 
						if (unlikely(sock->state != SS_CONNECTED)) {
 | 
				
			||||||
		if (sock->state == SS_UNCONNECTED) {
 | 
					 | 
				
			||||||
			res = send_packet(NULL, sock, m, total_len);
 | 
					 | 
				
			||||||
			goto exit;
 | 
					 | 
				
			||||||
		} else if (sock->state == SS_DISCONNECTING) {
 | 
					 | 
				
			||||||
			res = -EPIPE;
 | 
					 | 
				
			||||||
			goto exit;
 | 
					 | 
				
			||||||
		} else {
 | 
					 | 
				
			||||||
		res = -ENOTCONN;
 | 
							res = -ENOTCONN;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
							if (sock->state == SS_UNCONNECTED)
 | 
				
			||||||
 | 
								res = send_packet(NULL, sock, m, total_len);
 | 
				
			||||||
 | 
							else if (sock->state == SS_DISCONNECTING)
 | 
				
			||||||
 | 
								res = -EPIPE;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		goto exit;
 | 
							goto exit;
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
	}
 | 
					 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (unlikely(m->msg_name)) {
 | 
						if (unlikely(m->msg_name)) {
 | 
				
			||||||
		res = -EISCONN;
 | 
							res = -EISCONN;
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue