mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 08:38:45 +02:00 
			
		
		
		
	tracing/filters: Add __field_ext() to TRACE_EVENT
Add __field_ext(), so a field can be assigned to a specific filter_type, which matches a corresponding filter function. For example, a later patch will allow this: __field_ext(const char *, str, FILTER_PTR_STR); Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> LKML-Reference: <4A7B9272.6050709@cn.fujitsu.com> [ Fixed a -1 to FILTER_OTHER Forward ported to latest kernel. ] Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
		
							parent
							
								
									aa38e9fc3e
								
							
						
					
					
						commit
						43b51ead3f
					
				
					 6 changed files with 49 additions and 22 deletions
				
			
		|  | @ -140,9 +140,16 @@ extern int filter_current_check_discard(struct ftrace_event_call *call, | |||
| 					void *rec, | ||||
| 					struct ring_buffer_event *event); | ||||
| 
 | ||||
| enum { | ||||
| 	FILTER_OTHER = 0, | ||||
| 	FILTER_STATIC_STRING, | ||||
| 	FILTER_DYN_STRING, | ||||
| }; | ||||
| 
 | ||||
| extern int trace_define_field(struct ftrace_event_call *call, | ||||
| 			      const char *type, const char *name, | ||||
| 			      int offset, int size, int is_signed); | ||||
| 			      int offset, int size, int is_signed, | ||||
| 			      int filter_type); | ||||
| extern int trace_define_common_fields(struct ftrace_event_call *call); | ||||
| 
 | ||||
| #define is_signed_type(type)	(((type)(-1)) < 0) | ||||
|  |  | |||
|  | @ -21,6 +21,9 @@ | |||
| #undef __field | ||||
| #define __field(type, item)		type	item; | ||||
| 
 | ||||
| #undef __field_ext | ||||
| #define __field_ext(type, item, filter_type)	type	item; | ||||
| 
 | ||||
| #undef __array | ||||
| #define __array(type, item, len)	type	item[len]; | ||||
| 
 | ||||
|  | @ -62,7 +65,10 @@ | |||
|  */ | ||||
| 
 | ||||
| #undef __field | ||||
| #define __field(type, item); | ||||
| #define __field(type, item) | ||||
| 
 | ||||
| #undef __field_ext | ||||
| #define __field_ext(type, item, filter_type) | ||||
| 
 | ||||
| #undef __array | ||||
| #define __array(type, item, len) | ||||
|  | @ -110,6 +116,9 @@ | |||
| 	if (!ret)							\ | ||||
| 		return 0; | ||||
| 
 | ||||
| #undef __field_ext | ||||
| #define __field_ext(type, item, filter_type)	__field(type, item) | ||||
| 
 | ||||
| #undef __array | ||||
| #define __array(type, item, len)						\ | ||||
| 	ret = trace_seq_printf(s, "\tfield:" #type " " #item "[" #len "];\t"	\ | ||||
|  | @ -265,28 +274,33 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags)	\ | |||
| 	 | ||||
| #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ||||
| 
 | ||||
| #undef __field | ||||
| #define __field(type, item)						\ | ||||
| #undef __field_ext | ||||
| #define __field_ext(type, item, filter_type)				\ | ||||
| 	ret = trace_define_field(event_call, #type, #item,		\ | ||||
| 				 offsetof(typeof(field), item),		\ | ||||
| 				 sizeof(field.item), is_signed_type(type));	\ | ||||
| 				 sizeof(field.item),			\ | ||||
| 				 is_signed_type(type), filter_type);	\ | ||||
| 	if (ret)							\ | ||||
| 		return ret; | ||||
| 
 | ||||
| #undef __field | ||||
| #define __field(type, item)	__field_ext(type, item, FILTER_OTHER) | ||||
| 
 | ||||
| #undef __array | ||||
| #define __array(type, item, len)					\ | ||||
| 	BUILD_BUG_ON(len > MAX_FILTER_STR_VAL);				\ | ||||
| 	ret = trace_define_field(event_call, #type "[" #len "]", #item,	\ | ||||
| 				 offsetof(typeof(field), item),		\ | ||||
| 				 sizeof(field.item), 0);		\ | ||||
| 				 sizeof(field.item), 0, FILTER_OTHER);	\ | ||||
| 	if (ret)							\ | ||||
| 		return ret; | ||||
| 
 | ||||
| #undef __dynamic_array | ||||
| #define __dynamic_array(type, item, len)				       \ | ||||
| 	ret = trace_define_field(event_call, "__data_loc " #type "[]", #item,  \ | ||||
| 				offsetof(typeof(field), __data_loc_##item),    \ | ||||
| 				 sizeof(field.__data_loc_##item), 0); | ||||
| 				 offsetof(typeof(field), __data_loc_##item),   \ | ||||
| 				 sizeof(field.__data_loc_##item), 0,	       \ | ||||
| 				 FILTER_OTHER); | ||||
| 
 | ||||
| #undef __string | ||||
| #define __string(item, src) __dynamic_array(char, item, -1) | ||||
|  | @ -320,6 +334,9 @@ ftrace_define_fields_##call(struct ftrace_event_call *event_call)	\ | |||
| #undef __field | ||||
| #define __field(type, item) | ||||
| 
 | ||||
| #undef __field_ext | ||||
| #define __field_ext(type, item, filter_type) | ||||
| 
 | ||||
| #undef __array | ||||
| #define __array(type, item, len) | ||||
| 
 | ||||
|  |  | |||
|  | @ -28,7 +28,8 @@ DEFINE_MUTEX(event_mutex); | |||
| LIST_HEAD(ftrace_events); | ||||
| 
 | ||||
| int trace_define_field(struct ftrace_event_call *call, const char *type, | ||||
| 		       const char *name, int offset, int size, int is_signed) | ||||
| 		       const char *name, int offset, int size, int is_signed, | ||||
| 		       int filter_type) | ||||
| { | ||||
| 	struct ftrace_event_field *field; | ||||
| 
 | ||||
|  | @ -44,7 +45,11 @@ int trace_define_field(struct ftrace_event_call *call, const char *type, | |||
| 	if (!field->type) | ||||
| 		goto err; | ||||
| 
 | ||||
| 	field->filter_type = filter_assign_type(type); | ||||
| 	if (filter_type == FILTER_OTHER) | ||||
| 		field->filter_type = filter_assign_type(type); | ||||
| 	else | ||||
| 		field->filter_type = filter_type; | ||||
| 
 | ||||
| 	field->offset = offset; | ||||
| 	field->size = size; | ||||
| 	field->is_signed = is_signed; | ||||
|  | @ -68,7 +73,7 @@ EXPORT_SYMBOL_GPL(trace_define_field); | |||
| 	ret = trace_define_field(call, #type, "common_" #item,		\ | ||||
| 				 offsetof(typeof(ent), item),		\ | ||||
| 				 sizeof(ent.item),			\ | ||||
| 				 is_signed_type(type));			\ | ||||
| 				 is_signed_type(type), FILTER_OTHER);	\ | ||||
| 	if (ret)							\ | ||||
| 		return ret; | ||||
| 
 | ||||
|  |  | |||
|  | @ -475,12 +475,6 @@ static int filter_add_pred_fn(struct filter_parse_state *ps, | |||
| 	return 0; | ||||
| } | ||||
| 
 | ||||
| enum { | ||||
| 	FILTER_OTHER = 0, | ||||
| 	FILTER_STATIC_STRING, | ||||
| 	FILTER_DYN_STRING, | ||||
| }; | ||||
| 
 | ||||
| int filter_assign_type(const char *type) | ||||
| { | ||||
| 	if (strstr(type, "__data_loc") && strstr(type, "char")) | ||||
|  |  | |||
|  | @ -158,7 +158,8 @@ __attribute__((section("_ftrace_events"))) event_##call = {		\ | |||
| #define TRACE_FIELD(type, item, assign)					\ | ||||
| 	ret = trace_define_field(event_call, #type, #item,		\ | ||||
| 				 offsetof(typeof(field), item),		\ | ||||
| 				 sizeof(field.item), is_signed_type(type));	\ | ||||
| 				 sizeof(field.item),			\ | ||||
| 				 is_signed_type(type), FILTER_OTHER);	\ | ||||
| 	if (ret)							\ | ||||
| 		return ret; | ||||
| 
 | ||||
|  | @ -166,7 +167,7 @@ __attribute__((section("_ftrace_events"))) event_##call = {		\ | |||
| #define TRACE_FIELD_SPECIAL(type, item, len, cmd)			\ | ||||
| 	ret = trace_define_field(event_call, #type "[" #len "]", #item,	\ | ||||
| 				 offsetof(typeof(field), item),		\ | ||||
| 				 sizeof(field.item), 0);		\ | ||||
| 				 sizeof(field.item), 0, FILTER_OTHER);	\ | ||||
| 	if (ret)							\ | ||||
| 		return ret; | ||||
| 
 | ||||
|  | @ -174,7 +175,8 @@ __attribute__((section("_ftrace_events"))) event_##call = {		\ | |||
| #define TRACE_FIELD_SIGN(type, item, assign, is_signed)			\ | ||||
| 	ret = trace_define_field(event_call, #type, #item,		\ | ||||
| 				 offsetof(typeof(field), item),		\ | ||||
| 				 sizeof(field.item), is_signed);	\ | ||||
| 				 sizeof(field.item), is_signed,		\ | ||||
| 				 FILTER_OTHER);				\ | ||||
| 	if (ret)							\ | ||||
| 		return ret; | ||||
| 
 | ||||
|  |  | |||
|  | @ -194,7 +194,8 @@ int syscall_enter_define_fields(struct ftrace_event_call *call) | |||
| 	for (i = 0; i < meta->nb_args; i++) { | ||||
| 		ret = trace_define_field(call, meta->types[i], | ||||
| 					 meta->args[i], offset, | ||||
| 					 sizeof(unsigned long), 0); | ||||
| 					 sizeof(unsigned long), 0, | ||||
| 					 FILTER_OTHER); | ||||
| 		offset += sizeof(unsigned long); | ||||
| 	} | ||||
| 
 | ||||
|  | @ -210,7 +211,8 @@ int syscall_exit_define_fields(struct ftrace_event_call *call) | |||
| 	if (ret) | ||||
| 		return ret; | ||||
| 
 | ||||
| 	ret = trace_define_field(call, SYSCALL_FIELD(unsigned long, ret), 0); | ||||
| 	ret = trace_define_field(call, SYSCALL_FIELD(unsigned long, ret), 0, | ||||
| 				 FILTER_OTHER); | ||||
| 
 | ||||
| 	return ret; | ||||
| } | ||||
|  |  | |||
		Loading…
	
		Reference in a new issue
	
	 Li Zefan
						Li Zefan