mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-08 20:49:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

leds: led-class: Add missing put_device() to led_put()

Browse source 
led_put() is used to "undo" a successful of_led_get() call,
of_led_get() uses class_find_device_by_of_node() which returns
a reference to the device which must be free-ed with put_device()
when the caller is done with it.

Add a put_device() call to led_put() to free the reference returned
by class_find_device_by_of_node().

And also add a put_device() in the error-exit case of try_module_get()
failing.

Fixes: 699a8c7c4b ("leds: Add of_led_get() and led_put()")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230120114524.408368-2-hdegoede@redhat.com
This commit is contained in:
Hans de Goede 2023-01-20 12:45:14 +01:00 committed by Lee Jones
parent 1b929c02af
commit 445110941e
1 changed files with 4 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/leds/led-class.c
View file

@ -241,8 +241,10 @@ struct led_classdev *of_led_get(struct device_node *np, int index)
led_cdev = dev_get_drvdata(led_dev); led_cdev = dev_get_drvdata(led_dev);
if (!try_module_get(led_cdev->dev->parent->driver->owner)) if (!try_module_get(led_cdev->dev->parent->driver->owner)) {
put_device(led_cdev->dev);
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
}
return led_cdev; return led_cdev;
} }
@ -255,6 +257,7 @@ EXPORT_SYMBOL_GPL(of_led_get);
void led_put(struct led_classdev *led_cdev) void led_put(struct led_classdev *led_cdev)
{ {
module_put(led_cdev->dev->parent->driver->owner); module_put(led_cdev->dev->parent->driver->owner);
put_device(led_cdev->dev);
} }
EXPORT_SYMBOL_GPL(led_put); EXPORT_SYMBOL_GPL(led_put);