mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	locking/mutex: Disable optimistic spinning on some architectures
The optimistic spin code assumes regular stores and cmpxchg() play nice; this is found to not be true for at least: parisc, sparc32, tile32, metag-lock1, arc-!llsc and hexagon. There is further wreckage, but this in particular seemed easy to trigger, so blacklist this. Opt in for known good archs. Signed-off-by: Peter Zijlstra <peterz@infradead.org> Reported-by: Mikulas Patocka <mpatocka@redhat.com> Cc: David Miller <davem@davemloft.net> Cc: Chris Metcalf <cmetcalf@tilera.com> Cc: James Bottomley <James.Bottomley@hansenpartnership.com> Cc: Vineet Gupta <vgupta@synopsys.com> Cc: Jason Low <jason.low2@hp.com> Cc: Waiman Long <waiman.long@hp.com> Cc: "James E.J. Bottomley" <jejb@parisc-linux.org> Cc: Paul McKenney <paulmck@linux.vnet.ibm.com> Cc: John David Anglin <dave.anglin@bell.net> Cc: James Hogan <james.hogan@imgtec.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Davidlohr Bueso <davidlohr@hp.com> Cc: stable@vger.kernel.org Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Russell King <linux@arm.linux.org.uk> Cc: Will Deacon <will.deacon@arm.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: sparclinux@vger.kernel.org Link: http://lkml.kernel.org/r/20140606175316.GV13930@laptop.programming.kicks-ass.net Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
		
							parent
							
								
									ce069fc920
								
							
						
					
					
						commit
						4badad352a
					
				
					 6 changed files with 9 additions and 1 deletions
				
			
		|  | @ -6,6 +6,7 @@ config ARM | ||||||
| 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST | 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST | ||||||
| 	select ARCH_HAVE_CUSTOM_GPIO_H | 	select ARCH_HAVE_CUSTOM_GPIO_H | ||||||
| 	select ARCH_MIGHT_HAVE_PC_PARPORT | 	select ARCH_MIGHT_HAVE_PC_PARPORT | ||||||
|  | 	select ARCH_SUPPORTS_ATOMIC_RMW | ||||||
| 	select ARCH_USE_BUILTIN_BSWAP | 	select ARCH_USE_BUILTIN_BSWAP | ||||||
| 	select ARCH_USE_CMPXCHG_LOCKREF | 	select ARCH_USE_CMPXCHG_LOCKREF | ||||||
| 	select ARCH_WANT_IPC_PARSE_VERSION | 	select ARCH_WANT_IPC_PARSE_VERSION | ||||||
|  |  | ||||||
|  | @ -4,6 +4,7 @@ config ARM64 | ||||||
| 	select ARCH_HAS_OPP | 	select ARCH_HAS_OPP | ||||||
| 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST | 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST | ||||||
| 	select ARCH_USE_CMPXCHG_LOCKREF | 	select ARCH_USE_CMPXCHG_LOCKREF | ||||||
|  | 	select ARCH_SUPPORTS_ATOMIC_RMW | ||||||
| 	select ARCH_WANT_OPTIONAL_GPIOLIB | 	select ARCH_WANT_OPTIONAL_GPIOLIB | ||||||
| 	select ARCH_WANT_COMPAT_IPC_PARSE_VERSION | 	select ARCH_WANT_COMPAT_IPC_PARSE_VERSION | ||||||
| 	select ARCH_WANT_FRAME_POINTERS | 	select ARCH_WANT_FRAME_POINTERS | ||||||
|  |  | ||||||
|  | @ -145,6 +145,7 @@ config PPC | ||||||
| 	select HAVE_IRQ_EXIT_ON_IRQ_STACK | 	select HAVE_IRQ_EXIT_ON_IRQ_STACK | ||||||
| 	select ARCH_USE_CMPXCHG_LOCKREF if PPC64 | 	select ARCH_USE_CMPXCHG_LOCKREF if PPC64 | ||||||
| 	select HAVE_ARCH_AUDITSYSCALL | 	select HAVE_ARCH_AUDITSYSCALL | ||||||
|  | 	select ARCH_SUPPORTS_ATOMIC_RMW | ||||||
| 
 | 
 | ||||||
| config GENERIC_CSUM | config GENERIC_CSUM | ||||||
| 	def_bool CPU_LITTLE_ENDIAN | 	def_bool CPU_LITTLE_ENDIAN | ||||||
|  |  | ||||||
|  | @ -78,6 +78,7 @@ config SPARC64 | ||||||
| 	select HAVE_C_RECORDMCOUNT | 	select HAVE_C_RECORDMCOUNT | ||||||
| 	select NO_BOOTMEM | 	select NO_BOOTMEM | ||||||
| 	select HAVE_ARCH_AUDITSYSCALL | 	select HAVE_ARCH_AUDITSYSCALL | ||||||
|  | 	select ARCH_SUPPORTS_ATOMIC_RMW | ||||||
| 
 | 
 | ||||||
| config ARCH_DEFCONFIG | config ARCH_DEFCONFIG | ||||||
| 	string | 	string | ||||||
|  |  | ||||||
|  | @ -131,6 +131,7 @@ config X86 | ||||||
| 	select HAVE_CC_STACKPROTECTOR | 	select HAVE_CC_STACKPROTECTOR | ||||||
| 	select GENERIC_CPU_AUTOPROBE | 	select GENERIC_CPU_AUTOPROBE | ||||||
| 	select HAVE_ARCH_AUDITSYSCALL | 	select HAVE_ARCH_AUDITSYSCALL | ||||||
|  | 	select ARCH_SUPPORTS_ATOMIC_RMW | ||||||
| 
 | 
 | ||||||
| config INSTRUCTION_DECODER | config INSTRUCTION_DECODER | ||||||
| 	def_bool y | 	def_bool y | ||||||
|  |  | ||||||
|  | @ -220,9 +220,12 @@ config INLINE_WRITE_UNLOCK_IRQRESTORE | ||||||
| 
 | 
 | ||||||
| endif | endif | ||||||
| 
 | 
 | ||||||
|  | config ARCH_SUPPORTS_ATOMIC_RMW | ||||||
|  | 	bool | ||||||
|  | 
 | ||||||
| config MUTEX_SPIN_ON_OWNER | config MUTEX_SPIN_ON_OWNER | ||||||
| 	def_bool y | 	def_bool y | ||||||
| 	depends on SMP && !DEBUG_MUTEXES | 	depends on SMP && !DEBUG_MUTEXES && ARCH_SUPPORTS_ATOMIC_RMW | ||||||
| 
 | 
 | ||||||
| config ARCH_USE_QUEUE_RWLOCK | config ARCH_USE_QUEUE_RWLOCK | ||||||
| 	bool | 	bool | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue
	
	 Peter Zijlstra
						Peter Zijlstra