mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-09 05:00:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/i915/mst: convert to struct intel_display

Browse source 
struct intel_display will replace struct drm_i915_private as the main
display device data structure. Convert the DP MST code to struct
intel_display as much as possible.

Reviewed-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/84c9923fccdd779f0ca713cab1d26a0c802b140c.1731409802.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
This commit is contained in:
Jani Nikula 2024-11-12 13:10:42 +02:00
parent 8c6942748b
commit 529798bd78
1 changed files with 85 additions and 85 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

170
drivers/gpu/drm/i915/display/intel_dp_mst.c
View file

@ -74,11 +74,11 @@ static struct intel_dp *to_primary_dp(struct intel_encoder *encoder)
static int intel_dp_mst_max_dpt_bpp(const struct intel_crtc_state *crtc_state, static int intel_dp_mst_max_dpt_bpp(const struct intel_crtc_state *crtc_state,
bool dsc) bool dsc)
{ {
struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev); struct intel_display *display = to_intel_display(crtc_state);
const struct drm_display_mode *adjusted_mode = const struct drm_display_mode *adjusted_mode =
&crtc_state->hw.adjusted_mode; &crtc_state->hw.adjusted_mode;
if (!intel_dp_is_uhbr(crtc_state) || DISPLAY_VER(i915) >= 20 || !dsc) if (!intel_dp_is_uhbr(crtc_state) || DISPLAY_VER(display) >= 20 || !dsc)
return INT_MAX; return INT_MAX;
/* /*
@ -188,12 +188,12 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
int step, int step,
bool dsc) bool dsc)
{ {
struct intel_display *display = to_intel_display(encoder);
struct drm_atomic_state *state = crtc_state->uapi.state; struct drm_atomic_state *state = crtc_state->uapi.state;
struct intel_dp *intel_dp = to_primary_dp(encoder); struct intel_dp *intel_dp = to_primary_dp(encoder);
struct drm_dp_mst_topology_state *mst_state; struct drm_dp_mst_topology_state *mst_state;
struct intel_connector *connector = struct intel_connector *connector =
to_intel_connector(conn_state->connector); to_intel_connector(conn_state->connector);
struct drm_i915_private *i915 = to_i915(connector->base.dev);
const struct drm_display_mode *adjusted_mode = const struct drm_display_mode *adjusted_mode =
&crtc_state->hw.adjusted_mode; &crtc_state->hw.adjusted_mode;
int bpp, slots = -EINVAL; int bpp, slots = -EINVAL;
@ -221,18 +221,18 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
max_dpt_bpp = intel_dp_mst_max_dpt_bpp(crtc_state, dsc); max_dpt_bpp = intel_dp_mst_max_dpt_bpp(crtc_state, dsc);
if (max_bpp > max_dpt_bpp) { if (max_bpp > max_dpt_bpp) {
drm_dbg_kms(&i915->drm, "Limiting bpp to max DPT bpp (%d -> %d)\n", drm_dbg_kms(display->drm, "Limiting bpp to max DPT bpp (%d -> %d)\n",
max_bpp, max_dpt_bpp); max_bpp, max_dpt_bpp);
max_bpp = max_dpt_bpp; max_bpp = max_dpt_bpp;
} }
drm_dbg_kms(&i915->drm, "Looking for slots in range min bpp %d max bpp %d\n", drm_dbg_kms(display->drm, "Looking for slots in range min bpp %d max bpp %d\n",
min_bpp, max_bpp); min_bpp, max_bpp);
if (dsc) { if (dsc) {
dsc_slice_count = intel_dp_mst_dsc_get_slice_count(connector, crtc_state); dsc_slice_count = intel_dp_mst_dsc_get_slice_count(connector, crtc_state);
if (!dsc_slice_count) { if (!dsc_slice_count) {
drm_dbg_kms(&i915->drm, "Can't get valid DSC slice count\n"); drm_dbg_kms(display->drm, "Can't get valid DSC slice count\n");
return -ENOSPC; return -ENOSPC;
} }
@ -245,7 +245,7 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
int remote_tu; int remote_tu;
fixed20_12 pbn; fixed20_12 pbn;
drm_dbg_kms(&i915->drm, "Trying bpp %d\n", bpp); drm_dbg_kms(display->drm, "Trying bpp %d\n", bpp);
link_bpp_x16 = fxp_q4_from_int(dsc ? bpp : link_bpp_x16 = fxp_q4_from_int(dsc ? bpp :
intel_dp_output_bpp(crtc_state->output_format, bpp)); intel_dp_output_bpp(crtc_state->output_format, bpp));
@ -298,7 +298,7 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
pbn.full = remote_tu * mst_state->pbn_div.full; pbn.full = remote_tu * mst_state->pbn_div.full;
crtc_state->pbn = dfixed_trunc(pbn); crtc_state->pbn = dfixed_trunc(pbn);
drm_WARN_ON(&i915->drm, remote_tu < crtc_state->dp_m_n.tu); drm_WARN_ON(display->drm, remote_tu < crtc_state->dp_m_n.tu);
crtc_state->dp_m_n.tu = remote_tu; crtc_state->dp_m_n.tu = remote_tu;
slots = drm_dp_atomic_find_time_slots(state, &intel_dp->mst_mgr, slots = drm_dp_atomic_find_time_slots(state, &intel_dp->mst_mgr,
@ -308,7 +308,7 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
return slots; return slots;
if (slots >= 0) { if (slots >= 0) {
drm_WARN_ON(&i915->drm, slots != crtc_state->dp_m_n.tu); drm_WARN_ON(display->drm, slots != crtc_state->dp_m_n.tu);
break; break;
} }
@ -319,14 +319,15 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
slots = ret; slots = ret;
if (slots < 0) { if (slots < 0) {
drm_dbg_kms(&i915->drm, "failed finding vcpi slots:%d\n", drm_dbg_kms(display->drm, "failed finding vcpi slots:%d\n",
slots); slots);
} else { } else {
if (!dsc) if (!dsc)
crtc_state->pipe_bpp = bpp; crtc_state->pipe_bpp = bpp;
else else
crtc_state->dsc.compressed_bpp_x16 = fxp_q4_from_int(bpp); crtc_state->dsc.compressed_bpp_x16 = fxp_q4_from_int(bpp);
drm_dbg_kms(&i915->drm, "Got %d slots for pipe bpp %d dsc %d\n", slots, bpp, dsc); drm_dbg_kms(display->drm, "Got %d slots for pipe bpp %d dsc %d\n",
slots, bpp, dsc);
} }
return slots; return slots;
@ -360,8 +361,8 @@ static int intel_dp_dsc_mst_compute_link_config(struct intel_encoder *encoder,
struct drm_connector_state *conn_state, struct drm_connector_state *conn_state,
struct link_config_limits *limits) struct link_config_limits *limits)
{ {
struct intel_connector *connector = struct intel_display *display = to_intel_display(encoder);
to_intel_connector(conn_state->connector); struct intel_connector *connector = to_intel_connector(conn_state->connector);
struct drm_i915_private *i915 = to_i915(connector->base.dev); struct drm_i915_private *i915 = to_i915(connector->base.dev);
int slots = -EINVAL; int slots = -EINVAL;
int i, num_bpc; int i, num_bpc;
@ -371,7 +372,7 @@ static int intel_dp_dsc_mst_compute_link_config(struct intel_encoder *encoder,
int min_compressed_bpp, max_compressed_bpp; int min_compressed_bpp, max_compressed_bpp;
/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */ /* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
if (DISPLAY_VER(i915) >= 12) if (DISPLAY_VER(display) >= 12)
dsc_max_bpc = min_t(u8, 12, conn_state->max_requested_bpc); dsc_max_bpc = min_t(u8, 12, conn_state->max_requested_bpc);
else else
dsc_max_bpc = min_t(u8, 10, conn_state->max_requested_bpc); dsc_max_bpc = min_t(u8, 10, conn_state->max_requested_bpc);
@ -382,7 +383,7 @@ static int intel_dp_dsc_mst_compute_link_config(struct intel_encoder *encoder,
num_bpc = drm_dp_dsc_sink_supported_input_bpcs(connector->dp.dsc_dpcd, num_bpc = drm_dp_dsc_sink_supported_input_bpcs(connector->dp.dsc_dpcd,
dsc_bpc); dsc_bpc);
drm_dbg_kms(&i915->drm, "DSC Source supported min bpp %d max bpp %d\n", drm_dbg_kms(display->drm, "DSC Source supported min bpp %d max bpp %d\n",
min_bpp, max_bpp); min_bpp, max_bpp);
sink_max_bpp = dsc_bpc[0] * 3; sink_max_bpp = dsc_bpc[0] * 3;
@ -395,7 +396,7 @@ static int intel_dp_dsc_mst_compute_link_config(struct intel_encoder *encoder,
sink_max_bpp = dsc_bpc[i] * 3; sink_max_bpp = dsc_bpc[i] * 3;
} }
drm_dbg_kms(&i915->drm, "DSC Sink supported min bpp %d max bpp %d\n", drm_dbg_kms(display->drm, "DSC Sink supported min bpp %d max bpp %d\n",
sink_min_bpp, sink_max_bpp); sink_min_bpp, sink_max_bpp);
if (min_bpp < sink_min_bpp) if (min_bpp < sink_min_bpp)
@ -416,7 +417,7 @@ static int intel_dp_dsc_mst_compute_link_config(struct intel_encoder *encoder,
min_compressed_bpp = max(min_compressed_bpp, min_compressed_bpp = max(min_compressed_bpp,
fxp_q4_to_int_roundup(limits->link.min_bpp_x16)); fxp_q4_to_int_roundup(limits->link.min_bpp_x16));
drm_dbg_kms(&i915->drm, "DSC Sink supported compressed min bpp %d compressed max bpp %d\n", drm_dbg_kms(display->drm, "DSC Sink supported compressed min bpp %d compressed max bpp %d\n",
min_compressed_bpp, max_compressed_bpp); min_compressed_bpp, max_compressed_bpp);
/* Align compressed bpps according to our own constraints */ /* Align compressed bpps according to our own constraints */
@ -438,7 +439,7 @@ static int intel_dp_mst_update_slots(struct intel_encoder *encoder,
struct intel_crtc_state *crtc_state, struct intel_crtc_state *crtc_state,
struct drm_connector_state *conn_state) struct drm_connector_state *conn_state)
{ {
struct drm_i915_private *i915 = to_i915(encoder->base.dev); struct intel_display *display = to_intel_display(encoder);
struct intel_dp *intel_dp = to_primary_dp(encoder); struct intel_dp *intel_dp = to_primary_dp(encoder);
struct drm_dp_mst_topology_mgr *mgr = &intel_dp->mst_mgr; struct drm_dp_mst_topology_mgr *mgr = &intel_dp->mst_mgr;
struct drm_dp_mst_topology_state *topology_state; struct drm_dp_mst_topology_state *topology_state;
@ -447,7 +448,7 @@ static int intel_dp_mst_update_slots(struct intel_encoder *encoder,
topology_state = drm_atomic_get_mst_topology_state(conn_state->state, mgr); topology_state = drm_atomic_get_mst_topology_state(conn_state->state, mgr);
if (IS_ERR(topology_state)) { if (IS_ERR(topology_state)) {
drm_dbg_kms(&i915->drm, "slot update failed\n"); drm_dbg_kms(display->drm, "slot update failed\n");
return PTR_ERR(topology_state); return PTR_ERR(topology_state);
} }
@ -495,7 +496,7 @@ adjust_limits_for_dsc_hblank_expansion_quirk(const struct intel_connector *conne
struct link_config_limits *limits, struct link_config_limits *limits,
bool dsc) bool dsc)
{ {
struct drm_i915_private *i915 = to_i915(connector->base.dev); struct intel_display *display = to_intel_display(connector);
const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
int min_bpp_x16 = limits->link.min_bpp_x16; int min_bpp_x16 = limits->link.min_bpp_x16;
@ -504,14 +505,14 @@ adjust_limits_for_dsc_hblank_expansion_quirk(const struct intel_connector *conne
if (!dsc) { if (!dsc) {
if (intel_dp_supports_dsc(connector, crtc_state)) { if (intel_dp_supports_dsc(connector, crtc_state)) {
drm_dbg_kms(&i915->drm, drm_dbg_kms(display->drm,
"[CRTC:%d:%s][CONNECTOR:%d:%s] DSC needed by hblank expansion quirk\n", "[CRTC:%d:%s][CONNECTOR:%d:%s] DSC needed by hblank expansion quirk\n",
crtc->base.base.id, crtc->base.name, crtc->base.base.id, crtc->base.name,
connector->base.base.id, connector->base.name); connector->base.base.id, connector->base.name);
return false; return false;
} }
drm_dbg_kms(&i915->drm, drm_dbg_kms(display->drm,
"[CRTC:%d:%s][CONNECTOR:%d:%s] Increasing link min bpp to 24 due to hblank expansion quirk\n", "[CRTC:%d:%s][CONNECTOR:%d:%s] Increasing link min bpp to 24 due to hblank expansion quirk\n",
crtc->base.base.id, crtc->base.name, crtc->base.base.id, crtc->base.name,
connector->base.base.id, connector->base.name); connector->base.base.id, connector->base.name);
@ -524,7 +525,7 @@ adjust_limits_for_dsc_hblank_expansion_quirk(const struct intel_connector *conne
return true; return true;
} }
drm_WARN_ON(&i915->drm, limits->min_rate != limits->max_rate); drm_WARN_ON(display->drm, limits->min_rate != limits->max_rate);
if (limits->max_rate < 540000) if (limits->max_rate < 540000)
min_bpp_x16 = fxp_q4_from_int(13); min_bpp_x16 = fxp_q4_from_int(13);
@ -534,7 +535,7 @@ adjust_limits_for_dsc_hblank_expansion_quirk(const struct intel_connector *conne
if (limits->link.min_bpp_x16 >= min_bpp_x16) if (limits->link.min_bpp_x16 >= min_bpp_x16)
return true; return true;
drm_dbg_kms(&i915->drm, drm_dbg_kms(display->drm,
"[CRTC:%d:%s][CONNECTOR:%d:%s] Increasing link min bpp to " FXP_Q4_FMT " in DSC mode due to hblank expansion quirk\n", "[CRTC:%d:%s][CONNECTOR:%d:%s] Increasing link min bpp to " FXP_Q4_FMT " in DSC mode due to hblank expansion quirk\n",
crtc->base.base.id, crtc->base.name, crtc->base.base.id, crtc->base.name,
connector->base.base.id, connector->base.name, connector->base.base.id, connector->base.name,
@ -594,6 +595,7 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder,
struct intel_crtc_state *pipe_config, struct intel_crtc_state *pipe_config,
struct drm_connector_state *conn_state) struct drm_connector_state *conn_state)
{ {
struct intel_display *display = to_intel_display(encoder);
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct intel_atomic_state *state = to_intel_atomic_state(conn_state->state); struct intel_atomic_state *state = to_intel_atomic_state(conn_state->state);
struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc); struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
@ -646,7 +648,7 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder,
/* enable compression if the mode doesn't fit available BW */ /* enable compression if the mode doesn't fit available BW */
if (dsc_needed) { if (dsc_needed) {
drm_dbg_kms(&dev_priv->drm, "Try DSC (fallback=%s, joiner=%s, force=%s)\n", drm_dbg_kms(display->drm, "Try DSC (fallback=%s, joiner=%s, force=%s)\n",
str_yes_no(ret), str_yes_no(joiner_needs_dsc), str_yes_no(ret), str_yes_no(joiner_needs_dsc),
str_yes_no(intel_dp->force_dsc_en)); str_yes_no(intel_dp->force_dsc_en));
@ -664,12 +666,13 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder,
* FIXME: As bpc is hardcoded to 8, as mentioned above, * FIXME: As bpc is hardcoded to 8, as mentioned above,
* WARN and ignore the debug flag force_dsc_bpc for now. * WARN and ignore the debug flag force_dsc_bpc for now.
*/ */
drm_WARN(&dev_priv->drm, intel_dp->force_dsc_bpc, "Cannot Force BPC for MST\n"); drm_WARN(display->drm, intel_dp->force_dsc_bpc,
"Cannot Force BPC for MST\n");
/* /*
* Try to get at least some timeslots and then see, if * Try to get at least some timeslots and then see, if
* we can fit there with DSC. * we can fit there with DSC.
*/ */
drm_dbg_kms(&dev_priv->drm, "Trying to find VCPI slots in DSC mode\n"); drm_dbg_kms(display->drm, "Trying to find VCPI slots in DSC mode\n");
ret = intel_dp_dsc_mst_compute_link_config(encoder, pipe_config, ret = intel_dp_dsc_mst_compute_link_config(encoder, pipe_config,
conn_state, &limits); conn_state, &limits);
@ -691,7 +694,7 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder,
pipe_config->limited_color_range = pipe_config->limited_color_range =
intel_dp_limited_color_range(pipe_config, conn_state); intel_dp_limited_color_range(pipe_config, conn_state);
if (IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv)) if (display->platform.geminilake || display->platform.broxton)
pipe_config->lane_lat_optim_mask = pipe_config->lane_lat_optim_mask =
bxt_dpio_phy_calc_lane_lat_optim_mask(pipe_config->lane_count); bxt_dpio_phy_calc_lane_lat_optim_mask(pipe_config->lane_count);
@ -713,13 +716,13 @@ static unsigned int
intel_dp_mst_transcoder_mask(struct intel_atomic_state *state, intel_dp_mst_transcoder_mask(struct intel_atomic_state *state,
struct intel_dp *mst_port) struct intel_dp *mst_port)
{ {
struct drm_i915_private *dev_priv = to_i915(state->base.dev); struct intel_display *display = to_intel_display(state);
const struct intel_digital_connector_state *conn_state; const struct intel_digital_connector_state *conn_state;
struct intel_connector *connector; struct intel_connector *connector;
u8 transcoders = 0; u8 transcoders = 0;
int i; int i;
if (DISPLAY_VER(dev_priv) < 12) if (DISPLAY_VER(display) < 12)
return 0; return 0;
for_each_new_intel_connector_in_state(state, connector, conn_state, i) { for_each_new_intel_connector_in_state(state, connector, conn_state, i) {
@ -773,7 +776,7 @@ static int intel_dp_mst_check_fec_change(struct intel_atomic_state *state,
struct drm_dp_mst_topology_mgr *mst_mgr, struct drm_dp_mst_topology_mgr *mst_mgr,
struct intel_link_bw_limits *limits) struct intel_link_bw_limits *limits)
{ {
struct drm_i915_private *i915 = to_i915(state->base.dev); struct intel_display *display = to_intel_display(state);
struct intel_crtc *crtc; struct intel_crtc *crtc;
u8 mst_pipe_mask; u8 mst_pipe_mask;
u8 fec_pipe_mask = 0; u8 fec_pipe_mask = 0;
@ -781,12 +784,12 @@ static int intel_dp_mst_check_fec_change(struct intel_atomic_state *state,
mst_pipe_mask = get_pipes_downstream_of_mst_port(state, mst_mgr, NULL); mst_pipe_mask = get_pipes_downstream_of_mst_port(state, mst_mgr, NULL);
for_each_intel_crtc_in_pipe_mask(&i915->drm, crtc, mst_pipe_mask) { for_each_intel_crtc_in_pipe_mask(display->drm, crtc, mst_pipe_mask) {
struct intel_crtc_state *crtc_state = struct intel_crtc_state *crtc_state =
intel_atomic_get_new_crtc_state(state, crtc); intel_atomic_get_new_crtc_state(state, crtc);
/* Atomic connector check should've added all the MST CRTCs. */ /* Atomic connector check should've added all the MST CRTCs. */
if (drm_WARN_ON(&i915->drm, !crtc_state)) if (drm_WARN_ON(display->drm, !crtc_state))
return -EINVAL; return -EINVAL;
if (crtc_state->fec_enable) if (crtc_state->fec_enable)
@ -896,7 +899,7 @@ static int
intel_dp_mst_atomic_topology_check(struct intel_connector *connector, intel_dp_mst_atomic_topology_check(struct intel_connector *connector,
struct intel_atomic_state *state) struct intel_atomic_state *state)
{ {
struct drm_i915_private *dev_priv = to_i915(state->base.dev); struct intel_display *display = to_intel_display(connector);
struct drm_connector_list_iter connector_list_iter; struct drm_connector_list_iter connector_list_iter;
struct intel_connector *connector_iter; struct intel_connector *connector_iter;
int ret = 0; int ret = 0;
@ -904,7 +907,7 @@ intel_dp_mst_atomic_topology_check(struct intel_connector *connector,
if (!intel_connector_needs_modeset(state, &connector->base)) if (!intel_connector_needs_modeset(state, &connector->base))
return 0; return 0;
drm_connector_list_iter_begin(&dev_priv->drm, &connector_list_iter); drm_connector_list_iter_begin(display->drm, &connector_list_iter);
for_each_intel_connector_iter(connector_iter, &connector_list_iter) { for_each_intel_connector_iter(connector_iter, &connector_list_iter) {
struct intel_digital_connector_state *conn_iter_state; struct intel_digital_connector_state *conn_iter_state;
struct intel_crtc_state *crtc_state; struct intel_crtc_state *crtc_state;
@ -974,21 +977,21 @@ intel_dp_mst_atomic_check(struct drm_connector *connector,
static void clear_act_sent(struct intel_encoder *encoder, static void clear_act_sent(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state) const struct intel_crtc_state *crtc_state)
{ {
struct drm_i915_private *i915 = to_i915(encoder->base.dev); struct intel_display *display = to_intel_display(encoder);
intel_de_write(i915, dp_tp_status_reg(encoder, crtc_state), intel_de_write(display, dp_tp_status_reg(encoder, crtc_state),
DP_TP_STATUS_ACT_SENT); DP_TP_STATUS_ACT_SENT);
} }
static void wait_for_act_sent(struct intel_encoder *encoder, static void wait_for_act_sent(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state) const struct intel_crtc_state *crtc_state)
{ {
struct drm_i915_private *i915 = to_i915(encoder->base.dev); struct intel_display *display = to_intel_display(encoder);
struct intel_dp *intel_dp = to_primary_dp(encoder); struct intel_dp *intel_dp = to_primary_dp(encoder);
if (intel_de_wait_for_set(i915, dp_tp_status_reg(encoder, crtc_state), if (intel_de_wait_for_set(display, dp_tp_status_reg(encoder, crtc_state),
DP_TP_STATUS_ACT_SENT, 1)) DP_TP_STATUS_ACT_SENT, 1))
drm_err(&i915->drm, "Timed out waiting for ACT sent\n"); drm_err(display->drm, "Timed out waiting for ACT sent\n");
drm_dp_check_act_status(&intel_dp->mst_mgr); drm_dp_check_act_status(&intel_dp->mst_mgr);
} }
@ -998,13 +1001,13 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state,
const struct intel_crtc_state *old_crtc_state, const struct intel_crtc_state *old_crtc_state,
const struct drm_connector_state *old_conn_state) const struct drm_connector_state *old_conn_state)
{ {
struct intel_display *display = to_intel_display(state);
struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder); struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
struct intel_dp *intel_dp = to_primary_dp(encoder); struct intel_dp *intel_dp = to_primary_dp(encoder);
struct intel_connector *connector = struct intel_connector *connector =
to_intel_connector(old_conn_state->connector); to_intel_connector(old_conn_state->connector);
struct drm_i915_private *i915 = to_i915(connector->base.dev);
drm_dbg_kms(&i915->drm, "active links %d\n", drm_dbg_kms(display->drm, "active links %d\n",
intel_dp->active_mst_links); intel_dp->active_mst_links);
if (intel_dp->active_mst_links == 1) if (intel_dp->active_mst_links == 1)
@ -1034,15 +1037,13 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
drm_atomic_get_mst_payload_state(old_mst_state, connector->port); drm_atomic_get_mst_payload_state(old_mst_state, connector->port);
struct drm_dp_mst_atomic_payload *new_payload = struct drm_dp_mst_atomic_payload *new_payload =
drm_atomic_get_mst_payload_state(new_mst_state, connector->port); drm_atomic_get_mst_payload_state(new_mst_state, connector->port);
struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
struct intel_crtc *pipe_crtc; struct intel_crtc *pipe_crtc;
bool last_mst_stream; bool last_mst_stream;
int i; int i;
intel_dp->active_mst_links--; intel_dp->active_mst_links--;
last_mst_stream = intel_dp->active_mst_links == 0; last_mst_stream = intel_dp->active_mst_links == 0;
drm_WARN_ON(&dev_priv->drm, drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 12 && last_mst_stream &&
DISPLAY_VER(dev_priv) >= 12 && last_mst_stream &&
!intel_dp_mst_is_master_trans(old_crtc_state)); !intel_dp_mst_is_master_trans(old_crtc_state));
for_each_pipe_crtc_modeset_disable(display, pipe_crtc, old_crtc_state, i) { for_each_pipe_crtc_modeset_disable(display, pipe_crtc, old_crtc_state, i) {
@ -1058,8 +1059,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
clear_act_sent(encoder, old_crtc_state); clear_act_sent(encoder, old_crtc_state);
intel_de_rmw(dev_priv, intel_de_rmw(display,
TRANS_DDI_FUNC_CTL(dev_priv, old_crtc_state->cpu_transcoder), TRANS_DDI_FUNC_CTL(display, old_crtc_state->cpu_transcoder),
TRANS_DDI_DP_VC_PAYLOAD_ALLOC, 0); TRANS_DDI_DP_VC_PAYLOAD_ALLOC, 0);
wait_for_act_sent(encoder, old_crtc_state); wait_for_act_sent(encoder, old_crtc_state);
@ -1075,7 +1076,7 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
intel_dsc_disable(old_pipe_crtc_state); intel_dsc_disable(old_pipe_crtc_state);
if (DISPLAY_VER(dev_priv) >= 9) if (DISPLAY_VER(display) >= 9)
skl_scaler_disable(old_pipe_crtc_state); skl_scaler_disable(old_pipe_crtc_state);
else else
ilk_pfit_disable(old_pipe_crtc_state); ilk_pfit_disable(old_pipe_crtc_state);
@ -1100,7 +1101,7 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
* From older GENs spec: "Configure Transcoder Clock Select to direct * From older GENs spec: "Configure Transcoder Clock Select to direct
* no clock to the transcoder" * no clock to the transcoder"
*/ */
if (DISPLAY_VER(dev_priv) < 12 || !last_mst_stream) if (DISPLAY_VER(display) < 12 || !last_mst_stream)
intel_ddi_disable_transcoder_clock(old_crtc_state); intel_ddi_disable_transcoder_clock(old_crtc_state);
@ -1109,7 +1110,7 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
primary_encoder->post_disable(state, primary_encoder, primary_encoder->post_disable(state, primary_encoder,
old_crtc_state, NULL); old_crtc_state, NULL);
drm_dbg_kms(&dev_priv->drm, "active links %d\n", drm_dbg_kms(display->drm, "active links %d\n",
intel_dp->active_mst_links); intel_dp->active_mst_links);
} }
@ -1178,10 +1179,10 @@ static void intel_mst_pre_enable_dp(struct intel_atomic_state *state,
const struct intel_crtc_state *pipe_config, const struct intel_crtc_state *pipe_config,
const struct drm_connector_state *conn_state) const struct drm_connector_state *conn_state)
{ {
struct intel_display *display = to_intel_display(state);
struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder); struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
struct intel_encoder *primary_encoder = to_primary_encoder(encoder); struct intel_encoder *primary_encoder = to_primary_encoder(encoder);
struct intel_dp *intel_dp = to_primary_dp(encoder); struct intel_dp *intel_dp = to_primary_dp(encoder);
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct intel_connector *connector = struct intel_connector *connector =
to_intel_connector(conn_state->connector); to_intel_connector(conn_state->connector);
struct drm_dp_mst_topology_state *mst_state = struct drm_dp_mst_topology_state *mst_state =
@ -1195,11 +1196,10 @@ static void intel_mst_pre_enable_dp(struct intel_atomic_state *state,
connector->encoder = encoder; connector->encoder = encoder;
intel_mst->connector = connector; intel_mst->connector = connector;
first_mst_stream = intel_dp->active_mst_links == 0; first_mst_stream = intel_dp->active_mst_links == 0;
drm_WARN_ON(&dev_priv->drm, drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 12 && first_mst_stream &&
DISPLAY_VER(dev_priv) >= 12 && first_mst_stream &&
!intel_dp_mst_is_master_trans(pipe_config)); !intel_dp_mst_is_master_trans(pipe_config));
drm_dbg_kms(&dev_priv->drm, "active links %d\n", drm_dbg_kms(display->drm, "active links %d\n",
intel_dp->active_mst_links); intel_dp->active_mst_links);
if (first_mst_stream) if (first_mst_stream)
@ -1230,10 +1230,10 @@ static void intel_mst_pre_enable_dp(struct intel_atomic_state *state,
* first MST stream, so it's done on the DDI for the first stream and * first MST stream, so it's done on the DDI for the first stream and
* here for the following ones. * here for the following ones.
*/ */
if (DISPLAY_VER(dev_priv) < 12 || !first_mst_stream) if (DISPLAY_VER(display) < 12 || !first_mst_stream)
intel_ddi_enable_transcoder_clock(encoder, pipe_config); intel_ddi_enable_transcoder_clock(encoder, pipe_config);
if (DISPLAY_VER(dev_priv) >= 13 && !first_mst_stream) if (DISPLAY_VER(display) >= 13 && !first_mst_stream)
intel_ddi_config_transcoder_func(encoder, pipe_config); intel_ddi_config_transcoder_func(encoder, pipe_config);
intel_dsc_dp_pps_write(primary_encoder, pipe_config); intel_dsc_dp_pps_write(primary_encoder, pipe_config);
@ -1242,6 +1242,7 @@ static void intel_mst_pre_enable_dp(struct intel_atomic_state *state,
static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state) static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state)
{ {
struct intel_display *display = to_intel_display(crtc_state);
struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev); struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
u32 clear = 0; u32 clear = 0;
u32 set = 0; u32 set = 0;
@ -1249,7 +1250,7 @@ static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state)
if (!IS_ALDERLAKE_P(i915)) if (!IS_ALDERLAKE_P(i915))
return; return;
if (!IS_DISPLAY_STEP(i915, STEP_D0, STEP_FOREVER)) if (!IS_DISPLAY_STEP(display, STEP_D0, STEP_FOREVER))
return; return;
/* Wa_14013163432:adlp */ /* Wa_14013163432:adlp */
@ -1257,7 +1258,7 @@ static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state)
set |= DP_MST_FEC_BS_JITTER_WA(crtc_state->cpu_transcoder); set |= DP_MST_FEC_BS_JITTER_WA(crtc_state->cpu_transcoder);
/* Wa_14014143976:adlp */ /* Wa_14014143976:adlp */
if (IS_DISPLAY_STEP(i915, STEP_E0, STEP_FOREVER)) { if (IS_DISPLAY_STEP(display, STEP_E0, STEP_FOREVER)) {
if (intel_dp_is_uhbr(crtc_state)) if (intel_dp_is_uhbr(crtc_state))
set |= DP_MST_SHORT_HBLANK_WA(crtc_state->cpu_transcoder); set |= DP_MST_SHORT_HBLANK_WA(crtc_state->cpu_transcoder);
else if (crtc_state->fec_enable) else if (crtc_state->fec_enable)
@ -1270,7 +1271,7 @@ static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state)
if (!clear && !set) if (!clear && !set)
return; return;
intel_de_rmw(i915, CHICKEN_MISC_3, clear, set); intel_de_rmw(display, CHICKEN_MISC_3, clear, set);
} }
static void intel_mst_enable_dp(struct intel_atomic_state *state, static void intel_mst_enable_dp(struct intel_atomic_state *state,
@ -1282,7 +1283,6 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
struct intel_encoder *primary_encoder = to_primary_encoder(encoder); struct intel_encoder *primary_encoder = to_primary_encoder(encoder);
struct intel_dp *intel_dp = to_primary_dp(encoder); struct intel_dp *intel_dp = to_primary_dp(encoder);
struct intel_connector *connector = to_intel_connector(conn_state->connector); struct intel_connector *connector = to_intel_connector(conn_state->connector);
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct drm_dp_mst_topology_state *mst_state = struct drm_dp_mst_topology_state *mst_state =
drm_atomic_get_new_mst_topology_state(&state->base, &intel_dp->mst_mgr); drm_atomic_get_new_mst_topology_state(&state->base, &intel_dp->mst_mgr);
enum transcoder trans = pipe_config->cpu_transcoder; enum transcoder trans = pipe_config->cpu_transcoder;
@ -1290,16 +1290,16 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
struct intel_crtc *pipe_crtc; struct intel_crtc *pipe_crtc;
int ret, i; int ret, i;
drm_WARN_ON(&dev_priv->drm, pipe_config->has_pch_encoder); drm_WARN_ON(display->drm, pipe_config->has_pch_encoder);
if (intel_dp_is_uhbr(pipe_config)) { if (intel_dp_is_uhbr(pipe_config)) {
const struct drm_display_mode *adjusted_mode = const struct drm_display_mode *adjusted_mode =
&pipe_config->hw.adjusted_mode; &pipe_config->hw.adjusted_mode;
u64 crtc_clock_hz = KHz(adjusted_mode->crtc_clock); u64 crtc_clock_hz = KHz(adjusted_mode->crtc_clock);
intel_de_write(dev_priv, TRANS_DP2_VFREQHIGH(pipe_config->cpu_transcoder), intel_de_write(display, TRANS_DP2_VFREQHIGH(pipe_config->cpu_transcoder),
TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz >> 24)); TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz >> 24));
intel_de_write(dev_priv, TRANS_DP2_VFREQLOW(pipe_config->cpu_transcoder), intel_de_write(display, TRANS_DP2_VFREQLOW(pipe_config->cpu_transcoder),
TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz & 0xffffff)); TRANS_DP2_VFREQ_PIXEL_CLOCK(crtc_clock_hz & 0xffffff));
} }
@ -1309,10 +1309,10 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
clear_act_sent(encoder, pipe_config); clear_act_sent(encoder, pipe_config);
intel_de_rmw(dev_priv, TRANS_DDI_FUNC_CTL(dev_priv, trans), 0, intel_de_rmw(display, TRANS_DDI_FUNC_CTL(display, trans), 0,
TRANS_DDI_DP_VC_PAYLOAD_ALLOC); TRANS_DDI_DP_VC_PAYLOAD_ALLOC);
drm_dbg_kms(&dev_priv->drm, "active links %d\n", drm_dbg_kms(display->drm, "active links %d\n",
intel_dp->active_mst_links); intel_dp->active_mst_links);
wait_for_act_sent(encoder, pipe_config); wait_for_act_sent(encoder, pipe_config);
@ -1445,13 +1445,14 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
struct drm_modeset_acquire_ctx *ctx, struct drm_modeset_acquire_ctx *ctx,
enum drm_mode_status *status) enum drm_mode_status *status)
{ {
struct intel_display *display = to_intel_display(connector->dev);
struct drm_i915_private *dev_priv = to_i915(connector->dev); struct drm_i915_private *dev_priv = to_i915(connector->dev);
struct intel_connector *intel_connector = to_intel_connector(connector); struct intel_connector *intel_connector = to_intel_connector(connector);
struct intel_dp *intel_dp = intel_connector->mst_port; struct intel_dp *intel_dp = intel_connector->mst_port;
struct drm_dp_mst_topology_mgr *mgr = &intel_dp->mst_mgr; struct drm_dp_mst_topology_mgr *mgr = &intel_dp->mst_mgr;
struct drm_dp_mst_port *port = intel_connector->port; struct drm_dp_mst_port *port = intel_connector->port;
const int min_bpp = 18; const int min_bpp = 18;
int max_dotclk = to_i915(connector->dev)->display.cdclk.max_dotclk_freq; int max_dotclk = display->cdclk.max_dotclk_freq;
int max_rate, mode_rate, max_lanes, max_link_clock; int max_rate, mode_rate, max_lanes, max_link_clock;
int ret; int ret;
bool dsc = false; bool dsc = false;
@ -1624,12 +1625,12 @@ static int intel_dp_mst_add_properties(struct intel_dp *intel_dp,
struct drm_connector *connector, struct drm_connector *connector,
const char *pathprop) const char *pathprop)
{ {
struct drm_i915_private *i915 = to_i915(connector->dev); struct intel_display *display = to_intel_display(intel_dp);
drm_object_attach_property(&connector->base, drm_object_attach_property(&connector->base,
i915->drm.mode_config.path_property, 0); display->drm->mode_config.path_property, 0);
drm_object_attach_property(&connector->base, drm_object_attach_property(&connector->base,
i915->drm.mode_config.tile_property, 0); display->drm->mode_config.tile_property, 0);
intel_attach_force_audio_property(connector); intel_attach_force_audio_property(connector);
intel_attach_broadcast_rgb_property(connector); intel_attach_broadcast_rgb_property(connector);
@ -1663,7 +1664,7 @@ intel_dp_mst_read_decompression_port_dsc_caps(struct intel_dp *intel_dp,
static bool detect_dsc_hblank_expansion_quirk(const struct intel_connector *connector) static bool detect_dsc_hblank_expansion_quirk(const struct intel_connector *connector)
{ {
struct drm_i915_private *i915 = to_i915(connector->base.dev); struct intel_display *display = to_intel_display(connector);
struct drm_dp_aux *aux = connector->dp.dsc_decompression_aux; struct drm_dp_aux *aux = connector->dp.dsc_decompression_aux;
struct drm_dp_desc desc; struct drm_dp_desc desc;
u8 dpcd[DP_RECEIVER_CAP_SIZE]; u8 dpcd[DP_RECEIVER_CAP_SIZE];
@ -1701,7 +1702,7 @@ static bool detect_dsc_hblank_expansion_quirk(const struct intel_connector *conn
!(dpcd[DP_RECEIVE_PORT_0_CAP_0] & DP_HBLANK_EXPANSION_CAPABLE)) !(dpcd[DP_RECEIVE_PORT_0_CAP_0] & DP_HBLANK_EXPANSION_CAPABLE))
return false; return false;
drm_dbg_kms(&i915->drm, drm_dbg_kms(display->drm,
"[CONNECTOR:%d:%s] DSC HBLANK expansion quirk detected\n", "[CONNECTOR:%d:%s] DSC HBLANK expansion quirk detected\n",
connector->base.base.id, connector->base.name); connector->base.base.id, connector->base.name);
@ -1713,9 +1714,8 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
const char *pathprop) const char *pathprop)
{ {
struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr); struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
struct intel_display *display = to_intel_display(intel_dp);
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
struct drm_device *dev = dig_port->base.base.dev;
struct drm_i915_private *dev_priv = to_i915(dev);
struct intel_connector *intel_connector; struct intel_connector *intel_connector;
struct drm_connector *connector; struct drm_connector *connector;
enum pipe pipe; enum pipe pipe;
@ -1739,7 +1739,7 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
detect_dsc_hblank_expansion_quirk(intel_connector); detect_dsc_hblank_expansion_quirk(intel_connector);
connector = &intel_connector->base; connector = &intel_connector->base;
ret = drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, ret = drm_connector_init(display->drm, connector, &intel_dp_mst_connector_funcs,
DRM_MODE_CONNECTOR_DisplayPort); DRM_MODE_CONNECTOR_DisplayPort);
if (ret) { if (ret) {
drm_dp_mst_put_port_malloc(port); drm_dp_mst_put_port_malloc(port);
@ -1749,7 +1749,7 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs); drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
for_each_pipe(dev_priv, pipe) { for_each_pipe(display, pipe) {
struct drm_encoder *enc = struct drm_encoder *enc =
&intel_dp->mst_encoders[pipe]->base.base; &intel_dp->mst_encoders[pipe]->base.base;
@ -1764,7 +1764,7 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
ret = intel_dp_hdcp_init(dig_port, intel_connector); ret = intel_dp_hdcp_init(dig_port, intel_connector);
if (ret) if (ret)
drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP MST init failed, skipping.\n", drm_dbg_kms(display->drm, "[%s:%d] HDCP MST init failed, skipping.\n",
connector->name, connector->base.id); connector->name, connector->base.id);
return connector; return connector;
@ -1790,10 +1790,10 @@ static const struct drm_dp_mst_topology_cbs mst_cbs = {
static struct intel_dp_mst_encoder * static struct intel_dp_mst_encoder *
intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe pipe) intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe pipe)
{ {
struct intel_display *display = to_intel_display(dig_port);
struct intel_encoder *primary_encoder = &dig_port->base; struct intel_encoder *primary_encoder = &dig_port->base;
struct intel_dp_mst_encoder *intel_mst; struct intel_dp_mst_encoder *intel_mst;
struct intel_encoder *encoder; struct intel_encoder *encoder;
struct drm_device *dev = dig_port->base.base.dev;
intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL); intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
@ -1804,7 +1804,7 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe
encoder = &intel_mst->base; encoder = &intel_mst->base;
intel_mst->primary = dig_port; intel_mst->primary = dig_port;
drm_encoder_init(dev, &encoder->base, &intel_dp_mst_enc_funcs, drm_encoder_init(display->drm, &encoder->base, &intel_dp_mst_enc_funcs,
DRM_MODE_ENCODER_DPMST, "DP-MST %c", pipe_name(pipe)); DRM_MODE_ENCODER_DPMST, "DP-MST %c", pipe_name(pipe));
encoder->type = INTEL_OUTPUT_DP_MST; encoder->type = INTEL_OUTPUT_DP_MST;
@ -1843,11 +1843,11 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe
static bool static bool
intel_dp_create_fake_mst_encoders(struct intel_digital_port *dig_port) intel_dp_create_fake_mst_encoders(struct intel_digital_port *dig_port)
{ {
struct intel_display *display = to_intel_display(dig_port);
struct intel_dp *intel_dp = &dig_port->dp; struct intel_dp *intel_dp = &dig_port->dp;
struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
enum pipe pipe; enum pipe pipe;
for_each_pipe(dev_priv, pipe) for_each_pipe(display, pipe)
intel_dp->mst_encoders[pipe] = intel_dp_create_fake_mst_encoder(dig_port, pipe); intel_dp->mst_encoders[pipe] = intel_dp_create_fake_mst_encoder(dig_port, pipe);
return true; return true;
} }
@ -1861,25 +1861,25 @@ intel_dp_mst_encoder_active_links(struct intel_digital_port *dig_port)
int int
intel_dp_mst_encoder_init(struct intel_digital_port *dig_port, int conn_base_id) intel_dp_mst_encoder_init(struct intel_digital_port *dig_port, int conn_base_id)
{ {
struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev); struct intel_display *display = to_intel_display(dig_port);
struct intel_dp *intel_dp = &dig_port->dp; struct intel_dp *intel_dp = &dig_port->dp;
enum port port = dig_port->base.port; enum port port = dig_port->base.port;
int ret; int ret;
if (!HAS_DP_MST(i915) || intel_dp_is_edp(intel_dp)) if (!HAS_DP_MST(display) || intel_dp_is_edp(intel_dp))
return 0; return 0;
if (DISPLAY_VER(i915) < 12 && port == PORT_A) if (DISPLAY_VER(display) < 12 && port == PORT_A)
return 0; return 0;
if (DISPLAY_VER(i915) < 11 && port == PORT_E) if (DISPLAY_VER(display) < 11 && port == PORT_E)
return 0; return 0;
intel_dp->mst_mgr.cbs = &mst_cbs; intel_dp->mst_mgr.cbs = &mst_cbs;
/* create encoders */ /* create encoders */
intel_dp_create_fake_mst_encoders(dig_port); intel_dp_create_fake_mst_encoders(dig_port);
ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, &i915->drm, ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, display->drm,
&intel_dp->aux, 16, 3, conn_base_id); &intel_dp->aux, 16, 3, conn_base_id);
if (ret) { if (ret) {
intel_dp->mst_mgr.cbs = NULL; intel_dp->mst_mgr.cbs = NULL;