mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-10-31 08:38:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

sched: Remove never used code in mm_cid_get()

Browse source 
Clang is not happy with set but unused variable (this is visible
with `make W=1` build:

  kernel/sched/sched.h:3744:18: error: variable 'cpumask' set but not used [-Werror,-Wunused-but-set-variable]

It seems like the variable was never used along with the assignment
that does not have side effects as far as I can see.  Remove those
altogether.

Fixes: 223baf9d17 ("sched: Fix performance regression introduced by mm_cid")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Eric Biggers <ebiggers@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andy Shevchenko 2025-10-15 11:19:34 +02:00 committed by Linus Torvalds
parent 3d08a425d2
commit 53abe3e1c1
1 changed files with 0 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
kernel/sched/sched.h
View file

@ -3740,11 +3740,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t,
struct mm_struct *mm) struct mm_struct *mm)
{ {
struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid; struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid;
struct cpumask *cpumask;
int cid; int cid;
lockdep_assert_rq_held(rq); lockdep_assert_rq_held(rq);
cpumask = mm_cidmask(mm);
cid = __this_cpu_read(pcpu_cid->cid); cid = __this_cpu_read(pcpu_cid->cid);
if (mm_cid_is_valid(cid)) { if (mm_cid_is_valid(cid)) {
mm_cid_snapshot_time(rq, mm); mm_cid_snapshot_time(rq, mm);