mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

kernel/resource.c: fix muxed resource handling in __request_region()

Browse source 
In __request_region, if a conflict with a BUSY and MUXED resource is
detected, then the caller goes to sleep and waits for the resource to be
released.  A pointer on the conflicting resource is kept.  At wake-up
this pointer is used as a parent to retry to request the region.

A first problem is that this pointer might well be invalid (if for
example the conflicting resource have already been freed).  Another
problem is that the next call to __request_region() fails to detect a
remaining conflict.  The previously conflicting resource is passed as a
parameter and __request_region() will look for a conflict among the
children of this resource and not at the resource itself.  It is likely
to succeed anyway, even if there is still a conflict.

Instead, the parent of the conflicting resource should be passed to
__request_region().

As a fix, this patch doesn't update the parent resource pointer in the
case we have to wait for a muxed region right after.

Reported-and-tested-by: Vincent Pelletier <plr.vincent@gmail.com>
Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
Tested-by: Vincent Donnefort <vdonnefort@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Simon Guinot 2015-09-10 00:15:18 +02:00 committed by Linus Torvalds
parent 020ecbba05
commit 59ceeaaf35
1 changed files with 3 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
kernel/resource.c
View file

@ -1083,10 +1083,11 @@ struct resource * __request_region(struct resource *parent,
if (!conflict) if (!conflict)
break; break;
if (conflict != parent) { if (conflict != parent) {
if (!(conflict->flags & IORESOURCE_BUSY)) {
parent = conflict; parent = conflict;
if (!(conflict->flags & IORESOURCE_BUSY))
continue; continue;
} }
}
if (conflict->flags & flags & IORESOURCE_MUXED) { if (conflict->flags & flags & IORESOURCE_MUXED) {
add_wait_queue(&muxed_resource_wait, &wait); add_wait_queue(&muxed_resource_wait, &wait);
write_unlock(&resource_lock); write_unlock(&resource_lock);