mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Connector: Correctly set the error code in case of success when dispatching receive callbacks

Browse source 
The recent changes to the connector code introduced this bug where even
when a callback was invoked, we would return an error resulting in
double freeing of the skb. This patch fixes this bug.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Cc: stable <stable@kernel.org>  [.39]
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
K. Y. Srinivasan 2011-05-17 15:25:38 -07:00 committed by Greg Kroah-Hartman
parent ea2c00095c
commit 663dd6dcaf
1 changed files with 1 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/connector/connector.c
View file

@ -139,6 +139,7 @@ static int cn_call_callback(struct sk_buff *skb)
spin_unlock_bh(&dev->cbdev->queue_lock); spin_unlock_bh(&dev->cbdev->queue_lock);
if (cbq != NULL) { if (cbq != NULL) {
err = 0;
cbq->callback(msg, nsp); cbq->callback(msg, nsp);
kfree_skb(skb); kfree_skb(skb);
cn_queue_release_callback(cbq); cn_queue_release_callback(cbq);