mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	mm: remove nr_pages argument from pagevec_lookup_{,range}_tag()
All users of pagevec_lookup() and pagevec_lookup_range() now pass PAGEVEC_SIZE as a desired number of pages. Just drop the argument. Link: http://lkml.kernel.org/r/20171009151359.31984-15-jack@suse.cz Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
		
							parent
							
								
									4be90299a1
								
							
						
					
					
						commit
						67fd707f46
					
				
					 14 changed files with 27 additions and 31 deletions
				
			
		| 
						 | 
				
			
			@ -3815,7 +3815,7 @@ int btree_write_cache_pages(struct address_space *mapping,
 | 
			
		|||
		tag_pages_for_writeback(mapping, index, end);
 | 
			
		||||
	while (!done && !nr_to_write_done && (index <= end) &&
 | 
			
		||||
	       (nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
 | 
			
		||||
			tag, PAGEVEC_SIZE))) {
 | 
			
		||||
			tag))) {
 | 
			
		||||
		unsigned i;
 | 
			
		||||
 | 
			
		||||
		scanned = 1;
 | 
			
		||||
| 
						 | 
				
			
			@ -3956,8 +3956,8 @@ static int extent_write_cache_pages(struct address_space *mapping,
 | 
			
		|||
		tag_pages_for_writeback(mapping, index, end);
 | 
			
		||||
	done_index = index;
 | 
			
		||||
	while (!done && !nr_to_write_done && (index <= end) &&
 | 
			
		||||
	       (nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
 | 
			
		||||
			tag, PAGEVEC_SIZE))) {
 | 
			
		||||
			(nr_pages = pagevec_lookup_range_tag(&pvec, mapping,
 | 
			
		||||
						&index, end, tag))) {
 | 
			
		||||
		unsigned i;
 | 
			
		||||
 | 
			
		||||
		scanned = 1;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -1162,8 +1162,7 @@ static int ceph_writepages_start(struct address_space *mapping,
 | 
			
		|||
			index = 0;
 | 
			
		||||
			while ((index <= end) &&
 | 
			
		||||
			       (nr = pagevec_lookup_tag(&pvec, mapping, &index,
 | 
			
		||||
							PAGECACHE_TAG_WRITEBACK,
 | 
			
		||||
							PAGEVEC_SIZE))) {
 | 
			
		||||
						PAGECACHE_TAG_WRITEBACK))) {
 | 
			
		||||
				for (i = 0; i < nr; i++) {
 | 
			
		||||
					page = pvec.pages[i];
 | 
			
		||||
					if (page_snap_context(page) != snapc)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -2621,7 +2621,7 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
 | 
			
		|||
	mpd->next_page = index;
 | 
			
		||||
	while (index <= end) {
 | 
			
		||||
		nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
 | 
			
		||||
				tag, PAGEVEC_SIZE);
 | 
			
		||||
				tag);
 | 
			
		||||
		if (nr_pages == 0)
 | 
			
		||||
			goto out;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -319,7 +319,7 @@ long sync_meta_pages(struct f2fs_sb_info *sbi, enum page_type type,
 | 
			
		|||
	blk_start_plug(&plug);
 | 
			
		||||
 | 
			
		||||
	while ((nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
 | 
			
		||||
				PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE))) {
 | 
			
		||||
				PAGECACHE_TAG_DIRTY))) {
 | 
			
		||||
		int i;
 | 
			
		||||
 | 
			
		||||
		for (i = 0; i < nr_pages; i++) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -1670,7 +1670,7 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
 | 
			
		|||
		int i;
 | 
			
		||||
 | 
			
		||||
		nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
 | 
			
		||||
				tag, PAGEVEC_SIZE);
 | 
			
		||||
				tag);
 | 
			
		||||
		if (nr_pages == 0)
 | 
			
		||||
			break;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -1286,7 +1286,7 @@ static struct page *last_fsync_dnode(struct f2fs_sb_info *sbi, nid_t ino)
 | 
			
		|||
	index = 0;
 | 
			
		||||
 | 
			
		||||
	while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index,
 | 
			
		||||
				PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE))) {
 | 
			
		||||
				PAGECACHE_TAG_DIRTY))) {
 | 
			
		||||
		int i;
 | 
			
		||||
 | 
			
		||||
		for (i = 0; i < nr_pages; i++) {
 | 
			
		||||
| 
						 | 
				
			
			@ -1440,7 +1440,7 @@ int fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
 | 
			
		|||
	index = 0;
 | 
			
		||||
 | 
			
		||||
	while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index,
 | 
			
		||||
				PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE))) {
 | 
			
		||||
				PAGECACHE_TAG_DIRTY))) {
 | 
			
		||||
		int i;
 | 
			
		||||
 | 
			
		||||
		for (i = 0; i < nr_pages; i++) {
 | 
			
		||||
| 
						 | 
				
			
			@ -1553,7 +1553,7 @@ int sync_node_pages(struct f2fs_sb_info *sbi, struct writeback_control *wbc,
 | 
			
		|||
	index = 0;
 | 
			
		||||
 | 
			
		||||
	while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index,
 | 
			
		||||
				PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE))) {
 | 
			
		||||
				PAGECACHE_TAG_DIRTY))) {
 | 
			
		||||
		int i;
 | 
			
		||||
 | 
			
		||||
		for (i = 0; i < nr_pages; i++) {
 | 
			
		||||
| 
						 | 
				
			
			@ -1651,7 +1651,7 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
 | 
			
		|||
	pagevec_init(&pvec, 0);
 | 
			
		||||
 | 
			
		||||
	while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index,
 | 
			
		||||
				PAGECACHE_TAG_WRITEBACK, PAGEVEC_SIZE))) {
 | 
			
		||||
				PAGECACHE_TAG_WRITEBACK))) {
 | 
			
		||||
		int i;
 | 
			
		||||
 | 
			
		||||
		for (i = 0; i < nr_pages; i++) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -398,7 +398,7 @@ static int gfs2_write_cache_jdata(struct address_space *mapping,
 | 
			
		|||
	done_index = index;
 | 
			
		||||
	while (!done && (index <= end)) {
 | 
			
		||||
		nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
 | 
			
		||||
				tag, PAGEVEC_SIZE);
 | 
			
		||||
				tag);
 | 
			
		||||
		if (nr_pages == 0)
 | 
			
		||||
			break;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -2158,8 +2158,8 @@ static void nilfs_btree_lookup_dirty_buffers(struct nilfs_bmap *btree,
 | 
			
		|||
 | 
			
		||||
	pagevec_init(&pvec, 0);
 | 
			
		||||
 | 
			
		||||
	while (pagevec_lookup_tag(&pvec, btcache, &index, PAGECACHE_TAG_DIRTY,
 | 
			
		||||
				  PAGEVEC_SIZE)) {
 | 
			
		||||
	while (pagevec_lookup_tag(&pvec, btcache, &index,
 | 
			
		||||
					PAGECACHE_TAG_DIRTY)) {
 | 
			
		||||
		for (i = 0; i < pagevec_count(&pvec); i++) {
 | 
			
		||||
			bh = head = page_buffers(pvec.pages[i]);
 | 
			
		||||
			do {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -257,8 +257,7 @@ int nilfs_copy_dirty_pages(struct address_space *dmap,
 | 
			
		|||
 | 
			
		||||
	pagevec_init(&pvec, 0);
 | 
			
		||||
repeat:
 | 
			
		||||
	if (!pagevec_lookup_tag(&pvec, smap, &index, PAGECACHE_TAG_DIRTY,
 | 
			
		||||
				PAGEVEC_SIZE))
 | 
			
		||||
	if (!pagevec_lookup_tag(&pvec, smap, &index, PAGECACHE_TAG_DIRTY))
 | 
			
		||||
		return 0;
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < pagevec_count(&pvec); i++) {
 | 
			
		||||
| 
						 | 
				
			
			@ -376,8 +375,8 @@ void nilfs_clear_dirty_pages(struct address_space *mapping, bool silent)
 | 
			
		|||
 | 
			
		||||
	pagevec_init(&pvec, 0);
 | 
			
		||||
 | 
			
		||||
	while (pagevec_lookup_tag(&pvec, mapping, &index, PAGECACHE_TAG_DIRTY,
 | 
			
		||||
				  PAGEVEC_SIZE)) {
 | 
			
		||||
	while (pagevec_lookup_tag(&pvec, mapping, &index,
 | 
			
		||||
					PAGECACHE_TAG_DIRTY)) {
 | 
			
		||||
		for (i = 0; i < pagevec_count(&pvec); i++) {
 | 
			
		||||
			struct page *page = pvec.pages[i];
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -712,7 +712,7 @@ static size_t nilfs_lookup_dirty_data_buffers(struct inode *inode,
 | 
			
		|||
 repeat:
 | 
			
		||||
	if (unlikely(index > last) ||
 | 
			
		||||
	    !pagevec_lookup_range_tag(&pvec, mapping, &index, last,
 | 
			
		||||
				PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE))
 | 
			
		||||
				PAGECACHE_TAG_DIRTY))
 | 
			
		||||
		return ndirties;
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < pagevec_count(&pvec); i++) {
 | 
			
		||||
| 
						 | 
				
			
			@ -755,8 +755,8 @@ static void nilfs_lookup_dirty_node_buffers(struct inode *inode,
 | 
			
		|||
 | 
			
		||||
	pagevec_init(&pvec, 0);
 | 
			
		||||
 | 
			
		||||
	while (pagevec_lookup_tag(&pvec, mapping, &index, PAGECACHE_TAG_DIRTY,
 | 
			
		||||
				  PAGEVEC_SIZE)) {
 | 
			
		||||
	while (pagevec_lookup_tag(&pvec, mapping, &index,
 | 
			
		||||
					PAGECACHE_TAG_DIRTY)) {
 | 
			
		||||
		for (i = 0; i < pagevec_count(&pvec); i++) {
 | 
			
		||||
			bh = head = page_buffers(pvec.pages[i]);
 | 
			
		||||
			do {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -40,16 +40,14 @@ static inline unsigned pagevec_lookup(struct pagevec *pvec,
 | 
			
		|||
 | 
			
		||||
unsigned pagevec_lookup_range_tag(struct pagevec *pvec,
 | 
			
		||||
		struct address_space *mapping, pgoff_t *index, pgoff_t end,
 | 
			
		||||
		int tag, unsigned nr_pages);
 | 
			
		||||
		int tag);
 | 
			
		||||
unsigned pagevec_lookup_range_nr_tag(struct pagevec *pvec,
 | 
			
		||||
		struct address_space *mapping, pgoff_t *index, pgoff_t end,
 | 
			
		||||
		int tag, unsigned max_pages);
 | 
			
		||||
static inline unsigned pagevec_lookup_tag(struct pagevec *pvec,
 | 
			
		||||
		struct address_space *mapping, pgoff_t *index, int tag,
 | 
			
		||||
		unsigned nr_pages)
 | 
			
		||||
		struct address_space *mapping, pgoff_t *index, int tag)
 | 
			
		||||
{
 | 
			
		||||
	return pagevec_lookup_range_tag(pvec, mapping, index, (pgoff_t)-1, tag,
 | 
			
		||||
					nr_pages);
 | 
			
		||||
	return pagevec_lookup_range_tag(pvec, mapping, index, (pgoff_t)-1, tag);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
static inline void pagevec_init(struct pagevec *pvec, int cold)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -424,7 +424,7 @@ static void __filemap_fdatawait_range(struct address_space *mapping,
 | 
			
		|||
		unsigned i;
 | 
			
		||||
 | 
			
		||||
		nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
 | 
			
		||||
				end, PAGECACHE_TAG_WRITEBACK, PAGEVEC_SIZE);
 | 
			
		||||
				end, PAGECACHE_TAG_WRITEBACK);
 | 
			
		||||
		if (!nr_pages)
 | 
			
		||||
			break;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -2197,7 +2197,7 @@ int write_cache_pages(struct address_space *mapping,
 | 
			
		|||
		int i;
 | 
			
		||||
 | 
			
		||||
		nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
 | 
			
		||||
				tag, PAGEVEC_SIZE);
 | 
			
		||||
				tag);
 | 
			
		||||
		if (nr_pages == 0)
 | 
			
		||||
			break;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -988,10 +988,10 @@ EXPORT_SYMBOL(pagevec_lookup_range);
 | 
			
		|||
 | 
			
		||||
unsigned pagevec_lookup_range_tag(struct pagevec *pvec,
 | 
			
		||||
		struct address_space *mapping, pgoff_t *index, pgoff_t end,
 | 
			
		||||
		int tag, unsigned nr_pages)
 | 
			
		||||
		int tag)
 | 
			
		||||
{
 | 
			
		||||
	pvec->nr = find_get_pages_range_tag(mapping, index, end, tag,
 | 
			
		||||
					nr_pages, pvec->pages);
 | 
			
		||||
					PAGEVEC_SIZE, pvec->pages);
 | 
			
		||||
	return pagevec_count(pvec);
 | 
			
		||||
}
 | 
			
		||||
EXPORT_SYMBOL(pagevec_lookup_range_tag);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue