mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	drm/fb-helper: generic: Call drm_client_add() after setup is done
Hotplug can happen while drm_fbdev_generic_setup() is running so move
drm_client_add() call after setup is done to avoid
drm_fbdev_client_hotplug() running in two threads at the same time.
Fixes: 9060d7f493 ("drm/fb-helper: Finish the generic fbdev emulation")
Cc: stable@vger.kernel.org
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190401141358.25309-1-noralf@tronnes.org
			
			
This commit is contained in:
		
							parent
							
								
									d7f9b83913
								
							
						
					
					
						commit
						6e3f17ee73
					
				
					 1 changed files with 2 additions and 2 deletions
				
			
		|  | @ -3312,8 +3312,6 @@ int drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) | |||
| 		return ret; | ||||
| 	} | ||||
| 
 | ||||
| 	drm_client_add(&fb_helper->client); | ||||
| 
 | ||||
| 	if (!preferred_bpp) | ||||
| 		preferred_bpp = dev->mode_config.preferred_depth; | ||||
| 	if (!preferred_bpp) | ||||
|  | @ -3324,6 +3322,8 @@ int drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) | |||
| 	if (ret) | ||||
| 		DRM_DEV_DEBUG(dev->dev, "client hotplug ret=%d\n", ret); | ||||
| 
 | ||||
| 	drm_client_add(&fb_helper->client); | ||||
| 
 | ||||
| 	return 0; | ||||
| } | ||||
| EXPORT_SYMBOL(drm_fbdev_generic_setup); | ||||
|  |  | |||
		Loading…
	
		Reference in a new issue
	
	 Noralf Trønnes
						Noralf Trønnes