mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 10:40:15 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/udl: Replace BUG_ON() with WARN_ON()

Browse source 
BUG_ON() is a tasteless choice as a sanity check for a driver like UDL
that isn't really a core code.  Replace with WARN_ON() and proper
error handling instead.

Tested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220804075826.27036-5-tiwai@suse.de
This commit is contained in:
Takashi Iwai 2022-08-04 09:58:26 +02:00 committed by Thomas Zimmermann
parent e25d595426
commit 7350b2a3fb
2 changed files with 4 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/gpu/drm/udl/udl_main.c
View file

@ -260,7 +260,8 @@ int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len)
struct udl_device *udl = to_udl(dev); struct udl_device *udl = to_udl(dev);
int ret; int ret;
BUG_ON(len > udl->urbs.size); if (WARN_ON(len > udl->urbs.size))
return -EINVAL;
urb->transfer_buffer_length = len; /* set to actual payload len */ urb->transfer_buffer_length = len; /* set to actual payload len */
ret = usb_submit_urb(urb, GFP_ATOMIC); ret = usb_submit_urb(urb, GFP_ATOMIC);

3
drivers/gpu/drm/udl/udl_transfer.c
View file

@ -220,7 +220,8 @@ int udl_render_hline(struct drm_device *dev, int log_bpp, struct urb **urb_ptr,
u8 *cmd = *urb_buf_ptr; u8 *cmd = *urb_buf_ptr;
u8 *cmd_end = (u8 *) urb->transfer_buffer + urb->transfer_buffer_length; u8 *cmd_end = (u8 *) urb->transfer_buffer + urb->transfer_buffer_length;
BUG_ON(!(log_bpp == 1 || log_bpp == 2)); if (WARN_ON(!(log_bpp == 1 || log_bpp == 2)))
return -EINVAL;
line_start = (u8 *) (front + byte_offset); line_start = (u8 *) (front + byte_offset);
next_pixel = line_start; next_pixel = line_start;